- Fixes#21802
The estimate from #21678 made the first-frame readback read back a part of
any buffer drawn in through mode. In the Japanese GTA games, that writes a
64x320 strip of the 32-bit loading screen into VRAM, where the two 16-bit
display buffers later go. Nothing else writes that memory, and when pausing,
the game shows one of them for a few frames before drawing it, which we then
display from memory, pink strip and all. Before, it was all black.
The estimate was for small render targets (Evangelion Jo's menu text), so
limit it to buffers smaller than the screen.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Nothing calls it any more. Its SSE path also had the left and right
volumes swapped (_mm_set_epi16 takes its arguments high lane first).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
On by default. Off gives the hardware's unfiltered rate conversions
around the reverb: the send decimated by keeping the second frame of
each pair, and the output zero-stuffed at double level. With it off,
pspautotests' audio/reverb/upsample matches its .expected.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The ME decimates the send by keeping one frame of each pair, so
everything above 11khz aliases into the reverb (pspautotests'
audio/reverb/upsample: a 22.05khz tone reaches it as DC). Use the
output side's half-band filter at half gain instead. Splitting the send
into its even and odd frames first makes each tap one multiply-add for
two outputs and both channels.
This deliberately departs from the hardware, like the output side.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The "off" path decimated the send to 22khz and then doubled every
sample, which folded everything above 11khz down. The ME runs a
separate full-rate loop for it instead: pspautotests'
audio/reverb/upsample shows a 22.05khz tone surviving with no reverb
selected. The comments on the reverb's resampling now cite that test
too.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Filter the whole grain at once, from a float history. Each input frame
gives one vector holding both output frames for both channels, already
in output order, so each tap is one load and one multiply-add.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A signed saturating narrow to 16 bits. Vec4U16::FromVec4S32 can't stand
in for it: it saturates unsigned on SSE and LSX and truncates on NEON.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The ME upsamples the 22khz wet signal by putting it on every other
44khz frame at double gain. That leaves a full-amplitude mirror image
of the reverb just below 22khz, which eats the mix's headroom: in
Outrun 2006 it put about a fifth of the output energy above 15khz and
made the final mix clip hard, mostly in the left channel.
Replace it with a 24-tap half-band interpolation filter (flat to 9khz,
-69dB from 13khz up), at the same average level. This deliberately
departs from the hardware.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- StereoResampler: the interpolation multiplied a 17-bit difference by a
16-bit fraction in 32 bits, which wraps when adjacent samples are more
than half the range apart. Same with the volume multiply on a loud mix.
- StereoResampler: the padding after an underrun took left from the right
sample and right from the left.
- SAS reverb: the four comb products could sum past 32 bits, and the
return multiply overflowed once the output passed 16 bits.
- SAS: a fast decay can leave the envelope height negative for a sample,
which mixed that sample inverted.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pspautotests modules/selfunload and modules/idlist show:
- sceKernelGetModuleId and the self stop/unload calls act on the module the caller's code is in,
not the module that created the thread.
- Address lookups cover text_addr up to the text, data and bss sizes, and refuse kernel addresses
from user mode (ILLEGAL_ADDR).
- sceKernelStopUnloadSelfModule takes (argSize, argp, status, option) and exits with 0. It was
unimplemented for user mode and given the wrong arguments for kernel mode.
- When module_stop returns 0, the module is unloaded and the calling thread exits with its exit
code. A return of 1 gives CAN_NOT_STOP; any other nonzero value gives NOT_REMOVABLE. In both
cases the module stays started and the status gets the value.
- GetModuleIdList refuses a NULL or kernel count pointer.
- text_size leaves out .MIPS.abiflags.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Many games drop to 30fps when they miss a vblank, and on the PSP some of them
nearly always do. In PPSSPP the GE is fast enough that they spend much of their
time at 60 instead, and some things misbehave (Midnight Club).
With the limit on, the GE takes until just after the vblank two on from the one
the previous frame was done in, so the frame goes up every other vblank whether
the game flips as soon as it's done, waits for a vblank first, or latches the
flip. A new frame starts at the first list after a flip, or at a list that
starts after a vblank, for games that enqueue their lists from the vblank
interrupt and never flip (Midnight Club: LA Remix).
Auto applies it to games with the LimitFrameRateTo30 compat flag, the two
Midnight Club games for now.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Headless has no config to keep the version the app stores on install, so
it stayed 1 and every XMB boot ran the registry upgrade, rewriting the
defaults of all keys added since 1.50, mapped settings included.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Fixes#22920
Map the XMB's /CONFIG/VIDEO keys (UMD menu, audio and subtitle language,
volume, L/R button, sequential playback, title display), the slideshow
speed, CHARACTER_SET/oem and ansi, and the lock password to new config
settings, so they survive a restart. The languages and password are BIN
keys, stored in the config as text ("en", "0000"); a setting of the wrong
length or with unprintable bytes isn't used. Defaults are the values of
our registry dump. Also fix two key names in the mapping comment.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
devctl 0x02425856 sets the code page for 8.3 names (fatms.prx in 6.61
passes the word to sceCodepage). It was only handled on ms0:, and on
fatms0: fell through to the unimplemented path, whose
SCE_KERNEL_ERROR_UNSUP is the 80020325 the XMB showed after changing
System Settings > Character Set. Also check the argument like fatms does.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Under version 1, a frontend that presents from another thread (RetroArch's
threaded video, now its default) can only hand the core a deferred context,
which can't map a staging texture or read anything back. Texture uploads that
go through a staging texture failed there ("Failed to create DrawPixels
texture"), and so would every readback.
Version 2 shares the immediate context by taking turns. We hold it for the
whole of retro_run and around savestates, reset and unload, wait for the
frame's sync index before taking it, copy the frame into a texture per sync
index and hand that over with set_texture, and let go of it before
video_refresh. A frontend without the negotiation hands out version 1, which
works as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Fixes#22748
thin3d never uses these stages, so it never set them. A libretro frontend
shares the immediate context with us, and recent RetroArch leaves its sprite
geometry shader bound after drawing its frame, so every one of our draws went
through it and the core output was black (with threaded video off, where the
core draws on the frontend's context).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With the navigation bar hidden, a swipe from the edge brings it back for
a while, over the pause screen's buttons on that edge. Android now also
reports where the navigation bar is when it's hidden, and a screen can
reserve that area with ReserveHiddenNavBar(). The pause screen does.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Since the native EGL path, the Android context stays current on the
render thread until the render manager and the draw context are gone, and
it's destroyed with every surface. So the GL calls skip mode avoided
after the emu thread exits (Android was the only platform that set it)
can just run, and nothing it would have leaked outlives the context.
It was also a trap: a shader created while it was on was never compiled,
but not marked failed either, so a program linked from it later failed
with "missing shader". Reports of that stopped with 3cb6ada66a, which
already took most of its uses away.
ThreadEnd still frees the steps that never got submitted without running
them, now called a dry run.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With a display resolution set (iAndroidHwScale), the surface has a fixed
size, and a rotation doesn't change it, so no surfaceChanged came to
re-fix it there. Landscape kept rendering into the portrait-sized buffer.
A layout listener on the SurfaceView now re-measures and re-fixes it,
which brings a surfaceChanged with the new size.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pixel_in_dps_y is the inverse of a pixel's height in UI coordinates, so use the ratio of the resolutions.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Smooth R, G, B and gray ramps, gray steps over the whole range and near
black and white, color bars, two hue wheels (fading to white and to
black), and 1-pixel black and white lines around 128 and 188 patches,
showing whether a resampled image is averaged in linear light or encoded.
The header names the backend and whether VR is on, for comparing outputs.
Also --start-screen=colortest.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
UIContext's destructor now copes with a context that was never given a
draw context, so a test can measure views with one.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
FlowLayout lays out its children left to right at their natural size and
starts a new row when the next one doesn't fit, instead of squeezing
them. Weighted children fill what's left of their row. Like LinearLayout,
it has SetPadding for space inside its edges.
On narrow screens the toolbar buttons used to run off the edge; now they
wrap onto a second row.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
After measuring the weighted children, the measured size could grow beyond
the AT_MOST size the parent allowed.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
At shutdown the kernel objects are cleared before the net module stops
its Apctl thread, so this fired from nearly every game that used it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
From going through what report.ppsspp.org still gets from v1.20.4 and
later. The logging stays:
- Module load options: invalid positions are rejected (and reported)
before this, the rest is handled.
- Savedata versions 1-3 are normal, only higher ones are rejected.
- sceNetAdhocMatchingInit, sceIoAssign and the screenshot dialog's init:
every call was reported.
- sceKernelStopUnloadSelfModuleWithStatus is implemented, like the
version without status, which already wasn't reported.
- Thread attributes we ignore, morph and spline vertex types, BREAK, and
the POPS emulator invalidating code near the PC.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Like the queries. Opening a file through the content resolver takes and
drops a stable reference to the provider for each call, and is a few ms
slower: opening for a read or an overwrite went from about 25 and 12 ms
to 22 and 10.5 ms in the storage test, on a phone's SD card. If the
provider has died, it falls back to the resolver.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
