mirror of
https://github.com/hrydgard/ppsspp.git
synced 2026-09-01 18:25:19 +02:00
AddLabel() won't overwrite an existing label. That's deliberate and right for bulk import - a real ELF symbol name shouldn't lose to the analyzer's later z_un_* - but wrong when someone is explicitly naming an address, so a second hle.data.add at the same address silently kept the old name. The response echoed the requested name back either way, so there was no sign anything had been ignored. Force the requested name in with SetLabelName() now, except when a function starts at that address and owns the label - renaming that function isn't what "label this data" should mean, and it would undo the care hle.data.remove takes not to destroy it. Either way the response now reports the name the symbol actually ended up with rather than the one that was asked for. Also, in the ImDebugger memcheck edit form: the Enabled checkbox didn't mark the memcheck as changed, and the condition combo marked it changed on every frame the popup was open rather than when a condition was actually picked (Selectable returns true only on click, BeginCombo stays true while open). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GZq8ZtJmFY7bkX5FVkr3P9