sceMpegAvcDecode called again on an access unit it has already decoded passes
the ME an empty one, and on a PSP that fails with 0x80628002
(pspautotests video/mpeg/decoderepeat). We returned success with no picture.
A movie player that retries the same access unit until a picture comes back
then never got out of its loop, and as the decode took no time, it starved the
lower-priority thread that feeds the ringbuffer.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
X11, which the Vulkan headers bring in, defines Screen. NativeApp gets the
custom driver functions from VulkanDriverVars.h instead of VulkanLoader.h,
and the GPU debug overlays take their font from the caller instead of
including View.h for the theme.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There the backend is never given up on, but a custom driver that crashed
Vulkan last time is cleared, and Vulkan is tried again with the system's.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Before falling back to OpenGL. Covers the availability check, a library
that won't load, a failed InitAPI and a crash on the last run. The setting
is cleared and a notice names the driver.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Installing from an updater file left it out, so Android's media scanner
indexed the firmware. Also only creates it when missing.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
What a draw used depended on whatever was set last, often by another view,
so several draws only got the right font because something before them
happened to reset it. Those now pass the theme's font, which is what they
got in practice.
DrawTextRectSqueeze also measured with the theme's font whatever style it
drew with, so small text could be squeezed more than it needed to be.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each hint quotes the old label as that language showed it. Khmer and Lao
get the English text for now.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
"Force real clock sync (slower, less lag)" no longer described it: it costs
little CPU, and falls back to normal timing by itself when the host is busy.
The config key stays until it's on by default.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A slow display list can hold up emulation for several milliseconds on a slow
device. Lag sync catches up afterwards, but the output keeps pulling in the
meantime, and the fixed 4.4 ms over the output's period wasn't enough. Each
sync now records how far behind the wall clock emulation is, and the most
over the last five seconds is added to the target.
The granular mixer's queue cap no longer makes room for a frame's burst of
audio while pacing; it adds the room for stalls to that for two output reads
instead, up to a frame. The classic resampler drops a lasting excess above
5 ms rather than 10, to settle sooner after the room shrinks.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
--audio-granular picks the granular mixer (the Audio sync mode setting), and
the sink then reports the queue's level and cap, and its underruns.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
While lag sync paces, audio arrives every millisecond or two instead of a
frame's worth at a time, so the resampler's target drops from 40 ms to the
output's period plus 4.4 ms (or 20 ms where the platform doesn't report a
period), and goes back on a fallback to bursting.
The rate adjustment took around ten seconds to drain a startup fill down to
a small target, so a lasting excess (the lowest level over a quarter second
more than 10 ms over the target) is now dropped in one go.
The audio debug overlay shows the target in ms, the lag sync mode and the
dropped excess.
Headless gets --audio-sink=FRAMES, which pulls audio like an output device
with that period and prints how full the buffer ran and how often it ran
dry. docs/lag-sync.md has how to use it, and the Windows measurements: with
a 10 ms period, the buffer averages about 16 ms paced against 35-38 ms
bursting, with a 3 ms period about 9-10 ms, without underruns.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sleep_precise and sleep_approx shared one waitable timer. It has one due
time and releases one waiter, so when two threads slept at once, the second
one's due time replaced the first's and one of them waited forever (and the
other woke at the wrong time). Lag sync sleeping on the emulator thread while
another thread slept was enough.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Lag sync waited with sleep_precise, which on Windows spins the last
millisecond, so its 1 ms waits were nearly all spinning. It now sleeps
with a new sleep_approx (no spin), only once 2 ms or more ahead, and asks
for as much less as the OS has been waking it late. Being late doesn't
add up, since the goal is measured from a fixed base.
Pacing every millisecond only pays with time to spare. Each second, the
share of wall time spent waiting (in lag sync or in the frame throttle)
is measured. Under 10%, it falls back to bursting with the frame
throttle, as without lag sync, and goes back after two seconds over 25%.
GTA VCS on an M1, at --speed values around the host's limit, now runs
as fast as without lag sync or slightly faster. At 1x it costs about 1%
of a core in cycles over bursting, the same as before.
Headless --frame-stats prints lag sync's sleeps, lateness and fallbacks.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The IR frontend dropped a branch or jump in a delay slot (and reported it),
or approximated it with a link to +12 and an exit into the delay slot. Such
a pair now ends the block with the new BranchPair pseudo-op, which the
interpreter runs until it's out of the delay slot, so every core does what
tests/cpu/delayslot/branch recorded. It's an ordinary Interpret, so the
native backends need nothing new, and other branches compile as before.
This removes the delay-slot special cases from the branch compilers and
ResolveNotTakenTarget(), with the eight reports about them. The CPU fuzzer
now runs its d class (branches in delay slots) on every core, and they
agree, cycles included. cpu/delayslot/branch moves to tests_good.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
As tests/cpu/delayslot/branch shows: in a jump's delay slot, a jump or a
taken branch replaces the jump's target, and a link there saves that target.
In a conditional branch's delay slot, a jump is ignored but still links. A
jump skipped by a not-taken likely branch still jumps, with the next
instruction as its delay slot, but doesn't link (Brooktown High relies on
the jump).
The CPU fuzzer gets a d class, which puts branches and jumps in delay slots.
Only the interpreter runs those cases until the IR frontend handles them;
PPSSPP_CPUFUZZ_ALLCORES runs them on every core.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Branches and jumps in the delay slot of another branch, recorded on a PSP.
Neither the interpreter nor the IR frontend matches it yet: a jump in a
jump's delay slot should take its own target, links in a jump's delay slot
go to the outer jump's target, a conditional branch in a jump's slot should
override it in IR, and a jump annulled by a not-taken likely branch still
jumps but doesn't link.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Queue fill and cap (in granules and ms), under/overruns, output rate, read
size and frame time, replacing the "no stats yet" placeholder.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The queue cap was four output callbacks plus a frame of audio. Bluetooth and
other outputs without a fast path call back with large chunks, so that came
to about 100 ms there. Now it's the classic target (which also honors Extra
audio buffering), raised for slow games' per-frame bursts and to keep half
the queue above one callback's read, plus a granule for the overlap.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Since we started booting PSP/GAME/<DISC_ID>/PBOOT.PBP, a modified disc that
has the latest update built in (with its APP_VER raised to match) gets its
executable replaced by the stock update's. With fan translations, that runs
the untranslated executable, which can reject the translated data files.
Only boot the update when its APP_VER is higher than the disc's.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
DriverManagerScreen.cpp included VulkanLoader.h, which pulls in X11 on
Linux, whose Screen typedef clashes with our Screen class.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Google reports PPSSPP crashing at startup on Android 17 internal builds,
in linkernsbypass (part of libadrenotools), whose constructor walks
libdl's dlopen to find the linker's internal __loader_dlopen. It ran on
every launch, custom driver or not.
Switch libadrenotools to the hrydgard fork, where linkernsbypass resolves
those symbols on first use, so only users who picked a custom driver get
there. Also disable custom drivers on Android 17 and its previews until
they've been tested there.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Fixes#21802
The estimate from #21678 made the first-frame readback read back a part of
any buffer drawn in through mode. In the Japanese GTA games, that writes a
64x320 strip of the 32-bit loading screen into VRAM, where the two 16-bit
display buffers later go. Nothing else writes that memory, and when pausing,
the game shows one of them for a few frames before drawing it, which we then
display from memory, pink strip and all. Before, it was all black.
The estimate was for small render targets (Evangelion Jo's menu text), so
limit it to buffers smaller than the screen.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Releasing the button over the tabs also selected the top visible register,
so a double click there opened the change value dialog for it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The 16 pixel left margin of the register rows was excluded from every click,
including on the tab row, which has no margin, so most of "GPR" didn't
respond.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The memory window's single-letter shortcuts (F, B, H, U...) were taken even
when it wasn't focused, opening the search form and focusing its text field
while the game had the keyboard. Only take them when the window is focused,
like the disassembly window does.
Key events don't reach imgui while the debugger is hidden, so a key held while
closing it stayed down. Clear imgui's key state while it's hidden.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Offset 0 only helps with a real PSP running the old Pro Online plugin. Also
say that all players must use the same offset.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
