preserve-emulation/ppsspp
1
0 Fork 0
mirror of https://github.com/hrydgard/ppsspp.git synced 2026-11-13 17:49:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

AGENTS.md: Don't include VulkanLoader.h from UI

Browse Source 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Henrik RydgårdandClaude Opus 5.5 committed 2026-11-10 16:15:36 +01:00
1 parent 879933abce
commit f53b614be4
1 file changed
+6
Download Patch File Download Diff File Expand all files Collapse all files
AGENTS.md
+6
View File
@@ -221,6 +221,12 @@ UWP/PPSSPP_UWPMain.cpp
android/jni/app-android.cpp
libretro/libretro.cpp
**Never include `Common/GPU/Vulkan/VulkanLoader.h` directly from `UI/`.** On Linux the Vulkan headers
bring in X11, whose definitions (`Screen` among them) break `Common/UI/Screen.h`. Windows and Android
builds don't show it, so it only fails on CI. The same goes for including UI headers (`View.h`, `Screen.h`) in a
file that has the Vulkan ones. Put what UI code needs in a header without Vulkan includes, like
`Common/GPU/Vulkan/VulkanDriverVars.h`, or pass the value in from the UI side.
## Reverse-engineering the firmware
When a question about hardware behaviour can't be settled from the docs or from JPCSP - what a field in