From f53b614be45573126f55b2be406f58aec1c6cfb8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Henrik=20Rydg=C3=A5rd?= Date: Tue, 10 Nov 2026 16:15:36 +0100 Subject: [PATCH] AGENTS.md: Don't include VulkanLoader.h from UI Co-Authored-By: Claude Opus 5.5 --- AGENTS.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/AGENTS.md b/AGENTS.md index 6c0d1e600b..bf5fbe3b6a 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -221,6 +221,12 @@ UWP/PPSSPP_UWPMain.cpp android/jni/app-android.cpp libretro/libretro.cpp +**Never include `Common/GPU/Vulkan/VulkanLoader.h` directly from `UI/`.** On Linux the Vulkan headers +bring in X11, whose definitions (`Screen` among them) break `Common/UI/Screen.h`. Windows and Android +builds don't show it, so it only fails on CI. The same goes for including UI headers (`View.h`, `Screen.h`) in a +file that has the Vulkan ones. Put what UI code needs in a header without Vulkan includes, like +`Common/GPU/Vulkan/VulkanDriverVars.h`, or pass the value in from the UI side. + ## Reverse-engineering the firmware When a question about hardware behaviour can't be settled from the docs or from JPCSP - what a field in