Any tabbed screen can now add tabs described by a SettingsPage with
AddSettingsTab, and gets the search tab that shows matching settings with
arrows to jump to them. The game settings screen is the first to use it.
Screens without settings tabs keep the old filter for now.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Instead of hiding the non-matching views in every tab and disabling the tabs
without matches, the search tab now builds each page and shows the matching
settings right there, where they can be changed, grouped under their tab and
section. Matching a section header shows the whole section, and matching a
hint shows its setting. Searches match both the translated and the English
text.
Each result has an arrow that switches to the setting's tab, scrolls it to the
middle and highlights it.
The other tabbed screens with search (Developer Tools) keep the old filter for
now.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Graphics, Controls, Networking, Tools, System and VR now fill in a
SettingsPage like Audio does, and each tab is listed in a table with its
builder. The tabs look and behave the same as before. Views that the item
types can't describe (the MAC address chooser, the ad hoc server row, text
inputs, the language and theme pickers) are custom items, so they still have
searchable text.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Adds SettingsPage, a list of setting items (header, bool, int/string
choice, int slider, info, hint, or a custom view) that keeps its texts as
translation keys. CreateSettingViews() turns a page into the same widgets as
before. Since a page can be built without creating any views, search can
later work from it directly, in English as well as translated.
Slider defaults come from the config's own defaults unless given. The Audio
tab is the first one converted, and looks the same as before.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The Networking copy showed a warning for the default name but didn't fill
in an empty infrastructure username; the System one did the reverse, and
didn't refresh the views. Both now use one helper that does both.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The percentages were converted back to frame rates whenever any dialog
closed with OK. That overwrote the values Restore Defaults had just set,
and the integer rounding drifted unchanged values down (100 fps became 99
on any unrelated change). Restoring defaults also had the old reporting
choice written back on exit; it's now re-read too.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Building a settings tab should only create views, so that the tabs can
later be described as data and searched without being shown.
- Don't reset the MSAA level when the device has none. The GPU already
falls back to no MSAA (UpdateMSAALevel), and the reset overwrote the
setting, including per-game ones.
- Read the reporting state in the constructor. It was only read when the
System tab was built, but always written back on exit, so leaving
settings without opening System turned reporting off.
- Move the Windows memstick location probe (which writes a temp file next
to the exe) out of the System tab, and keep the checkboxes' enabled
state in members instead of poking at the views.
- Show the Android/UWP memstick path through a callback instead of a
copy made at build time, and drop a USB path computation whose result
was never used.
- Make the reliable-UDP checkbox follow the UDP setting directly instead
of recreating all views when it changes.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Config.h is edited about 100 times a year and each edit recompiled 198
files; now 172. SmallDataConvert.h pulls in arm_neon.h and was included by
headers that don't use it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add various data fields and logic to handle:
- automatic adhoc data mode handling
- future UI expension on server list
- future support for automatically downloaded/user provided server list
It's really not a good idea to change it.
In case someone does have a use case for it, we keep the option anyway,
but in developer tools, with a loud warning next to it.
Should help #18929 by reducing the number of people causing themselves trouble
with the option.