Commit Graph
41426 Commits
Author SHA1 Message Date
Henrik Rydgård b010f1bd48 Make the dispatcher less confusing 2024-12-10 01:27:25 +01:00
Henrik Rydgård fa40ee7a07 Merge pull request #19711 from hrydgard/extracted-commits
Extracted fixes and cleanups from #19709
2024-12-10 01:27:45 +01:00
Henrik Rydgård b2a8b4168b Core: Minor changes to stepping (and some log changes) 2024-12-10 01:06:19 +01:00
Henrik Rydgård c842e3f137 Fix discrepancy between stepping and running across frame endings. Add some more menu options in the ImDebugger 2024-12-10 01:06:04 +01:00
Henrik Rydgård 43af3128e0 Fix drag/drop crash 2024-12-10 01:03:05 +01:00
Henrik Rydgård 10445c97d8 Warning fix 2024-12-10 01:02:49 +01:00
Henrik Rydgård 132fabff07 ImDebugger: Add way to cancel pending step 2024-12-10 01:01:47 +01:00
Henrik Rydgård de3617529f const, rename a function 2024-12-10 01:01:31 +01:00
Henrik Rydgård a94431f4fa Remove an unnecessary wrapper function 2024-12-10 01:01:05 +01:00
Henrik Rydgård 55217ddc11 Minor UI tweaks 2024-12-10 01:00:14 +01:00
Henrik Rydgård fe62ac793a ImDebugger scheduler: Show userdata field 2024-12-10 01:00:14 +01:00
Henrik Rydgård a5a3401bae Merge pull request #19710 from Kethen/macos_amd_workaround
Work around metal buffer bug on MacOS + AMD GPU
2024-12-09 14:39:34 +01:00
Katharine Chui 49553bcf8d Simplify MacOS AMD GPU workaround
Based on https://github.com/KhronosGroup/MoltenVK/issues/960,
expand MacOS AMD GPU workaround to all dGPU and instead of
changing usage, just append VK_MEMORY_PROPERTY_HOST_COHERENT_BIT
2024-12-09 14:22:56 +01:00
Katharine Chui 286580a6a0 Switch to VMA_MEMORY_USAGE_CPU_ONLY on MacOS AMD
The ideal allocation would be VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT
like in 1.12.3, but vma picked an index that's actually not mappable

VMA_MEMORY_USAGE_GPU_TO_CPU selects VK_MEMORY_PROPERTY_HOST_CACHED_BIT,
which seems to hurt performance

VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT + VK_MEMORY_PROPERTY_HOST_COHERENT_BIT
selection with VMA_MEMORY_USAGE_CPU_ONLY would suffice for the
workaround, and get better performance
2024-12-09 12:32:31 +01:00
Katharine Chui 93009a3178 Work around metal buffer bug on MacOS + AMD GPU
With VMA_MEMORY_USAGE_CPU_TO_GPU buffers, metal buffer appears 0
filled in metal trace during vkCmdCopyBufferToImage triggered
MTLBlitCommandEncoder instance method.

Allocate VMA_MEMORY_USAGE_GPU_TO_CPU instead on MacOS + AMD GPU
2024-12-08 22:13:33 +01:00
Henrik Rydgård d21de81826 Merge pull request #19707 from hrydgard/core-improvements
Core improvements: Run-from-breakpoint fix, add two new step types
2024-12-08 16:15:31 +01:00
Henrik Rydgård e0a1d658ea ImDebugger thread window: Visualize the wait ID when possible 2024-12-08 15:41:13 +01:00
Henrik Rydgård 93baf22369 ImDebugger: Add frame-stepping and a "skim" button (single-steps while held down) 2024-12-08 15:12:13 +01:00
Henrik Rydgård f74e7fb6f5 Fix running when pc is at breakpoint. Fix issue when stepping through Ge-enqueuing functions. 2024-12-08 15:00:11 +01:00
Henrik Rydgård 50fadd1a4e Merge pull request #19706 from hrydgard/core-cleanup
Core.cpp cleanup
2024-12-08 12:38:06 +01:00
Henrik Rydgård 080798b5dd Move out two more functions from Core.cpp. Clean up Windows includes 2024-12-08 12:12:02 +01:00
Henrik Rydgård 83af54950f Move more core-related stuff into Core.cpp/h 2024-12-08 11:54:58 +01:00
Henrik Rydgård df91f699fc Move the core loop to Core.cpp 2024-12-08 11:47:12 +01:00
Henrik Rydgård b3d08977d5 Delete unused code 2024-12-08 11:25:00 +01:00
Henrik Rydgård 59ddc7f568 Add wait id column 2024-12-08 11:13:23 +01:00
Henrik Rydgård 739a32324d Thread view: Show wait type 2024-12-08 11:13:21 +01:00
Henrik Rydgård b3227e527b Merge pull request #19705 from hrydgard/debugger-core-timing
ImDebugger: Add a window to inspect upcoming CoreTiming events
2024-12-07 16:49:13 +01:00
Henrik Rydgård b3346df646 ImDebugger: Add a window to inspect upcoming CoreTiming events 2024-12-07 16:28:27 +01:00
Henrik Rydgård 3ca3a797c9 Merge pull request #19703 from hrydgard/ge-debugger-disasm
Im Ge Debugger: Add basic disassembly view
2024-12-06 13:47:00 +01:00
Henrik Rydgård 86cdd47fa2 Im Ge Debugger: Add basic disassembly view 2024-12-06 12:52:31 +01:00
Henrik Rydgård 246e2695b7 Merge pull request #19702 from hrydgard/ge-debugger-vertices
ImDebugger GE: Add vertex data viewer
2024-12-06 11:00:03 +01:00
Henrik Rydgård 5f83e48280 Move the ge debugger window back out from GPUCommon 2024-12-06 09:50:00 +01:00
Henrik Rydgård 2c8e78408b Add basic vertex data viewer (with the same flaws as the old one) 2024-12-06 09:29:12 +01:00
Henrik Rydgård dab40ab602 Merge pull request #19700 from hrydgard/fix-break-on-load
Fix regression in break-on-load functionality
2024-12-06 00:44:46 +01:00
Henrik Rydgård 6adf8cabae Fix regression in break-on-load functionality 2024-12-06 00:40:21 +01:00
Henrik Rydgård 9297d2fc49 Merge pull request #19699 from hrydgard/more-ge-debugger
More Im GE debugger: State window, extract more code from the Windows GE debugger
2024-12-05 18:54:13 +01:00
Henrik Rydgård 51ae6ce898 Small simplification 2024-12-05 10:55:19 +01:00
Henrik Rydgård 95b7db99ed Extract the vertex formatting code from the Windows GE Debugger 2024-12-05 10:47:49 +01:00
Henrik Rydgård 47c98a9135 Add barebones GE state display window 2024-12-05 10:25:40 +01:00
Henrik Rydgård 6d33408da6 Move the state tab definitions to GPU/Debugger 2024-12-05 10:13:25 +01:00
Henrik Rydgård 21997784bf Extract FormatStateRow() from the Win32 GE debugger to GPU/Debugger/Registers 2024-12-05 10:07:29 +01:00
Henrik Rydgård 0c524b712e Merge pull request #19693 from hrydgard/debugger-refactor
More GE debugger refactoring, initial work on the new debugger
2024-12-05 09:07:07 +01:00
Henrik Rydgård 37f61bff5d Remove unused code. Activate split syscalls (for Ge stepping) when the Ge debugger is "active" 2024-12-05 00:52:21 +01:00
Henrik Rydgård 474e7acf54 Hook up the new (bare-bones) ImGui debug window to GPU stepping, fix stepping. 2024-12-05 00:51:59 +01:00
Henrik Rydgård 11819e87cf PauseAction readbacks now work again 2024-12-05 00:36:49 +01:00
Henrik Rydgård f8af4906f5 Ge debugger: Better solution for draw notifications 2024-12-05 00:36:49 +01:00
Henrik Rydgård 9ed8d8871e Ge stepping without wait: Tex/Prim stepping works. Draw/Single have issues. 2024-12-05 00:36:48 +01:00
Henrik Rydgård ea43e07cce Move some stuff around, rename some stuff 2024-12-05 00:36:48 +01:00
Henrik Rydgård 45dc5f640c Merge pull request #19697 from hrydgard/split-syscalls
Add "Split syscall" mechanism
2024-12-05 00:34:55 +01:00
Henrik Rydgård c25e6b3933 Add "Split syscall" mechanism 2024-12-05 00:05:39 +01:00