preserve-emulation/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2026-07-11 01:24:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

State: Fix Use After Move In LoadAsFromCore

Browse Source 
This use-after-move error inhibits the use of savestates during the Dolphin TAS Movie creation process.
This commit is contained in:
Amon Neander
2026-06-19 07:40:59 -07:00
parent 43210d1430
commit 5797b943b2
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/Core/Core/State.cpp
+4 -4
View File
@@ -15,6 +15,7 @@
#include <fmt/chrono.h>
#include <fmt/format.h>
#include <fmt/std.h>
#include <lz4.h>
#include <lzo/lzo1x.h>
@@ -463,7 +464,7 @@ static void CompressAndDumpState(Core::System& system, const CompressAndDumpStat
else
{
const std::filesystem::path temp_path(filename);
Core::DisplayMessage(fmt::format("Saved State to {}", temp_path.filename().string()), 2000);
Core::DisplayMessage(fmt::format("Saved State to {}", temp_path.filename()), 2000);
}
}
@@ -840,9 +841,8 @@ static void LoadAsFromCore(Core::System& system, std::string filename)
{
if (loaded_successfully)
{
std::filesystem::path temp_filename(std::move(filename));
Core::DisplayMessage(fmt::format("Loaded State from {}", temp_filename.filename().string()),
2000);
const std::filesystem::path temp_filename(filename);
Core::DisplayMessage(fmt::format("Loaded State from {}", temp_filename.filename()), 2000);
if (File::Exists(filename + ".dtm"))
{
movie.LoadInput(filename + ".dtm");