From 5797b943b250bf3ec0dce258bb210ca9b1d57c28 Mon Sep 17 00:00:00 2001 From: Amon Neander <138429719+MaverickAmon02@users.noreply.github.com> Date: Fri, 19 Jun 2026 07:40:59 -0700 Subject: [PATCH] State: Fix Use After Move In LoadAsFromCore This use-after-move error inhibits the use of savestates during the Dolphin TAS Movie creation process. --- Source/Core/Core/State.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Source/Core/Core/State.cpp b/Source/Core/Core/State.cpp index 5724240ffd..ddd52f1d56 100644 --- a/Source/Core/Core/State.cpp +++ b/Source/Core/Core/State.cpp @@ -15,6 +15,7 @@ #include #include +#include #include #include @@ -463,7 +464,7 @@ static void CompressAndDumpState(Core::System& system, const CompressAndDumpStat else { const std::filesystem::path temp_path(filename); - Core::DisplayMessage(fmt::format("Saved State to {}", temp_path.filename().string()), 2000); + Core::DisplayMessage(fmt::format("Saved State to {}", temp_path.filename()), 2000); } } @@ -840,9 +841,8 @@ static void LoadAsFromCore(Core::System& system, std::string filename) { if (loaded_successfully) { - std::filesystem::path temp_filename(std::move(filename)); - Core::DisplayMessage(fmt::format("Loaded State from {}", temp_filename.filename().string()), - 2000); + const std::filesystem::path temp_filename(filename); + Core::DisplayMessage(fmt::format("Loaded State from {}", temp_filename.filename()), 2000); if (File::Exists(filename + ".dtm")) { movie.LoadInput(filename + ".dtm");