mirror of
https://github.com/xemu-project/xemu.git
synced 2026-11-11 08:39:00 +01:00
cd7fdfe59f4f965665dcd9868fe3764f5256d6aa
When dataplane is stopping, the s->vdev->binding->set_host_notifier(..., false) call can invoke the virtqueue handler if an ioeventfd notification is pending. This causes hw/virtio-blk.c to invoke virtio_blk_data_plane_start() before virtio_blk_data_plane_stop() returns! The result is that we try to restart dataplane while trying to stop it and the following assertion is raised: msix_set_mask_notifier: Assertion `!dev->msix_mask_notifier' failed. Although the code was intended to prevent this scenario, the s->started boolean isn't enough. Add s->stopping so that we can postpone clearing s->started until we've completely stopped dataplane. This way, virtqueue handler calls during virtio_blk_data_plane_stop() are ignored. When dataplane is legitimately started again later we already self-kick ourselves to resume processing. Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
…
…
…
…
…
…
…
Read the documentation in qemu-doc.html or on http://wiki.qemu.org - QEMU team
Description
Original Xbox Emulator for Windows, macOS, and Linux (Active Development)
Readme
GPL-2.0
713 MiB
0 Stars
1 Watchers
0 Forks
Languages
C
82.3%
C++
6.9%
Python
3.5%
Dylan
2.7%
Shell
1.5%
Other
2.9%