Stefan Hajnoczi 745a9bb9cd dataplane: fix virtio_blk_data_plane_create() op blocker error path
Commit 3718d8ab65 ("block: Replace in_use
with operation blocker") broke the error path because it consumed
local_err instead of propagating it.

The caller has no way to know that the function failed.  This caused
virtio-blk to start "successfully" even though there was a fatal
dataplane error.

Steps to reproduce:

  $ qemu-system-x86_64 -enable-kvm -object iothread,id=iothread0 \
                       -drive if=none,id=drive0,file=a.img \
  (qemu) drive_mirror drive0 /tmp/foo.img
  (qemu) device_add virtio-blk-pci,iothread=iothread0,drive=drive0

Expected result:

  Since the mirror block job is using drive0 it is not possible to start
  virtio-blk data-plane.

  device_add fails and the PCI adapter is not added.

Actual result:

  device_add completes and the PCI adapter is added.

Cc: Fam Zheng <famz@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-09-11 16:21:46 +02:00
2014-08-20 21:15:56 +02:00
2013-04-18 13:50:53 +02:00
2014-06-23 11:00:12 -04:00
2014-08-26 13:52:15 +01:00
2014-09-02 22:38:16 +04:00
2014-08-18 14:39:10 -04:00
2014-08-24 13:16:32 +04:00
…
2014-06-16 13:24:35 +02:00
2013-09-05 09:40:31 -05:00
2014-06-09 15:43:40 +02:00
2014-08-29 10:46:58 +01:00
2014-08-29 10:46:58 +01:00
2014-08-29 10:46:58 +01:00
2014-06-23 11:12:28 -04:00
2014-08-29 10:46:58 +01:00
…
…
2013-10-11 09:34:56 -07:00
…
2013-07-23 02:41:31 +02:00
2014-09-02 22:38:16 +04:00
2014-06-19 18:44:21 +03:00
2014-06-19 16:41:54 +03:00
2013-08-12 09:15:12 -05:00
2013-09-03 12:25:55 +02:00
2014-06-23 19:09:50 +02:00
2014-08-18 14:39:10 -04:00
2014-08-29 10:48:45 +01:00
2014-09-02 22:38:16 +04:00
2014-03-13 14:34:16 +00:00
2014-05-24 00:07:29 +04:00
2014-08-06 17:53:07 +02:00
2013-10-11 09:34:56 -07:00
…
2014-02-17 11:57:23 -05:00
2014-06-05 16:10:33 +02:00
2014-08-01 18:30:08 +01:00
2013-10-11 09:34:56 -07:00
2014-09-04 16:14:47 +02:00
2014-05-07 16:16:43 +00:00
2014-07-07 10:37:40 +00:00

Read the documentation in qemu-doc.html or on http://wiki.qemu-project.org

- QEMU team
S
Description
Original Xbox Emulator for Windows, macOS, and Linux (Active Development)
Readme GPL-2.0
718 MiB
0 Stars 1 Watchers 0 Forks
Languages
C 82.3%
C++ 6.9%
Python 3.5%
Dylan 2.7%
Shell 1.5%
Other 2.9%