Eric Auger
1a10285665
hw/core/sysbus: Introduce sysbus_mmio_map_name() helper
...
Some sysbus devices have conditional mmio regions. This
happens for instance with the hw/acpi/ged device. In that case
it becomes difficult to predict which index a specific MMIO
region corresponds to when one needs to mmio map the region.
Introduce a new helper that takes the name of the region instead
of its index. If the region is not found this returns -1.
Otherwise it maps the corresponding index and returns this latter.
Signed-off-by: Eric Auger <eric.auger@redhat.com >
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com >
Reviewed-by: Igor Mammedov <imammedo@redhat.com >
Message-Id: <20250714080639.2525563-31-eric.auger@redhat.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:40 -04:00
Eric Auger
745315784d
hw/acpi/ged: Support migration of AcpiPciHpState
...
Add a subsection to migrate the AcpiPciHpState state.
Signed-off-by: Eric Auger <eric.auger@redhat.com >
Reviewed-by: Igor Mammedov <imammedo@redhat.com >
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com >
Reviewed-by: Prasad Pandit <pjp@fedoraproject.org >
Message-Id: <20250714080639.2525563-30-eric.auger@redhat.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:40 -04:00
Eric Auger
1816a337a1
hw/acpi/ged: Prepare the device to react to PCI hotplug events
...
QEMU will notify the OS about PCI hotplug/hotunplug events through
GED interrupts. Let the GED device handle a new PCI hotplug event.
On its occurrence it calls the \\_SB.PCI0.PCNT method with the BLCK
mutex held.
The GED device uses a dedicated MMIO region that will be mapped
by the machine code.
At this point the GED still does not support PCI device hotplug in
its TYPE_HOTPLUG_HANDLER implementation. This will come in a
subsequent patch.
Signed-off-by: Eric Auger <eric.auger@redhat.com >
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com >
Reviewed-by: Igor Mammedov <imammedo@redhat.com >
Message-Id: <20250714080639.2525563-29-eric.auger@redhat.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:40 -04:00
Eric Auger
b8c7ebbb70
hw/acpi/pcihp: Remove root arg in acpi_pcihp_init
...
Let pass the root bus to ich9 and piix4 through a property link
instead of through an argument passed to acpi_pcihp_init().
Also make sure the root bus is set at the entry of acpi_pcihp_init().
The rationale of that change is to be consistent with the forecoming ARM
implementation where the machine passes the root bus (steming from GPEX)
to the GED device through a link property.
Signed-off-by: Eric Auger <eric.auger@redhat.com >
Suggested-by: Igor Mammedov <imammedo@redhat.com >
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com >
Reviewed-by: Igor Mammedov <imammedo@redhat.com >
Message-Id: <20250714080639.2525563-28-eric.auger@redhat.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:40 -04:00
Eric Auger
8c58dc0531
hw/acpi/ged: Call pcihp plug callbacks in hotplug handler implementation
...
Add PCI device related code in the TYPE_HOTPLUG_HANDLER
implementation.
For a PCI device hotplug/hotunplug event, the code routes to
acpi_pcihp_device callbacks (pre_plug_cb, plug_cb, unplug_request_cb,
unplug_cb).
Signed-off-by: Eric Auger <eric.auger@redhat.com >
Reviewed-by: Igor Mammedov <imammedo@redhat.com >
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com >
Message-Id: <20250714080639.2525563-27-eric.auger@redhat.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:40 -04:00
Eric Auger
1913b8e686
hw/arm/virt: Pass the bus on the ged creation
...
The bus will be needed on ged realize for acpi pci hp setup.
Signed-off-by: Eric Auger <eric.auger@redhat.com >
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com >
Reviewed-by: Igor Mammedov <imammedo@redhat.com >
Message-Id: <20250714080639.2525563-26-eric.auger@redhat.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:40 -04:00
Eric Auger
7b3e231f09
hw/acpi/ged: Add a bus link property
...
This property will be set by the machine code on the object
creation. It will be used by acpi pcihp hotplug code.
Signed-off-by: Eric Auger <eric.auger@redhat.com >
Reviewed-by: Igor Mammedov <imammedo@redhat.com >
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com >
Message-Id: <20250714080639.2525563-25-eric.auger@redhat.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:40 -04:00
Eric Auger
1c2efc8ae0
hw/arm/virt-acpi-build: Modify the DSDT ACPI table to enable ACPI PCI hotplug
...
Modify the DSDT ACPI table to enable ACPI PCI hotplug.
Signed-off-by: Eric Auger <eric.auger@redhat.com >
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com >
Reviewed-by: Igor Mammedov <imammedo@redhat.com >
Message-Id: <20250714080639.2525563-24-eric.auger@redhat.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:40 -04:00
Eric Auger
4dfb141827
tests/qtest/bios-tables-test: Update ARM DSDT reference blobs
...
Changes relate to the introduction of pieces related to
acpi-index static support along with root ports with no hotplug.
+
+ Scope (\_SB.PCI0)
+ {
+ Method (EDSM, 5, Serialized)
+ {
+ If ((Arg2 == Zero))
+ {
+ Local0 = Buffer (One)
+ {
+ 0x00 // .
+ }
+ If ((Arg0 != ToUUID ("e5c937d0-3553-4d7a-9117-ea4d19c3434d") /* Device Labeling Interface */))
+ {
+ Return (Local0)
+ }
+
+ If ((Arg1 < 0x02))
+ {
+ Return (Local0)
+ }
+
+ Local0 [Zero] = 0x81
+ Return (Local0)
+ }
+
+ If ((Arg2 == 0x07))
+ {
+ Local0 = Package (0x02)
+ {
+ Zero,
+ ""
+ }
+ Local1 = DerefOf (Arg4 [Zero])
+ Local0 [Zero] = Local1
+ Return (Local0)
+ }
+ }
+
+ Device (S00)
+ {
+ Name (_ADR, Zero) // _ADR: Address
+ }
+
+ Device (S08)
+ {
+ Name (_ADR, 0x00010000) // _ADR: Address
+ }
+
+ Device (S10)
+ {
+ Name (_ADR, 0x00020000) // _ADR: Address
+ }
+ }
}
Signed-off-by: Eric Auger <eric.auger@redhat.com >
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com >
Reviewed-by: Igor Mammedov <imammedo@redhat.com >
Message-Id: <20250714080639.2525563-23-eric.auger@redhat.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:40 -04:00
Eric Auger
ff692ee7bc
hw/arm/virt-acpi-build: Let non hotplug ports support static acpi-index
...
hw/arm/virt-acpi-build: Let non hotplug ports support static acpi-index
Add the requested ACPI bits requested to support static acpi-index
for non hotplug ports.
Signed-off-by: Eric Auger <eric.auger@redhat.com >
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com >
Reviewed-by: Igor Mammedov <imammedo@redhat.com >
Message-Id: <20250714080639.2525563-22-eric.auger@redhat.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:40 -04:00
Gustavo Romero
1983d55299
tests/qtest/bios-tables-test: Prepare for changes in the arm virt DSDT table
...
This commit adds DSDT blobs to the whilelist in the prospect to
allow changes in the arm virt DSDT method.
Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org >
Signed-off-by: Eric Auger <eric.auger@redhat.com >
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com >
Reviewed-by: Igor Mammedov <imammedo@redhat.com >
Message-Id: <20250714080639.2525563-21-eric.auger@redhat.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:40 -04:00
Eric Auger
c34115091f
qtest/bios-tables-test: Generate DSDT.viot
...
Use a specific DSDT.viot reference blob instead of relying on
the default DSDT blob. The content is unchanged.
Signed-off-by: Eric Auger <eric.auger@redhat.com >
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com >
Reviewed-by: Igor Mammedov <imammedo@redhat.com >
Message-Id: <20250714080639.2525563-20-eric.auger@redhat.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:40 -04:00
Eric Auger
070c0892d5
qtest/bios-tables-test: Add a variant to the aarch64 viot test
...
Signed-off-by: Eric Auger <eric.auger@redhat.com >
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com >
Reviewed-by: Igor Mammedov <imammedo@redhat.com >
Message-Id: <20250714080639.2525563-19-eric.auger@redhat.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:40 -04:00
Eric Auger
c82a9d7407
qtest/bios-tables-test: Prepare for fixing the aarch64 viot test
...
The test misses a variant and this puts the mess on subsequent
rebuild-expected-aml.sh where a first DSDT reference blob is
overriden by another one.
Signed-off-by: Eric Auger <eric.auger@redhat.com >
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com >
Reviewed-by: Igor Mammedov <imammedo@redhat.com >
Message-Id: <20250714080639.2525563-18-eric.auger@redhat.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:40 -04:00
Eric Auger
bc8f29df27
hw/i386/acpi-build: Move aml_pci_edsm to a generic place
...
Move aml_pci_edsm to pci-bridge.c since we want to reuse that for
ARM and acpi-index support. Also rename it into build_pci_bridge_edsm.
Signed-off-by: Eric Auger <eric.auger@redhat.com >
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com >
Reviewed-by: Igor Mammedov <imammedo@redhat.com >
Message-Id: <20250714080639.2525563-17-eric.auger@redhat.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:40 -04:00
Eric Auger
b9dc4e04c8
hw/i386/acpi-build: Use AcpiPciHpState::root in acpi_set_pci_info
...
pcihp acpi_set_pci_info() generic code currently uses
acpi_get_i386_pci_host() to retrieve the pci host bridge.
To make it work also on ARM we get rid of that call and
directly use AcpiPciHpState::root.
Signed-off-by: Eric Auger <eric.auger@redhat.com >
Suggested-by: Igor Mammedov <imammedo@redhat.com >
Reviewed-by: Igor Mammedov <imammedo@redhat.com >
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com >
Message-Id: <20250714080639.2525563-16-eric.auger@redhat.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:40 -04:00
Eric Auger
e87ab64e8f
hw/i386/acpi-build: Move build_append_pci_bus_devices/pcihp_slots to pcihp
...
We intend to reuse build_append_pci_bus_devices and build_append_pcihp_slots
on ARM. So let's move them to hw/acpi/pcihp.c as well as all static
helpers they use.
No functional change intended.
Signed-off-by: Eric Auger <eric.auger@redhat.com >
Reviewed-by: Gustavo Romero <gustavo.romero@linaro.org >
Reviewed-by: Igor Mammedov <imammedo@redhat.com >
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com >
Message-Id: <20250714080639.2525563-15-eric.auger@redhat.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:40 -04:00
Eric Auger
d962f199c7
hw/i386/acpi-build: Move build_append_notification_callback to pcihp
...
We plan to reuse build_append_notification_callback() on ARM
so let's move it to pcihp.c.
No functional change intended.
Signed-off-by: Eric Auger <eric.auger@redhat.com >
Reviewed-by: Gustavo Romero <gustavo.romero@linaro.org >
Reviewed-by: Igor Mammedov <imammedo@redhat.com >
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com >
Message-Id: <20250714080639.2525563-14-eric.auger@redhat.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:40 -04:00
Eric Auger
b412e0557c
hw/acpi/pcihp: Add an AmlRegionSpace arg to build_acpi_pci_hotplug
...
On ARM we will put the operation regions in AML_SYSTEM_MEMORY.
So let's allow this configuration.
Signed-off-by: Eric Auger <eric.auger@redhat.com >
Reviewed-by: Gustavo Romero <gustavo.romero@linaro.org >
Reviewed-by: Igor Mammedov <imammedo@redhat.com >
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com >
Message-Id: <20250714080639.2525563-13-eric.auger@redhat.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:40 -04:00
Eric Auger
c5dee204b0
hw/i386/acpi-build: Introduce build_append_pcihp_resources() helper
...
Extract the code that reserves resources for ACPI PCI hotplug
into a new helper named build_append_pcihp_resources() and
move it to pcihp.c. We will reuse it on ARM.
Signed-off-by: Eric Auger <eric.auger@redhat.com >
Reviewed-by: Gustavo Romero <gustavo.romero@linaro.org >
Reviewed-by: Igor Mammedov <imammedo@redhat.com >
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com >
Message-Id: <20250714080639.2525563-12-eric.auger@redhat.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:40 -04:00
Michael S. Tsirkin
f47d6e6a8f
tests/qtest/bios-tables-test: Update DSDT blobs after GPEX _OSC change
...
Update the reference DSDT blobs after GPEX _OSC change. The _OSC change
affects the aarch64 'virt' and the x86 'microvm' machines.
DSDT diff is the same for all the machines/tests:
* Original Table Header:
* Signature "DSDT"
- * Length 0x00001A4F (6735)
+ * Length 0x00001A35 (6709)
* Revision 0x02
- * Checksum 0xBF
+ * Checksum 0xDD
* OEM ID "BOCHS "
* OEM Table ID "BXPC "
* OEM Revision 0x00000001 (1)
@@ -1849,27 +1849,26 @@ DefinitionBlock ("", "DSDT", 2, "BOCHS ", "BXPC ", 0x00000001)
{
CreateDWordField (Arg3, 0x04, CDW2)
CreateDWordField (Arg3, 0x08, CDW3)
- SUPP = CDW2 /* \_SB_.PCI0._OSC.CDW2 */
- CTRL = CDW3 /* \_SB_.PCI0._OSC.CDW3 */
- CTRL &= 0x1F
+ Local0 = CDW3 /* \_SB_.PCI0._OSC.CDW3 */
+ Local0 &= 0x1F
If ((Arg1 != One))
{
CDW1 |= 0x08
}
- If ((CDW3 != CTRL))
+ If ((CDW3 != Local0))
{
CDW1 |= 0x10
}
- CDW3 = CTRL /* \_SB_.PCI0.CTRL */
- Return (Arg3)
+ CDW3 = Local0
}
Else
{
CDW1 |= 0x04
- Return (Arg3)
}
+
+ Return (Arg3)
}
Method (_DSM, 4, NotSerialized) // _DSM: Device-Specific Method
Signed-off-by: Eric Auger <eric.auger@redhat.com >
Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org >
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com >
Reviewed-by: Igor Mammedov <imammedo@redhat.com >
Message-Id: <20250714080639.2525563-11-eric.auger@redhat.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:40 -04:00
Eric Auger
af151d50ea
hw/pci-host/gpex-acpi: Use build_pci_host_bridge_osc_method
...
gpex build_host_bridge_osc() and x86 originated
build_pci_host_bridge_osc_method() are mostly identical.
In GPEX, SUPP is set to CDW2 but is not further used. CTRL
is same as Local0.
So let gpex code reuse build_pci_host_bridge_osc_method()
and remove build_host_bridge_osc().
Also add an imply ACPI_PCI clause along with
PCI_EXPRESS_GENERIC_BRIDGE to compile hw/acpi/pci.c
when its dependency is resolved (ie. CONFIG_ACPI_PCI).
This is requested to link qemu-system-mips64el.
The disassembled DSDT difference is given below:
* Original Table Header:
* Signature "DSDT"
- * Length 0x00001A4F (6735)
+ * Length 0x00001A35 (6709)
* Revision 0x02
- * Checksum 0xBF
+ * Checksum 0xDD
* OEM ID "BOCHS "
* OEM Table ID "BXPC "
* OEM Revision 0x00000001 (1)
@@ -1849,27 +1849,26 @@ DefinitionBlock ("", "DSDT", 2, "BOCHS ", "BXPC ", 0x00000001)
{
CreateDWordField (Arg3, 0x04, CDW2)
CreateDWordField (Arg3, 0x08, CDW3)
- SUPP = CDW2 /* \_SB_.PCI0._OSC.CDW2 */
- CTRL = CDW3 /* \_SB_.PCI0._OSC.CDW3 */
- CTRL &= 0x1F
+ Local0 = CDW3 /* \_SB_.PCI0._OSC.CDW3 */
+ Local0 &= 0x1F
If ((Arg1 != One))
{
CDW1 |= 0x08
}
- If ((CDW3 != CTRL))
+ If ((CDW3 != Local0))
{
CDW1 |= 0x10
}
- CDW3 = CTRL /* \_SB_.PCI0.CTRL */
- Return (Arg3)
+ CDW3 = Local0
}
Else
{
CDW1 |= 0x04
- Return (Arg3)
}
+
+ Return (Arg3)
}
Method (_DSM, 4, NotSerialized) // _DSM: Device-Specific Method
Signed-off-by: Eric Auger <eric.auger@redhat.com >
Reviewed-by: Igor Mammedov <imammedo@redhat.com >
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com >
Message-Id: <20250714080639.2525563-10-eric.auger@redhat.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:40 -04:00
Eric Auger
dc925e4b1d
hw/i386/acpi-build: Turn build_q35_osc_method into a generic method
...
GPEX acpi_dsdt_add_pci_osc() does basically the same as
build_q35_osc_method().
Rename build_q35_osc_method() into build_pci_host_bridge_osc_method()
and move it into hw/acpi/pci.c. In a subsequent patch we will
use this later in place of acpi_dsdt_add_pci_osc().
Signed-off-by: Eric Auger <eric.auger@redhat.com >
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com >
Reviewed-by: Igor Mammedov <imammedo@redhat.com >
Message-Id: <20250714080639.2525563-9-eric.auger@redhat.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:40 -04:00
Eric Auger
1136309df5
hw/pci-host/gpex-acpi: Use GED acpi pcihp property
...
Retrieve the acpi pcihp property value from the ged. In case this latter
is not set, PCI native hotplug is used on pci0. For expander bridges we
keep pci native hotplug, as done on x86 q35.
Signed-off-by: Eric Auger <eric.auger@redhat.com >
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com >
Message-Id: <20250714080639.2525563-8-eric.auger@redhat.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:40 -04:00
Eric Auger
c4ad751356
hw/acpi/ged: Add a acpi-pci-hotplug-with-bridge-support property
...
A new boolean property is introduced. This will be used to turn
ACPI PCI hotplug support. By default it is unset.
Signed-off-by: Eric Auger <eric.auger@redhat.com >
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com >
Reviewed-by: Igor Mammedov <imammedo@redhat.com >
Message-Id: <20250714080639.2525563-7-eric.auger@redhat.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:40 -04:00
Eric Auger
ec9af89198
hw/pci-host/gpex-acpi: Split host bridge OSC and DSM generation
...
acpi_dsdt_add_pci_osc() name is confusing as it gives the impression
it appends the _OSC method but in fact it also appends the _DSM method
for the host bridge. Let's split the function into two separate ones
and let them return the method Aml pointer instead. This matches the
way it is done on x86 (build_q35_osc_method). In a subsequent patch
we will replace the gpex method by the q35 implementation that will
become shared between ARM and x86.
acpi_dsdt_add_host_bridge_methods is a new top helper that generates
both the _OSC and _DSM methods.
We take the opportunity to move SUPP and CTRL in the _osc method
that use them.
Signed-off-by: Eric Auger <eric.auger@redhat.com >
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com >
Reviewed-by: Igor Mammedov <imammedo@redhat.com >
Message-Id: <20250714080639.2525563-6-eric.auger@redhat.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:40 -04:00
Gustavo Romero
9748673735
tests/qtest/bios-tables-test: Prepare for changes in the DSDT table
...
This commit adds DSDT blobs to the whilelist in the prospect to
allow changes in the GPEX _OSC method.
Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org >
Signed-off-by: Eric Auger <eric.auger@redhat.com >
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com >
Acked-by: Igor Mammedov <imammedo@redhat.com >
Message-Id: <20250714080639.2525563-5-eric.auger@redhat.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:40 -04:00
Eric Auger
eb3feb8747
hw/pci-host/gpex-acpi: Add native_pci_hotplug arg to acpi_dsdt_add_pci_osc
...
Add a new argument to acpi_dsdt_add_pci_osc to be able to disable
native pci hotplug.
Signed-off-by: Eric Auger <eric.auger@redhat.com >
Reviewed-by: Gustavo Romero <gustavo.romero@linaro.org >
Reviewed-by: Igor Mammedov <imammedo@redhat.com >
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com >
Message-Id: <20250714080639.2525563-4-eric.auger@redhat.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:40 -04:00
Eric Auger
c242101c3c
hw/acpi: Rename and move build_x86_acpi_pci_hotplug to pcihp
...
We plan to reuse build_x86_acpi_pci_hotplug() implementation
for ARM so let's move the code to generic pcihp.
Associated static aml_pci_pdsm() helper is also moved along.
build_x86_acpi_pci_hotplug is renamed into build_acpi_pci_hotplug().
No code change intended.
Also fix the reference to acpi_pci_hotplug.rst documentation
Signed-off-by: Eric Auger <eric.auger@redhat.com >
Reviewed-by: Gustavo Romero <gustavo.romero@linaro.org >
Reviewed-by: Igor Mammedov <imammedo@redhat.com >
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com >
Message-Id: <20250714080639.2525563-3-eric.auger@redhat.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:40 -04:00
Eric Auger
25e84c02e7
hw/i386/acpi-build: Make aml_pci_device_dsm() static
...
No need to export aml_pci_device_dsm() as it is only used
in hw/i386/acpi-build.c.
Signed-off-by: Eric Auger <eric.auger@redhat.com >
Reviewed-by: Gustavo Romero <gustavo.romero@linaro.org >
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org >
Reviewed-by: Igor Mammedov <imammedo@redhat.com >
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com >
Message-Id: <20250714080639.2525563-2-eric.auger@redhat.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:39 -04:00
Philippe Mathieu-Daudé
7f2e88837c
hw/virtio: Build various files once
...
Now that various VirtIO files don't use target specific
API anymore, we can move them to the system_ss[] source
set to build them once.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org >
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org >
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org >
Message-Id: <20250708215320.70426-9-philmd@linaro.org >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:39 -04:00
Philippe Mathieu-Daudé
0f64fb6743
qemu: Declare all load/store helper in 'qemu/bswap.h'
...
Restrict "exec/tswap.h" to the tswap*() methods,
move the load/store helpers with the other ones
declared in "qemu/bswap.h".
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org >
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org >
Message-Id: <20250708215320.70426-8-philmd@linaro.org >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:39 -04:00
Philippe Mathieu-Daudé
16c9cb7187
gdbstub/helpers: Replace TARGET_BIG_ENDIAN -> target_big_endian()
...
Check endianness at runtime to remove the target-specific
TARGET_BIG_ENDIAN definition. Use cpu_to_[be,le]XX() from
"qemu/bswap.h" instead of tswapXX() from "exec/tswap.h".
Suggested-by: Richard Henderson <richard.henderson@linaro.org >
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org >
Message-Id: <20250708215320.70426-7-philmd@linaro.org >
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:39 -04:00
Philippe Mathieu-Daudé
749c21cf6d
qemu: Convert target_words_bigendian() to TargetInfo API
...
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org >
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org >
Reviewed-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20250708215320.70426-6-philmd@linaro.org >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:39 -04:00
Philippe Mathieu-Daudé
a37aec2e7d
qemu/target-info: Add target_endian_mode()
...
target_endian_mode() returns the default endianness (QAPI type)
of a target.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org >
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org >
Reviewed-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20250708215320.70426-5-philmd@linaro.org >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:39 -04:00
Philippe Mathieu-Daudé
536613be40
qemu/target-info: Add %target_arch field to TargetInfo
...
Reviewed-by: Richard Henderson <richard.henderson@linaro.org >
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org >
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org >
Message-Id: <20250708215320.70426-4-philmd@linaro.org >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:39 -04:00
Philippe Mathieu-Daudé
0af00042a9
qemu/target-info: Factor target_arch() out
...
To keep "qemu/target-info.h" self-contained to native
types, declare target_arch() -- which returns a QAPI
type -- in "qemu/target-info-qapi.h".
No logical change.
Keeping native types in "qemu/target-info.h" is necessary
to keep building tests such tests/tcg/plugins/mem.c, as
per the comment added in commit ecbcc9ead2 ("tests/tcg:
add a system test to check memory instrumentation"):
/*
* plugins should not include anything from QEMU aside from the
* API header. However as this is a test plugin to exercise the
* internals of QEMU and we want to avoid needless code duplication we
* do so here. bswap.h is pretty self-contained although it needs a
* few things provided by compiler.h.
*/
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org >
Reviewed-by: Richard Henderson <richard.henderson@linaro.org >
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org >
Message-Id: <20250708215320.70426-3-philmd@linaro.org >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:39 -04:00
Philippe Mathieu-Daudé
fafcff5f30
target/qmp: Use target_cpu_type()
...
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org >
Reviewed-by: Richard Henderson <richard.henderson@linaro.org >
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org >
Message-Id: <20250708215320.70426-2-philmd@linaro.org >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:39 -04:00
CLEMENT MATHIEU--DRIF
c049bf5bb9
intel_iommu: Add support for ATS
...
Signed-off-by: Clement Mathieu--Drif <clement.mathieu--drif@eviden.com >
Message-Id: <20250628180226.133285-11-clement.mathieu--drif@eviden.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:39 -04:00
CLEMENT MATHIEU--DRIF
580b926344
intel_iommu: Set address mask when a translation fails and adjust W permission
...
Implements the behavior defined in section 10.2.3.5 of PCIe spec rev 5.
This is needed by devices that support ATS.
Signed-off-by: Clement Mathieu--Drif <clement.mathieu--drif@eviden.com >
Message-Id: <20250628180226.133285-10-clement.mathieu--drif@eviden.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:39 -04:00
CLEMENT MATHIEU--DRIF
35b47759c7
intel_iommu: Return page walk level even when the translation fails
...
We will use this information in vtd_do_iommu_translate to populate the
IOMMUTLBEntry and indicate the correct page mask. This prevents ATS
devices from sending many useless translation requests when a megapage
or gigapage is not present.
Signed-off-by: Clement Mathieu--Drif <clement.mathieu--drif@eviden.com >
Message-Id: <20250628180226.133285-9-clement.mathieu--drif@eviden.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:39 -04:00
CLEMENT MATHIEU--DRIF
838efe99fd
intel_iommu: Implement the PCIIOMMUOps callbacks related to invalidations of device-IOTLB
...
Signed-off-by: Clement Mathieu--Drif <clement.mathieu--drif@eviden.com >
Message-Id: <20250628180226.133285-8-clement.mathieu--drif@eviden.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:39 -04:00
CLEMENT MATHIEU--DRIF
d6f6467b7c
intel_iommu: Implement vtd_get_iotlb_info from PCIIOMMUOps
...
Signed-off-by: Clement Mathieu--Drif <clement.mathieu--drif@eviden.com >
Message-Id: <20250628180226.133285-7-clement.mathieu--drif@eviden.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:39 -04:00
CLEMENT MATHIEU--DRIF
9b3725eec5
intel_iommu: Declare supported PASID size
...
the PSS field of the extended capabilities stores the supported PASID
size minus 1. This commit adds support for 8bits PASIDs (limited by
MemTxAttrs::pid).
Signed-off-by: Clement Mathieu--Drif <clement.mathieu--drif@eviden.com >
Message-Id: <20250628180226.133285-6-clement.mathieu--drif@eviden.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:39 -04:00
CLEMENT MATHIEU--DRIF
f8eee3452f
intel_iommu: Fill the PASID field when creating an IOMMUTLBEntry
...
PASID value must be used by devices as a key (or part of a key)
when populating their ATC with the IOTLB entries returned by the IOMMU.
Signed-off-by: Clement Mathieu--Drif <clement.mathieu--drif@eviden.com >
Message-Id: <20250628180226.133285-5-clement.mathieu--drif@eviden.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:39 -04:00
CLEMENT MATHIEU--DRIF
1f81edd700
memory: Allow to store the PASID in IOMMUTLBEntry
...
This will be useful for devices that support ATS
and need to store entries in an ATC (device IOTLB).
Signed-off-by: Clement Mathieu--Drif <clement.mathieu--drif@eviden.com >
Message-Id: <20250628180226.133285-4-clement.mathieu--drif@eviden.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:39 -04:00
CLEMENT MATHIEU--DRIF
4b05c720aa
memory: Add permissions in IOMMUAccessFlags
...
This will be necessary for devices implementing ATS.
We also define a new macro IOMMU_ACCESS_FLAG_FULL in addition to
IOMMU_ACCESS_FLAG to support more access flags.
IOMMU_ACCESS_FLAG is kept for convenience and backward compatibility.
Here are the flags added (defined by the PCIe 5 specification) :
- Execute Requested
- Privileged Mode Requested
- Global
- Untranslated Only
IOMMU_ACCESS_FLAG sets the additional flags to 0
Signed-off-by: Clement Mathieu--Drif <clement.mathieu--drif@eviden.com >
Message-Id: <20250628180226.133285-3-clement.mathieu--drif@eviden.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:39 -04:00
CLEMENT MATHIEU--DRIF
06895f7948
pci: Add a memory attribute for pre-translated DMA operations
...
The address_type bit will be set to PCI_AT_TRANSLATED by devices that
use cached addresses obtained via ATS.
Signed-off-by: Clement Mathieu--Drif <clement.mathieu--drif@eviden.com >
Message-Id: <20250628180226.133285-2-clement.mathieu--drif@eviden.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:39 -04:00
Michael S. Tsirkin
4bf06bcf07
rust: bindings: allow any number of params
...
We are going to be adding more parameters, and this makes
rust unhappy:
Functions with lots of parameters are considered bad style and reduce
readability (“what does the 5th parameter mean?”). Consider grouping
some parameters into a new type.
Specifically:
error: this function has too many arguments (8/7)
--> /builds/mstredhat/qemu/build/rust/qemu-api/rust-qemu-api-tests.p/structured/bindings.inc.rs:3840:5
|
3840 | / pub fn new_bitfield_1(
3841 | | secure: std::os::raw::c_uint,
3842 | | space: std::os::raw::c_uint,
3843 | | user: std::os::raw::c_uint,
... |
3848 | | address_type: std::os::raw::c_uint,
3849 | | ) -> __BindgenBitfieldUnit<[u8; 4usize]> {
| |____________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `-D clippy::too-many-arguments` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::too_many_arguments)]`
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org >
Acked-by: Paolo Bonzini <pbonzini@redhat.com >
Message-Id: <e41344bd22248b0883752ef7a7c459090a3d9cfc.1752560127.git.mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-15 02:56:39 -04:00
Li Chen
da77fc6c2e
tests/qtest/bios-tables-test: Add test for disabling SPCR on RISC-V
...
Add ACPI SPCR table test case for RISC-V when SPCR was off.
Signed-off-by: Li Chen <chenl311@chinatelecom.cn >
Reviewed-by: Sunil V L <sunilvl@ventanamicro.com >
Message-Id: <20250528105404.457729-4-me@linux.beauty >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2025-07-14 09:16:40 -04:00