ui: Replace xemu_open_web_browser with SDL_OpenURL

ui/xemu-os-utils-linux.c

@@ -84,14 +84,3 @@ const char *xemu_get_os_info(void)
 
 	return os_info;
 }
-
-void xemu_open_web_browser(const char *url)
-{
-	char *cmd = g_strdup_printf("xdg-open %s", url);
-	int status = system(cmd);
-	if (status < 0) {
-		fprintf(stderr, "Failed to run: %s\n", cmd);
-	}
-
-	free(cmd);
-}

ui/xemu-os-utils-macos.m

@@ -25,8 +25,3 @@ const char *xemu_get_os_info(void)
 {
 	return [[[NSProcessInfo processInfo] operatingSystemVersionString] UTF8String];
 }
-
-void xemu_open_web_browser(const char *url)
-{
-	[[NSWorkspace sharedWorkspace] openURL:[NSURL URLWithString:[NSString stringWithUTF8String:url]]];
-}

ui/xemu-os-utils-windows.c

@@ -59,9 +59,3 @@ const char *xemu_get_os_info(void)
 
     return buffer;
 }
-
-
-void xemu_open_web_browser(const char *url)
-{
-    ShellExecute(0, "open", url, 0, 0, SW_SHOW);
-}

ui/xemu-os-utils.h

@@ -25,7 +25,6 @@ extern "C" {
 #endif
 
 const char *xemu_get_os_info(void);
-void xemu_open_web_browser(const char *url);
 
 #ifndef _WIN32
 #ifdef CONFIG_CPUID_H

ui/xui/compat.cc

@@ -136,7 +136,7 @@ void CompatibilityReporter::Draw()
     ImGui::PopFont();
     ImGui::SameLine();
     if (ImGui::Button("Get Token")) {
-        xemu_open_web_browser("https://reports.xemu.app");
+        SDL_OpenURL("https://reports.xemu.app");
     }
     ImGui::NextColumn();
 

ui/xui/main-menu.cc

@@ -975,7 +975,7 @@ void MainMenuNetworkView::DrawPcapOptions(bool appearing)
         ImGui::Dummy(ImVec2(0,10*g_viewport_mgr.m_scale));
         ImGui::SetCursorPosX((ImGui::GetWindowWidth()-120*g_viewport_mgr.m_scale)/2);
         if (ImGui::Button("Install npcap", ImVec2(120*g_viewport_mgr.m_scale, 0))) {
-            xemu_open_web_browser("https://nmap.org/npcap/");
+            SDL_OpenURL("https://nmap.org/npcap/");
         }
 #endif
     } else {
@@ -1643,7 +1643,7 @@ void MainMenuAboutView::Draw()
     ImGui::Text("Visit");
     ImGui::SameLine();
     if (ImGui::SmallButton("https://xemu.app")) {
-        xemu_open_web_browser("https://xemu.app");
+        SDL_OpenURL("https://xemu.app");
     }
     ImGui::SameLine();
     ImGui::Text("for more information");

ui/xui/menubar.cc

@@ -231,7 +231,7 @@ void ShowMainMenu()
         if (ImGui::BeginMenu("Help"))
         {
             if (ImGui::MenuItem("Help", NULL)) {
-                xemu_open_web_browser("https://xemu.app/docs/getting-started/");
+                SDL_OpenURL("https://xemu.app/docs/getting-started/");
             }
 
             ImGui::MenuItem("Report Compatibility...", NULL,

ui/xui/widgets.cc

@@ -517,7 +517,7 @@ void Hyperlink(const char *text, const char *url)
     ImGui::GetWindowDrawList()->AddLine(min, max, col, 1.0 * g_viewport_mgr.m_scale);
 
     if (ImGui::IsItemClicked()) {
-        xemu_open_web_browser(url);
+        SDL_OpenURL(url);
     }
 }