preserve-emulation/xemu
1
0
Fork 0
mirror of https://github.com/xemu-project/xemu.git synced 2026-07-11 01:24:41 +02:00
Code Issues Packages Projects Releases Wiki Activity

ui/spice: Destroy the temporary egl fb after the blit is submitted

Browse Source 
The temporary egl fb scanout_tex_fb is only needed to facilitate the
blit to the display surface's texture (ssd->ds->texture). Therefore,
destroy it after the blit is submitted. And, also make sure that it
is empty initialized before it is actually used.

Fixes: f851cd65 ("ui/spice: Blit the scanout texture if its memory layout is not linear")
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Vivek Kasireddy <vivek.kasireddy@intel.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-ID: <20250718234039.2266704-1-vivek.kasireddy@intel.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
This commit is contained in:
Vivek Kasireddy
2025-07-18 16:40:39 -07:00
committed by Stefan Hajnoczi
parent b2a9482207
commit 0c0729b46a
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ui/spice-display.c
+6 -8
View File
@@ -1183,20 +1183,20 @@ static void qemu_spice_gl_release_dmabuf(DisplayChangeListener *dcl,
egl_dmabuf_release_texture(dmabuf);
}
static bool spice_gl_blit_scanout_texture(SimpleSpiceDisplay *ssd,
egl_fb *scanout_tex_fb)
static bool spice_gl_blit_scanout_texture(SimpleSpiceDisplay *ssd)
{
uint32_t offsets[DMABUF_MAX_PLANES], strides[DMABUF_MAX_PLANES];
int fds[DMABUF_MAX_PLANES], num_planes, fourcc;
egl_fb scanout_tex_fb = {};
uint64_t modifier;
bool ret;
egl_fb_destroy(scanout_tex_fb);
egl_fb_setup_for_tex(scanout_tex_fb,
egl_fb_setup_for_tex(&scanout_tex_fb,
surface_width(ssd->ds), surface_height(ssd->ds),
ssd->ds->texture, false);
egl_fb_blit(scanout_tex_fb, &ssd->guest_fb, false);
egl_fb_blit(&scanout_tex_fb, &ssd->guest_fb, false);
glFlush();
egl_fb_destroy(&scanout_tex_fb);
if (!ssd->new_scanout_texture) {
return true;
@@ -1330,9 +1330,7 @@ static void qemu_spice_gl_update(DisplayChangeListener *dcl,
}
if (spice_remote_client && ssd->blit_scanout_texture) {
egl_fb scanout_tex_fb;
ret = spice_gl_blit_scanout_texture(ssd, &scanout_tex_fb);
ret = spice_gl_blit_scanout_texture(ssd);
if (!ret) {
return;
}