preserve-emulation/shadPS4
1
0
Fork 0
mirror of https://github.com/shadps4-emu/shadPS4.git synced 2026-07-11 01:24:28 +02:00
Code Issues Packages Projects Releases Wiki Activity

Avoid storing lambda as a local variable (#4687)

Browse Source 
Parameters to the TryWriteBacking call were getting corrupted during async texture downloads after #4593
This commit is contained in:
Stephen Miller
2026-07-08 12:17:49 -05:00
committed by GitHub
parent 48f4bf889e
commit aa18760e5e
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/video_core/texture_cache/texture_cache.cpp
+7 -7
View File
@@ -124,16 +124,16 @@ void TextureCache::DownloadImageMemory(ImageId image_id, bool sync) {
cmdbuf.copyImageToBuffer(image.GetImage(), vk::ImageLayout::eTransferSrcOptimal,
download_buffer.Handle(), image_download);
const auto write_data = [this, device_addr = image.info.guest_address, download,
download_size] {
Core::Memory::Instance()->TryWriteBacking(std::bit_cast<u8*>(device_addr), download,
download_size);
};
if (sync) {
scheduler.Finish();
write_data();
Core::Memory::Instance()->TryWriteBacking(std::bit_cast<u8*>(image.info.guest_address),
download, download_size);
} else {
scheduler.DeferPriorityOperation(write_data);
scheduler.DeferPriorityOperation(
[this, device_addr = image.info.guest_address, download, download_size] {
Core::Memory::Instance()->TryWriteBacking(std::bit_cast<u8*>(device_addr), download,
download_size);
});
}
}