mirror of
https://github.com/hrydgard/ppsspp.git
synced 2026-07-27 09:15:00 +02:00
Same class of bug as the USE_DISCORD fix: add_compile_definitions() only affects targets created after the call, but the whole USE_MINIUPNPC block sat after add_library(Core STATIC ...). That meant Core/Util/PortManager.cpp, built as part of that same add_library call, never actually saw WITH_UPNP or any of the other miniupnpc defines - UPnP support was silently compiled out on every platform. Split the block: compile definitions and the miniupnpc source-file/include setup now run before add_library(Core STATIC ...), while building the bundled miniupnpc target and linking it into Core (which needs the Core target to already exist) stays after, in its original spot. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PSNaZnHCjmryS3ziVN9gZU