Add a warning in games that are affected badly by savestate timewarps

Core/Compatibility.cpp

@@ -151,6 +151,7 @@ void Compatibility::CheckSettings(IniFile &iniFile, const std::string &gameID) {
 	CheckSetting(iniFile, gameID, "SoftwareRasterDepth", &flags_.SoftwareRasterDepth);
 	CheckSetting(iniFile, gameID, "DisableHLESceFont", &flags_.DisableHLESceFont);
 	CheckSetting(iniFile, gameID, "ForceHLEPsmf", &flags_.ForceHLEPsmf);
+	CheckSetting(iniFile, gameID, "SaveStatesNotRecommended", &flags_.SaveStatesNotRecommended);
 }
 
 void Compatibility::CheckVRSettings(IniFile &iniFile, const std::string &gameID) {

Core/Compatibility.h

@@ -114,6 +114,7 @@ struct CompatFlags {
 	bool SoftwareRasterDepth;
 	bool DisableHLESceFont;
 	bool ForceHLEPsmf;
+	bool SaveStatesNotRecommended;
 };
 
 struct VRCompat {

Tools/langtool/Cargo.lock

@@ -54,9 +54,9 @@ dependencies = [
 
 [[package]]
 name = "clap"
-version = "4.5.41"
+version = "4.5.42"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "be92d32e80243a54711e5d7ce823c35c41c9d929dc4ab58e1276f625841aadf9"
+checksum = "ed87a9d530bb41a67537289bafcac159cb3ee28460e0a4571123d2a778a6a882"
 dependencies = [
  "clap_builder",
  "clap_derive",
@@ -64,9 +64,9 @@ dependencies = [
 
 [[package]]
 name = "clap_builder"
-version = "4.5.41"
+version = "4.5.42"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "707eab41e9622f9139419d573eca0900137718000c517d47da73045f54331c3d"
+checksum = "64f4f3f3c77c94aff3c7e9aac9a2ca1974a5adf392a8bb751e827d6d127ab966"
 dependencies = [
  "anstream",
  "anstyle",

UI/PauseScreen.cpp

@@ -373,6 +373,7 @@ void GamePauseScreen::CreateViews() {
 	auto pa = GetI18NCategory(I18NCat::PAUSE);
 	auto ac = GetI18NCategory(I18NCat::ACHIEVEMENTS);
 	auto nw = GetI18NCategory(I18NCat::NETWORKING);
+	auto di = GetI18NCategory(I18NCat::DIALOG);
 
 	root_ = new LinearLayout(ORIENT_HORIZONTAL);
 
@@ -440,6 +441,15 @@ void GamePauseScreen::CreateViews() {
 	}
 
 	if (showSavestateControls) {
+		if (PSP_CoreParameter().compat.flags().SaveStatesNotRecommended) {
+			LinearLayout *horiz = new LinearLayout(UI::ORIENT_HORIZONTAL);
+			leftColumnItems->Add(horiz);
+			horiz->Add(new NoticeView(NoticeLevel::WARN, pa->T("Using save states is not recommended in this game"), "", new LinearLayoutParams(1.0f)));
+			horiz->Add(new Button(di->T("More info")))->OnClick.Add([](UI::EventParams &e) {
+				System_LaunchUrl(LaunchUrlType::BROWSER_URL, "https://www.ppsspp.org/docs/troubleshooting/save-state-time-warps");
+				return UI::EVENT_DONE;
+			});
+		}
 		CreateSavestateControls(leftColumnItems, vertical);
 	} else {
 		// Let's show the active challenges.

assets/compat.ini

@@ -1981,3 +1981,54 @@ NPEG00004 = true
 # See issue #20467
 NPUH10105 = true
 NPEH00122 = true
+
+[SaveStatesNotRecommended]
+# MONSTER HUNTER FREEDOM
+UCKS45036 = true
+ULUS10084 = true
+ULAS42060 = true
+
+# MONSTER HUNTER FREEDOM(TM)
+ULES00318 = true
+
+# MONSTER HUNTER FREEDOM 2
+ULUS10266 = true
+ULES00851 = true
+
+# MONSTER HUNTER FREEDOM UNITE
+ULED01244 = true
+ULES01213 = true
+ULUS10391 = true
+ULUS10391 = true
+
+# Monster Hunter Freedom Unite (Demo)
+ULUS90003 = true
+
+# Monster Hunter Portable
+ULJM05066 = true
+
+# Monster Hunter Portable 2nd
+ULJM05156 = true
+
+# Monster Hunter Portable 2nd G
+ULJM05500 = true
+
+# Monster Hunter Portable 3rd
+NPJH90146 = true 
+ULJM05800 = true
+NPJB40001 = true
+NPJH55800 = true
+ULJM08058 = true
+
+# Monster Hunter Portable 3rd HD
+NPJB40001 = true 
+
+# Patapon 3
+UCUS98751 = true
+UCAS40318 = true
+UCJS10113 = true
+UCKS45169 = true
+NPJG00122 = true
+UCJS18048 = true
+UCES01421 = true
+UCJS18059 = true

assets/lang/ar_AE.ini

@@ -1035,6 +1035,7 @@ Settings = ‎الإعدادات
 Switch UMD = ‎تبديل الـ UMD
 Undo last load = تراجع عن اخر تحميل
 Undo last save = تراجع عن اخر حفظ
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (duplicated setting, previous slider will be used)

assets/lang/az_AZ.ini

@@ -1027,6 +1027,7 @@ Settings = Ayarlar
 Switch UMD = Switch UMD
 Undo last load = Undo last load
 Undo last save = Undo last save
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (duplicated setting, previous slider will be used)

assets/lang/be_BY.ini

@@ -977,6 +977,7 @@ Settings = Налады
 Switch UMD = Змяніць UMD
 Undo last load = Undo last load
 Undo last save = Undo last save
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (duplicated setting, previous slider will be used)

assets/lang/bg_BG.ini

@@ -1027,6 +1027,7 @@ Settings = Настройки
 Switch UMD = Смени UMD
 Undo last load = Undo last load
 Undo last save = Undo last save
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (duplicated setting, previous slider will be used)

assets/lang/ca_ES.ini

@@ -1027,6 +1027,7 @@ Settings = Configuració general
 Switch UMD = Canviar UMD
 Undo last load = Desfer càrrega d'estat
 Undo last save = Desfer guard. d'estat
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (duplicated setting, previous slider will be used)

assets/lang/cz_CZ.ini

@@ -1027,6 +1027,7 @@ Settings = Nastavení
 Switch UMD = Přepnout UMD
 Undo last load = Undo last load
 Undo last save = Undo last save
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (duplicated setting, previous slider will be used)

assets/lang/da_DK.ini

@@ -1027,6 +1027,7 @@ Settings = Indstillinger
 Switch UMD = Skift UMD
 Undo last load = Undo last load
 Undo last save = Undo last save
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (duplicated setting, previous slider will be used)

assets/lang/de_DE.ini

@@ -1017,6 +1017,7 @@ Settings = Einstellungen
 Switch UMD = UMD wechseln
 Undo last load = Letztes Laden rückgängig machen
 Undo last save = Letzte Speicherung rückgängig machen
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (duplizierte Einstellung, vorheriger Schieberegler wird verwendet)

assets/lang/dr_ID.ini

@@ -1027,6 +1027,7 @@ Settings = Pangngaturan
 Switch UMD = Switch UMD
 Undo last load = Undo last load
 Undo last save = Undo last save
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (duplicated setting, previous slider will be used)

assets/lang/en_US.ini

@@ -1001,6 +1001,7 @@ Settings = Settings
 Switch UMD = Switch UMD
 Undo last load = Undo last load
 Undo last save = Undo last save
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (duplicated setting, previous slider will be used)

assets/lang/es_ES.ini

@@ -1028,6 +1028,7 @@ Settings = Ajustes generales
 Switch UMD = Cambiar UMD
 Undo last load = Deshacer última carga
 Undo last save = Deshacer último guardado
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (configuración duplicada, se utilizará la anterior)

assets/lang/es_LA.ini

@@ -1027,6 +1027,7 @@ Settings = Ajustes generales
 Switch UMD = Cambiar UMD
 Undo last load = Deshacer carga de estado
 Undo last save = Deshacer guardado de estado
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (configuraciones duplicadas, se usará la anterior)

assets/lang/fa_IR.ini

@@ -1027,6 +1027,7 @@ Settings = ‎تنظیمات
 Switch UMD = ‎تغییر دیسک
 Undo last load = بازگشت تنظیمات لود شده
 Undo last save = بازگشت تنظیمات سیو شده
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (duplicated setting, previous slider will be used)

assets/lang/fi_FI.ini

@@ -1027,6 +1027,7 @@ Settings = Asetukset
 Switch UMD = Vaihda UMD
 Undo last load = Peru viimeisin tilan lataus
 Undo last save = Peru viimeisin tilan tallennus
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (duplicated setting, previous slider will be used)

assets/lang/fr_FR.ini

@@ -1027,6 +1027,7 @@ Settings = Paramètres
 Switch UMD = Changer d'UMD
 Undo last load = Undo last load
 Undo last save = Undo last save
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (paramètre dupliqué, l'ajustement précédent sera utilisé)

assets/lang/gl_ES.ini

@@ -1027,6 +1027,7 @@ Settings = Axustes xerais
 Switch UMD = Cambiar UMD
 Undo last load = Undo last load
 Undo last save = Undo last save
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (duplicated setting, previous slider will be used)

assets/lang/gr_EL.ini

@@ -1027,6 +1027,7 @@ Settings = Ρυθμίσεις
 Switch UMD = Αλλαγή UMD
 Undo last load = Undo last load
 Undo last save = Undo last save
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (duplicated setting, previous slider will be used)

assets/lang/he_IL.ini

@@ -1027,6 +1027,7 @@ Settings = הגדרות
 Switch UMD = Switch UMD
 Undo last load = Undo last load
 Undo last save = Undo last save
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (duplicated setting, previous slider will be used)

assets/lang/he_IL_invert.ini

@@ -1024,6 +1024,7 @@ Settings = תורדגה
 Switch UMD = Switch UMD
 Undo last load = Undo last load
 Undo last save = Undo last save
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (duplicated setting, previous slider will be used)

assets/lang/hr_HR.ini

@@ -1027,6 +1027,7 @@ Settings = Postavke
 Switch UMD = Promijeni UMD
 Undo last load = Undo last load
 Undo last save = Undo last save
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (duplicated setting, previous slider will be used)

assets/lang/hu_HU.ini

@@ -1027,6 +1027,7 @@ Settings = Beállítások
 Switch UMD = UMD váltása
 Undo last load = Utolsó betöltés visszavonása
 Undo last save = Utolsó mentés visszavonása
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (lemásolt beállítás, az előző értéke lesz használva)

assets/lang/id_ID.ini

@@ -1027,6 +1027,7 @@ Settings = Pengaturan
 Switch UMD = Ganti UMD
 Undo last load = Urungkan pemuatan terakhir
 Undo last save = Urungkan penyimpanan terakhir
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (pengaturan duplikat, penggeser sebelumnya akan digunakan)

assets/lang/it_IT.ini

@@ -995,6 +995,7 @@ Settings = Impostazioni
 Switch UMD = Cambia UMD
 Undo last load = Annulla ultimo caricamento
 Undo last save = Annulla ultimo salvataggio
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (parametro duplicato, verrà usata la precedente regolazione)

assets/lang/ja_JP.ini

@@ -994,6 +994,7 @@ Settings = 設定
 Switch UMD = UMDを交換する
 Undo last load = ロードを取り消す
 Undo last save = セーブ内容を戻す
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (設定が重複しているため、以前のスライダーが使用されます)

assets/lang/jv_ID.ini

@@ -1027,6 +1027,7 @@ Settings = Setelan
 Switch UMD = Ngalih UMD
 Undo last load = Undo last load
 Undo last save = Undo last save
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (duplicated setting, previous slider will be used)

assets/lang/ko_KR.ini

@@ -977,6 +977,7 @@ Settings = 설정
 Switch UMD = UMD 교체
 Undo last load = 마지막 불러오기 실행 취소
 Undo last save = 마지막 저장 실행 취소
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (설정이 중복되면 이전 슬라이더가 사용됩니다.)

assets/lang/ku_SO.ini

@@ -991,6 +991,7 @@ Settings = سێتینگ
 Switch UMD = Switch UMD
 Undo last load = Undo last load
 Undo last save = Undo last save
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (duplicated setting, previous slider will be used)

assets/lang/lo_LA.ini

@@ -1027,6 +1027,7 @@ Settings = ການຕັ້ງຄ່າ
 Switch UMD = ສະຫຼັບແຜ່ນ UMD
 Undo last load = Undo last load
 Undo last save = Undo last save
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (duplicated setting, previous slider will be used)

assets/lang/lt-LT.ini

@@ -1027,6 +1027,7 @@ Settings = Settings
 Switch UMD = Pakeisti "UMD"
 Undo last load = Undo last load
 Undo last save = Undo last save
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (duplicated setting, previous slider will be used)

assets/lang/ms_MY.ini

@@ -1027,6 +1027,7 @@ Settings = Settings
 Switch UMD = Tukar UMD
 Undo last load = Undo last load
 Undo last save = Undo last save
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (duplicated setting, previous slider will be used)

assets/lang/nl_NL.ini

@@ -1027,6 +1027,7 @@ Settings = Instellingen
 Switch UMD = UMD verwisselen
 Undo last load = Undo last load
 Undo last save = Undo last save
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (duplicated setting, previous slider will be used)

assets/lang/no_NO.ini

@@ -1027,6 +1027,7 @@ Settings = Instillinger
 Switch UMD = Switch UMD
 Undo last load = Undo last load
 Undo last save = Undo last save
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (duplicated setting, previous slider will be used)

assets/lang/pl_PL.ini

@@ -1032,6 +1032,7 @@ Settings = Ustawienia
 Switch UMD = Podmień UMD
 Undo last load = Cofnij ostatnio wczytane
 Undo last save = Cofnij ostatni zapis
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (zduplikowane ustawienia; użyte zostanie poprzednie ustawienie)

assets/lang/pt_BR.ini

@@ -1003,6 +1003,7 @@ Settings = Configurações
 Switch UMD = Trocar UMD
 Undo last load = Desfazer o último carregamento
 Undo last save = Desfazer o último salvamento
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (configuração duplicada, o slider anterior será usado)

assets/lang/pt_PT.ini

@@ -1020,6 +1020,7 @@ Settings = Definições
 Switch UMD = Trocar UMD
 Undo last load = Desfazer o último carregamento
 Undo last save = Desfazer o último salvamento
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (Definição duplicada, o slider anterior será usado)

assets/lang/ro_RO.ini

@@ -1028,6 +1028,7 @@ Settings = Setări
 Switch UMD = Schimbă UMD
 Undo last load = Undo last load
 Undo last save = Undo last save
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (duplicated setting, previous slider will be used)

assets/lang/ru_RU.ini

@@ -994,6 +994,7 @@ Settings = Настройки
 Switch UMD = Сменить UMD
 Undo last load = Отменить последнюю загрузку
 Undo last save = Отменить последнее сохранение
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (дублированная настройка, используется предыдущий ползунок)

assets/lang/sv_SE.ini

@@ -978,6 +978,7 @@ Settings = Inställningar
 Switch UMD = Byt UMD
 Undo last load = Ångra senaste ladd
 Undo last save = Ångra senaste spar
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (duplicated setting, previous slider will be used)

assets/lang/tg_PH.ini

@@ -1028,6 +1028,7 @@ Settings = Settings
 Switch UMD = Magpalit ng UMD
 Undo last load = Undo last load
 Undo last save = Undo last save
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (dobleng setting, naunang slider ang gagamitin)

assets/lang/th_TH.ini

@@ -1049,6 +1049,7 @@ Settings = การตั้งค่า
 Switch UMD = สลับแผ่น UMD
 Undo last load = ย้อนคืนโหลดครั้งล่าสุด
 Undo last save = ย้อนคืนเซฟครั้งล่าสุด
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (การตั้งค่าที่ซ้ำซ้อนกัน อาจจะใช้แถบเลื่อนก่อนหน้า)

assets/lang/tr_TR.ini

@@ -1029,6 +1029,7 @@ Settings = Ayarlar
 Switch UMD = UMD Değiştir
 Undo last load = Son yüklemeyi geri al
 Undo last save = Son kaydı geri al
+Using save states is not recommended in this game = Using save states is not recommended in this game
 [PostShaders]
 (duplicated setting, previous slider will be used) = (yinelenen ayar, önceki kaydırıcı kullanılacaktır)
 4xHqGLSL = 4xHqGLSL

assets/lang/uk_UA.ini

@@ -1027,6 +1027,7 @@ Settings = Налаштування
 Switch UMD = Перемикач UMD
 Undo last load = Скасувати останнє провантаження
 Undo last save = Скасувати останнє збереження
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (duplicated setting, previous slider will be used)

assets/lang/vi_VN.ini

@@ -1027,6 +1027,7 @@ Settings = Cấu hình trò chơi
 Switch UMD = Đổi UMD
 Undo last load = Undo last load
 Undo last save = Undo last save
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (duplicated setting, previous slider will be used)

assets/lang/zh_CN.ini

@@ -1028,6 +1028,7 @@ Settings = 设置
 Switch UMD = 切换UMD光盘
 Undo last load = 撤销加载
 Undo last save = 撤销保存
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (重复，将使用上面的设置值)

assets/lang/zh_TW.ini

@@ -994,6 +994,7 @@ Settings = 設定
 Switch UMD = 切換 UMD
 Undo last load = 復原上次載入
 Undo last save = 復原上次儲存
+Using save states is not recommended in this game = Using save states is not recommended in this game
 
 [PostShaders]
 (duplicated setting, previous slider will be used) = (重複的設定，將使用上一個滑桿)