mirror of
https://github.com/hrydgard/ppsspp.git
synced 2026-11-16 19:13:40 +01:00
Firmware: Ignore empty updaters on discs
UMD Video discs ship an updater PARAM.SFO next to a 0-byte DATA.BIN, and PSN releases zero-fill it. MountedDiscHasUpdater() only checked that DATA.BIN existed, so booting the EUR Video Demo Disc's game with no firmware installed started an auto-install of "2.00" that failed with an OSD error. It now wants a PSAR archive, like ReadBundledUpdateInfo() already did. The game info screen no longer looks for an updater on UMD Video discs at all. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
1 parent
c1ec2044db
commit
dc41268bfc
2 files changed
+6
-2
No files matched your search
@@ -1474,7 +1474,10 @@ static std::string ReadUpdaterVersionFromArchiveHeader() {
|
||||
}
|
||||
|
||||
bool MountedDiscHasUpdater() {
|
||||
return pspFileSystem.GetFileInfo(std::string("disc0:/") + UPDATE_PSAR_SUFFIX).exists;
|
||||
// Plenty of discs keep the updater's files with nothing in them: UMD Video discs ship a 0-byte
|
||||
// DATA.BIN next to a real PARAM.SFO, PSN releases zero-fill it. Only an actual archive counts.
|
||||
std::vector<u8> head;
|
||||
return ReadHeadFromMountedDisc(UPDATE_PSAR_SUFFIX, 4, &head) && head.size() == 4 && ReadU32(head.data()) == PSAR_MAGIC;
|
||||
}
|
||||
|
||||
std::string ReadMountedDiscUpdaterVersion() {
|
||||
|
||||
@@ -881,7 +881,8 @@ handleELF:
|
||||
|
||||
// Most UMDs carry a firmware updater, which is a source of things like the
|
||||
// system fonts. Just note down what's there - unpacking it is a separate step.
|
||||
if (flags_ & GameInfoFlags::BUNDLED_UPDATE_INFO) {
|
||||
// UMD Video discs only carry a placeholder (an empty DATA.BIN), so they're skipped.
|
||||
if ((flags_ & GameInfoFlags::BUNDLED_UPDATE_INFO) && fileType != IdentifiedFileType::PSP_UMD_VIDEO_ISO) {
|
||||
BundledUpdateInfo update;
|
||||
ReadBundledUpdateInfo(&umd, "/", &update);
|
||||
std::lock_guard<std::mutex> lock(info_->lock);
|
||||
|
||||
Reference in new issue
Block a user