Merge pull request #19032 from GermanAizek/fix-always-false-true

Fixed conditions always false using unsigned type and logical AND 0x0 & 0x4

Common/Buffer.cpp

@@ -111,7 +111,7 @@ void Buffer::Printf(const char *fmt, ...) {
 		// Output was truncated. TODO: Do something.
 		ERROR_LOG(IO, "Buffer::Printf truncated output");
 	}
-	if (retval < 0) {
+	if ((int)retval < 0) {
 		ERROR_LOG(IO, "Buffer::Printf failed");
 	}
 	va_end(vl);

Common/GPU/OpenGL/GLRenderManager.h

@@ -421,7 +421,6 @@ public:
 		// an init command, that's for sure.
 		GLRInitStep &step = initSteps_.push_uninitialized();
 		step.stepType = GLRInitStepType::BUFFER_SUBDATA;
-		_dbg_assert_(offset >= 0);
 		_dbg_assert_(offset <= buffer->size_ - size);
 		step.buffer_subdata.buffer = buffer;
 		step.buffer_subdata.offset = (int)offset;

Core/Util/DisArm64.cpp

@@ -916,8 +916,6 @@ static void FPandASIMD2(uint32_t w, uint64_t addr, Instruction *instr) {
 			} else if (((w >> 10) & 0x3f) == 0x0 && opcode == 0) {
 				char ir = sf ? 'x' : 'w';
 				char roundmode = "npmz"[(w >> 19) & 3];
-				if (opcode & 0x4)
-					roundmode = 'a';
 				char fr = ((w >> 22) & 1) ? 'd' : 's';
 				snprintf(instr->text, sizeof(instr->text), "fcvt%cs %c%d, %c%d", roundmode, ir, Rd, fr, Rn);
 			} else if ((opcode & 6) == 2) {