preserve-emulation/ppsspp
1
0
Fork 0
mirror of https://github.com/hrydgard/ppsspp.git synced 2026-09-30 00:06:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

Settle the wording of the two video firmware messages

Browse Source 
The sceMpeg one goes away: our HLE handles almost everything, so ending up on it
isn't worth interrupting the player over. It stays in the log, where it explains
why a video might not look the way it does with the real module.

The sceMp4 one is the one that matters, since there is no working HLE behind it,
and it now says "installed firmware" rather than "firmware dump" - PPSSPP
installs firmware much as a PSP does these days, so that is the wrong word.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Henrik Rydgård
2026-09-18 13:50:25 -06:00
co-authored by Claude Opus 5
parent f6655d8b62
commit 9b78155ebd
2 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Core/HLE/HLE.cpp
+4 -7
View File
@@ -428,16 +428,13 @@ void HLECheckModuleAvailability() {
}
}
// sceMpeg is the one that should normally be there - PPSSPP installs a firmware dump when it
// finds one - so unlike sceMp4 above, not having it is worth saying out loud. Unless the disc
// brought its own, which is just as good and wants no comment.
// Nothing on screen for this one: the sceMpeg HLE is good enough that landing on it is not
// something to interrupt the player over. Worth a line in the log, since it explains why a
// video looks different from how it looks with the real module.
if (AlwaysDisableHLEFlags() & DisableHLEFlags::sceMpeg) {
if (!pspFileSystem.GetFileInfo("flash0:/kd/mpeg.prx").exists && !DiscHasModule("mpeg.prx")) {
g_unavailableDisableFlags |= DisableHLEFlags::sceMpeg;
ERROR_LOG(Log::HLE, "Neither flash0:/kd nor the disc has mpeg.prx - using the HLE sceMpeg.");
auto sy = GetI18NCategory(I18NCat::SYSTEM);
g_OSD.Show(OSDType::MESSAGE_WARNING,
sy->T("No mpeg.prx - install a firmware dump for accurate video"), 6.0f);
INFO_LOG(Log::HLE, "Neither flash0:/kd nor the disc has mpeg.prx - using the HLE sceMpeg.");
}
}
}
Core/HLE/sceUtility.cpp
+3 -2
View File
@@ -182,8 +182,9 @@ static void NotifyLoadStatusMp4(int state, u32 loadAddr, u32 totalSize) {
if (!pspFileSystem.GetFileInfo("flash0:/kd/libmp4.prx").exists ||
!pspFileSystem.GetFileInfo("flash0:/kd/mp4msv.prx").exists) {
auto sy = GetI18NCategory(I18NCat::SYSTEM);
g_OSD.Show(OSDType::MESSAGE_WARNING, sy->T("MP4 playback needs a firmware dump from "
"version 6.00 or later - it won't work without one"), 8.0f, "hle_no_module_sceMp4");
g_OSD.Show(OSDType::MESSAGE_WARNING,
sy->T("MP4 playback needs PSP firmware 6.00 or later to be installed"),
8.0f, "hle_no_module_sceMp4");
}
return;
}