preserve-emulation/ppsspp
1
0
Fork 0
mirror of https://github.com/hrydgard/ppsspp.git synced 2026-07-11 01:25:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

Remove more excessive error reporting.

Browse Source
This commit is contained in:
Henrik Rydgård
2025-03-02 01:32:34 +01:00
parent c6691de64c
commit 962bd8239d
8 changed files with 17 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Core/HLE/sceDmac.cpp
+1 -1
View File
@@ -84,7 +84,7 @@ static u32 sceDmacMemcpy(u32 dst, u32 src, u32 size) {
}
if (dmacMemcpyDeadline > CoreTiming::GetTicks()) {
WARN_LOG_REPORT_ONCE(overlapDmacMemcpy, Log::HLE, "sceDmacMemcpy(dest=%08x, src=%08x, size=%d): overlapping read", dst, src, size);
WARN_LOG(Log::HLE, "sceDmacMemcpy(dest=%08x, src=%08x, size=%d): overlapping read", dst, src, size);
// TODO: Should block, seems like copy doesn't start until previous finishes.
// Might matter for overlapping copies.
}
Core/HLE/sceIo.cpp
+4 -2
View File
@@ -977,11 +977,13 @@ static u32 sceIoChstat(const char *filename, u32 iostatptr, u32 changebits) {
if (!iostat.IsValid())
return hleReportError(Log::sceIo, SCE_KERNEL_ERROR_ERRNO_INVALID_ARGUMENT, "bad address");
ERROR_LOG_REPORT(Log::sceIo, "UNIMPL sceIoChstat(%s, %08x, %08x)", filename, iostatptr, changebits);
ERROR_LOG(Log::sceIo, "UNIMPL sceIoChstat(%s, %08x, %08x)", filename, iostatptr, changebits);
if (changebits & SCE_CST_MODE)
ERROR_LOG_REPORT(Log::sceIo, "sceIoChstat: change mode to %03o requested", iostat->st_mode);
if (changebits & SCE_CST_ATTR)
if (changebits & SCE_CST_ATTR) {
// These are pretty much all of the reported calls: https://report.ppsspp.org/logs/kind/1115
ERROR_LOG_REPORT(Log::sceIo, "sceIoChstat: change attr to %04x requested", iostat->st_attr);
}
if (changebits & SCE_CST_SIZE)
ERROR_LOG(Log::sceIo, "sceIoChstat: change size requested");
if (changebits & SCE_CST_CT)
Core/HLE/sceKernelInterrupt.cpp
+2 -1
View File
@@ -510,7 +510,8 @@ u32 sceKernelRegisterSubIntrHandler(u32 intrNumber, u32 subIntrNumber, u32 handl
return hleLogDebug(Log::sceIntc, error);
}
} else if (error == SCE_KERNEL_ERROR_FOUND_HANDLER) {
return hleReportError(Log::sceIntc, error, "duplicate handler");
// Pretty common. Used to report here, but not useful.
return hleLogError(Log::sceIntc, error, "duplicate handler");
}
return hleReportError(Log::sceIntc, error);
}
Core/MIPS/ARM/ArmCompBranch.cpp
+1 -1
View File
@@ -512,7 +512,7 @@ void ArmJit::Comp_Jump(MIPSOpcode op) {
// Might be a stubbed address or something?
if (!Memory::IsValidAddress(targetAddr) || (targetAddr & 3) != 0) {
if (js.nextExit == 0) {
ERROR_LOG_REPORT(Log::JIT, "Jump to invalid address: %08x", targetAddr);
ERROR_LOG(Log::JIT, "Jump to invalid address: %08x", targetAddr);
} else {
js.compiling = false;
}
Core/MIPS/ARM64/Arm64CompBranch.cpp
+1 -1
View File
@@ -527,7 +527,7 @@ void Arm64Jit::Comp_Jump(MIPSOpcode op) {
// Might be a stubbed address or something?
if (!Memory::IsValidAddress(targetAddr) || (targetAddr & 3) != 0) {
if (js.nextExit == 0) {
ERROR_LOG_REPORT(Log::JIT, "Jump to invalid address: %08x", targetAddr);
ERROR_LOG(Log::JIT, "Jump to invalid address: %08x", targetAddr);
} else {
js.compiling = false;
}
Core/MIPS/IR/IRCompBranch.cpp
+4 -3
View File
@@ -334,10 +334,11 @@ void IRFrontend::Comp_Jump(MIPSOpcode op) {
// Might be a stubbed address or something?
if (!Memory::IsValidAddress(targetAddr)) {
// If preloading, flush - this block will likely be fixed later.
if (js.preloading)
if (js.preloading) {
js.cancel = true;
else
ERROR_LOG_REPORT(Log::JIT, "Jump to invalid address: %08x", targetAddr);
} else {
ERROR_LOG(Log::JIT, "Jump to invalid address: %08x", targetAddr);
}
// TODO: Mark this block dirty or something? May be indication it will be changed by imports.
// Continue so the block gets completed and crashes properly.
}
Core/MIPS/MIPSTables.cpp
+3 -1
View File
@@ -913,7 +913,9 @@ void MIPSCompileOp(MIPSOpcode op, MIPSComp::MIPSFrontendInterface *jit) {
if (info & OUT_EAT_PREFIX)
jit->EatPrefix();
} else {
ERROR_LOG_REPORT(Log::CPU, "MIPSCompileOp: Invalid instruction %08x", op.encoding);
// Used to _REPORT this, but I'm confident we have all instructions now, any caught here
// are due to games crashing, due to cheats or bugs.
ERROR_LOG(Log::CPU, "MIPSCompileOp: Invalid instruction %08x", op.encoding);
}
}
Core/MIPS/x86/CompBranch.cpp
+1 -1
View File
@@ -640,7 +640,7 @@ void Jit::Comp_Jump(MIPSOpcode op) {
// Might be a stubbed address or something?
if (!Memory::IsValidAddress(targetAddr) || (targetAddr & 3) != 0) {
if (js.nextExit == 0) {
ERROR_LOG_REPORT(Log::JIT, "Jump to invalid address: %08x PC %08x LR %08x", targetAddr, GetCompilerPC(), currentMIPS->r[MIPS_REG_RA]);
ERROR_LOG(Log::JIT, "Jump to invalid address: %08x PC %08x LR %08x", targetAddr, GetCompilerPC(), currentMIPS->r[MIPS_REG_RA]);
} else {
js.compiling = false;
}