preserve-emulation/ppsspp
1
0 Fork 0
mirror of https://github.com/hrydgard/ppsspp.git synced 2026-10-17 16:30:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

x86jit: Skip reload of EAX in safe cases.

Browse Source 
Probably no real improvement in perf, but a bit cleaner and one less TODO.
This commit is contained in:
Unknown W. Brackets committed 2014-12-17 01:12:41 -08:00
1 parent afdbf5610b
commit 9022b48069
3 files changed
+21 -15
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

Core/MIPS/x86/Asm.cpp
+1
View File
@@ -100,6 +100,7 @@ void AsmRoutineManager::Generate(MIPSState *mips, MIPSComp::Jit *jit)
dispatcherNoCheck = GetCodePtr();
MOV(32, R(EAX), M(&mips->pc));
dispatcherInEAXNoCheck = GetCodePtr();
#ifdef _M_IX86
AND(32, R(EAX), Imm32(Memory::MEMVIEW32_MASK));
Core/MIPS/x86/Asm.h
+1
View File
@@ -56,6 +56,7 @@ public:
const u8 *dispatcher;
const u8 *dispatcherCheckCoreState;
const u8 *dispatcherNoCheck;
const u8 *dispatcherInEAXNoCheck;
const u8 *breakpointBailout;
};
Core/MIPS/x86/Jit.cpp
+19 -15
View File
@@ -709,9 +709,6 @@ void Jit::WriteExit(u32 destination, int exit_num)
void Jit::WriteExitDestInReg(X64Reg reg)
{
// TODO: Some wasted potential, dispatcher will always read this back into EAX.
MOV(32, M(&mips_->pc), R(reg));
// If we need to verify coreState and rewind, we may not jump yet.
if (js.afterOp & (JitState::AFTER_CORE_STATE | JitState::AFTER_REWIND_PC_BAD_STATE))
{
@@ -723,6 +720,7 @@ void Jit::WriteExitDestInReg(X64Reg reg)
SetJumpTarget(skipCheck);
}
MOV(32, M(&mips_->pc), R(reg));
WriteDowncount();
// Validate the jump to avoid a crash?
@@ -733,27 +731,33 @@ void Jit::WriteExitDestInReg(X64Reg reg)
CMP(32, R(reg), Imm32(PSP_GetUserMemoryEnd()));
FixupBranch tooHigh = J_CC(CC_AE);
// Need to set neg flag again if necessary.
SUB(32, M(&mips_->downcount), Imm32(0));
// Need to set neg flag again.
SUB(32, M(&mips_->downcount), Imm8(0));
if (reg == EAX)
J_CC(CC_NS, asm_.dispatcherInEAXNoCheck, true);
JMP(asm_.dispatcher, true);
SetJumpTarget(tooLow);
SetJumpTarget(tooHigh);
CallProtectedFunction(Memory::GetPointer, R(reg));
CMP(32, R(reg), Imm32(0));
FixupBranch skip = J_CC(CC_NE);
ABI_CallFunctionA(Memory::GetPointer, R(reg));
// TODO: "Ignore" this so other threads can continue?
// If we're ignoring, coreState didn't trip - so trip it now.
if (g_Config.bIgnoreBadMemAccess)
CallProtectedFunction(Core_UpdateState, Imm32(CORE_ERROR));
{
CMP(32, R(EAX), Imm32(0));
FixupBranch skip = J_CC(CC_NE);
ABI_CallFunctionA(&Core_UpdateState, Imm32(CORE_ERROR));
SetJumpTarget(skip);
}
SUB(32, M(&mips_->downcount), Imm32(0));
SUB(32, M(&mips_->downcount), Imm8(0));
JMP(asm_.dispatcherCheckCoreState, true);
SetJumpTarget(skip);
SUB(32, M(&mips_->downcount), Imm32(0));
J_CC(CC_NE, asm_.dispatcher, true);
}
else if (reg == EAX)
{
J_CC(CC_NS, asm_.dispatcherInEAXNoCheck, true);
JMP(asm_.dispatcher, true);
}
else
JMP(asm_.dispatcher, true);