Merge pull request #10088 from unknownbrackets/d3d11-savestate

Avoid clearing shaders on load state

Core/HLE/sceKernelModule.cpp

@@ -301,7 +301,9 @@ public:
 			} else {
 				// Older save state.  Let's still reload, but this may not pick up new flags, etc.
 				bool foundBroken = false;
-				for (auto func : importedFuncs) {
+				auto importedFuncsState = importedFuncs;
+				importedFuncs.clear();
+				for (auto func : importedFuncsState) {
 					if (func.moduleName[KERNELOBJECT_MAX_NAME_LENGTH] != '\0' || !Memory::IsValidAddress(func.stubAddr)) {
 						foundBroken = true;
 					} else {

GPU/D3D11/DrawEngineD3D11.h

@@ -146,6 +146,8 @@ public:
 
 	void Resized() override;
 
+	void ClearInputLayoutMap();
+
 private:
 	void DecodeVerts();
 	void DoFlush();
@@ -154,8 +156,6 @@ private:
 	void ApplyDrawStateLate(bool applyStencilRef, uint8_t stencilRef);
 	void ResetShaderBlending();
 
-	void ClearInputLayoutMap();
-
 	ID3D11InputLayout *SetupDecFmtForDraw(D3D11VertexShader *vshader, const DecVtxFormat &decFmt, u32 pspFmt);
 
 	void MarkUnreliable(VertexArrayInfoD3D11 *vai);

GPU/D3D11/GPU_D3D11.cpp

@@ -278,6 +278,7 @@ void GPU_D3D11::DeviceLost() {
 	// Simply drop all caches and textures.
 	// FBOs appear to survive? Or no?
 	shaderManagerD3D11_->ClearShaders();
+	drawEngine_.ClearInputLayoutMap();
 	textureCacheD3D11_->Clear(false);
 	framebufferManagerD3D11_->DeviceLost();
 }
@@ -742,6 +743,7 @@ void GPU_D3D11::ClearCacheNextFrame() {
 
 void GPU_D3D11::ClearShaderCache() {
 	shaderManagerD3D11_->ClearShaders();
+	drawEngine_.ClearInputLayoutMap();
 }
 
 void GPU_D3D11::DoState(PointerWrap &p) {
@@ -749,13 +751,12 @@ void GPU_D3D11::DoState(PointerWrap &p) {
 
 	// TODO: Some of these things may not be necessary.
 	// None of these are necessary when saving.
-	if (p.mode == p.MODE_READ) {
+	if (p.mode == p.MODE_READ && !PSP_CoreParameter().frozen) {
 		textureCacheD3D11_->Clear(true);
 		drawEngine_.ClearTrackedVertexArrays();
 
 		gstate_c.Dirty(DIRTY_TEXTURE_IMAGE);
 		framebufferManagerD3D11_->DestroyAllFBOs();
-		shaderManagerD3D11_->ClearShaders();
 	}
 }
 

GPU/Directx9/GPU_DX9.cpp

@@ -681,13 +681,12 @@ void GPU_DX9::DoState(PointerWrap &p) {
 
 	// TODO: Some of these things may not be necessary.
 	// None of these are necessary when saving.
-	if (p.mode == p.MODE_READ) {
+	if (p.mode == p.MODE_READ && !PSP_CoreParameter().frozen) {
 		textureCacheDX9_->Clear(true);
 		drawEngine_.ClearTrackedVertexArrays();
 
 		gstate_c.Dirty(DIRTY_TEXTURE_IMAGE);
 		framebufferManagerDX9_->DestroyAllFBOs();
-		shaderManagerDX9_->ClearCache(true);
 	}
 }
 

GPU/GLES/GPU_GLES.cpp

@@ -930,12 +930,10 @@ void GPU_GLES::DoState(PointerWrap &p) {
 	// In Freeze-Frame mode, we don't want to do any of this.
 	if (p.mode == p.MODE_READ && !PSP_CoreParameter().frozen) {
 		textureCacheGL_->Clear(true);
-		depalShaderCache_.Clear();
 		drawEngine_.ClearTrackedVertexArrays();
 
 		gstate_c.Dirty(DIRTY_TEXTURE_IMAGE);
 		framebufferManagerGL_->DestroyAllFBOs();
-		shaderManagerGL_->ClearCache(true);
 	}
 }
 

GPU/Vulkan/GPU_Vulkan.cpp

@@ -897,8 +897,6 @@ void GPU_Vulkan::DoState(PointerWrap &p) {
 
 		gstate_c.Dirty(DIRTY_TEXTURE_IMAGE);
 		framebufferManagerVulkan_->DestroyAllFBOs();
-		shaderManagerVulkan_->ClearShaders();
-		pipelineManager_->Clear();
 	}
 }