preserve-emulation/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2026-07-11 01:24:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #14645 from Dentomologist/msghandler_use_more_suitable_log_levels

Browse Source 
MsgHandler: Use LogLevel matching MsgType for alerts
This commit is contained in:
JosJuice
2026-05-07 11:07:41 +02:00
committed by GitHub
parent 8afc696a1e dfda04c4e4
commit f09a736f14
1 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/Core/Common/MsgHandler.cpp
+15 -2
View File
@@ -73,6 +73,19 @@ const char* GetCaption(MsgType style)
return "Unhandled caption";
}
}
Log::LogLevel GetMessageAlertLogLevel(const MsgType style)
{
switch (style)
{
case MsgType::Critical:
return Log::LogLevel::LERROR;
case MsgType::Warning:
return Log::LogLevel::LWARNING;
default:
return Log::LogLevel::LINFO;
}
}
} // Anonymous namespace
// Select which of these functions that are used for message boxes. If
@@ -108,10 +121,10 @@ static bool ShowMessageAlert(std::string_view text, bool yes_no, Common::Log::Lo
MsgType style, const char* file, int line)
{
const char* caption = GetCaption(style);
const Log::LogLevel level = GetMessageAlertLogLevel(style);
// Directly call GenericLogFmt rather than using the normal log macros so that we can use the
// caller's line file and line number
Common::Log::GenericLogFmt<2>(Common::Log::LogLevel::LERROR, log_type, file, line,
FMT_STRING("{}: {}"), caption, text);
Common::Log::GenericLogFmt<2>(level, log_type, file, line, FMT_STRING("{}: {}"), caption, text);
// Panic alerts.
if (style == MsgType::Warning && s_abort_on_panic_alert)