preserve-emulation/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2026-07-11 01:24:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

HacksWidget: Merge BoundingBox disabled tooltip into BalloonTip

Browse Source 
When a backend doesn't support BoundingBox, show that information in the
BalloonTip instead of spawning a separate tooltip.
This commit is contained in:
Dentomologist
2026-04-13 13:34:38 -07:00
parent b35223e0f3
commit 518f5f458f
2 changed files with 26 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/Core/DolphinQt/Config/Graphics/HacksWidget.cpp
+25 -13
View File
@@ -128,15 +128,8 @@ void HacksWidget::CreateWidgets()
void HacksWidget::OnBackendChanged(const QString& backend_name)
{
const bool bbox = g_backend_info.bSupportsBBox;
m_disable_bounding_box->setEnabled(bbox);
const QString tooltip = tr("%1 doesn't support this feature on your system.")
.arg(tr(backend_name.toStdString().c_str()));
m_disable_bounding_box->setToolTip(!bbox ? tooltip : QString{});
UpdateGPUTextureDecodingEnabled(backend_name);
UpdateBoundingBoxEnabled(backend_name);
}
void HacksWidget::ConnectWidgets()
@@ -216,10 +209,6 @@ void HacksWidget::AddDescriptions()
"Uses a less accurate algorithm to calculate depth values.<br><br>Causes issues in a few "
"games, but can result in a decent speed increase depending on the game and/or "
"GPU.<br><br><dolphin_emphasis>If unsure, leave this checked.</dolphin_emphasis>");
static const char TR_DISABLE_BOUNDINGBOX_DESCRIPTION[] =
QT_TR_NOOP("Disables bounding box emulation.<br><br>This may improve GPU performance "
"significantly, but some games will break.<br><br><dolphin_emphasis>If "
"unsure, leave this checked.</dolphin_emphasis>");
static const char TR_SAVE_TEXTURE_CACHE_TO_STATE_DESCRIPTION[] =
QT_TR_NOOP("Includes the contents of the embedded frame buffer (EFB) and upscaled EFB copies "
"in save states. Fixes missing and/or non-upscaled textures/objects when loading "
@@ -249,7 +238,6 @@ void HacksWidget::AddDescriptions()
m_immediate_xfb->SetDescription(tr(TR_IMMEDIATE_XFB_DESCRIPTION));
m_skip_duplicate_xfbs->SetDescription(tr(TR_SKIP_DUPLICATE_XFBS_DESCRIPTION));
m_fast_depth_calculation->SetDescription(tr(TR_FAST_DEPTH_CALC_DESCRIPTION));
m_disable_bounding_box->SetDescription(tr(TR_DISABLE_BOUNDINGBOX_DESCRIPTION));
m_save_texture_cache_state->SetDescription(tr(TR_SAVE_TEXTURE_CACHE_TO_STATE_DESCRIPTION));
m_vertex_rounding->SetDescription(tr(TR_VERTEX_ROUNDING_DESCRIPTION));
m_vi_skip->SetDescription(tr(TR_VI_SKIP_DESCRIPTION));
@@ -291,6 +279,30 @@ void HacksWidget::UpdateGPUTextureDecodingEnabled(const QString& backend_name)
}
}
void HacksWidget::UpdateBoundingBoxEnabled(const QString& backend_name)
{
static const char TR_DISABLE_BOUNDINGBOX_DESCRIPTION[] =
QT_TR_NOOP("Disables bounding box emulation.<br><br>This may improve GPU performance "
"significantly, but some games will break.<br><br>");
const bool bbox = g_backend_info.bSupportsBBox;
m_disable_bounding_box->setEnabled(bbox);
if (bbox)
{
m_disable_bounding_box->SetDescription(
tr(TR_DISABLE_BOUNDINGBOX_DESCRIPTION) +
tr("<dolphin_emphasis>If unsure, leave this checked.</dolphin_emphasis>"));
}
else
{
m_disable_bounding_box->SetDescription(tr(TR_DISABLE_BOUNDINGBOX_DESCRIPTION) +
tr("<dolphin_emphasis>The %1 backend doesn't support "
"Bounding Box emulation.</dolphin_emphasis>")
.arg(backend_name));
}
}
void HacksWidget::UpdateDeferEFBCopiesEnabled()
{
// We disable the checkbox for defer EFB copies when both EFB and XFB copies to texture are
Source/Core/DolphinQt/Config/Graphics/HacksWidget.h
+1
View File
@@ -28,6 +28,7 @@ private:
void AddDescriptions();
void UpdateGPUTextureDecodingEnabled(const QString& backend_name);
void UpdateBoundingBoxEnabled(const QString& backend_name);
void UpdateDeferEFBCopiesEnabled();
void UpdateSkipPresentingDuplicateFramesEnabled();