preserve-emulation/Vita3K
1
0
Fork 0
mirror of https://github.com/Vita3K/Vita3K.git synced 2026-07-11 01:34:23 +02:00
Code Issues Packages Projects Releases Wiki Activity

modules/SceCommonDialog: Fix 'check_save_file' crash on Linux (#3664)

Browse Source 
- When `iconPath` is empty string, `vfs::read_file` will try to open dictory `ux0` as a binary file to read, which have no effect on Windows but crash on *nix (Linux/Android/...).
- `std::ifstream` can open a directory as file on *nix (but can not on Windows), and after that `std::ifstream::tellg()` return the max value that the return type can represent (strangely not fail), which leads to throwing an exception when buffer is being resized.
This commit is contained in:
双子叶植物
2025-10-30 22:07:05 +08:00
committed by GitHub
parent 0e1f8b385e
commit fd4ebb95b7
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
vita3k/modules/SceCommonDialog/SceCommonDialog.cpp
+2 -2
View File
@@ -825,10 +825,10 @@ static void check_save_file(const uint32_t index, EmuEnvState &emuenv, const cha
auto empty_param = emuenv.common_dialog.savedata.list_empty_param[index];
if (empty_param) {
emuenv.common_dialog.savedata.title[index] = empty_param->title ? empty_param->title.get(emuenv.mem) : emuenv.common_dialog.lang.save_data.save["new_saved_data"];
const auto iconPath = empty_param->iconPath.get(emuenv.mem);
const char *iconPath = empty_param->iconPath.get(emuenv.mem);
SceUChar8 *iconBuf = empty_param->iconBuf.cast<SceUChar8>().get(emuenv.mem);
const auto iconBufSize = empty_param->iconBufSize;
if (iconPath) {
if (iconPath && (std::strlen(iconPath) > 0)) {
auto device = device::get_device(iconPath);
const auto thumbnail_path = translate_path(empty_param->iconPath.get(emuenv.mem), device, emuenv.io.device_paths);
vfs::read_file(VitaIoDevice::ux0, icon_buf_tmp, emuenv.pref_path, thumbnail_path);