preserve-emulation/Vita3K
1
0
Fork 0
mirror of https://github.com/Vita3K/Vita3K.git synced 2026-07-11 01:34:23 +02:00
Code Issues Packages Projects Releases Wiki Activity

cpu: fix CP15 catch-all sharing state across unhandled registers

Browse Source 
Using a single `dummy` field meant any unhandled MCR/MRC would read back
whatever the last unhandled write stored, silently corrupting guest reads.
Return CallbackOrAccessOneWord{} (no-op) instead.
This commit is contained in:
Francisco José García García
2026-04-26 08:56:29 +02:00
parent dfc31d5098
commit ce5b4eb3d1
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
vita3k/cpu/src/dynarmic_cpu.cpp
+3 -5
View File
@@ -35,7 +35,6 @@ class ArmDynarmicCP15 : public Dynarmic::A32::Coprocessor {
uint32_t tpidruro;
uint32_t sctlr;
uint32_t dacr;
uint32_t dummy; // catch-all for unhandled cp15 accesses
public:
using CoprocReg = Dynarmic::A32::CoprocReg;
@@ -43,8 +42,7 @@ public:
explicit ArmDynarmicCP15()
: tpidruro(0)
, sctlr(0)
, dacr(0)
, dummy(0) {
, dacr(0) {
}
~ArmDynarmicCP15() override = default;
@@ -73,7 +71,7 @@ public:
}
LOG_WARN("Unhandled CP15 MCR: two={} opc1={} CRn={} CRm={} opc2={}", two, opc1, (int)CRn, (int)CRm, opc2);
return &dummy;
return CallbackOrAccessOneWord{};
}
CallbackOrAccessTwoWords CompileSendTwoWords(bool two, unsigned opc, CoprocReg CRm) override {
@@ -98,7 +96,7 @@ public:
}
LOG_WARN("Unhandled CP15 MRC: two={} opc1={} CRn={} CRm={} opc2={}", two, opc1, (int)CRn, (int)CRm, opc2);
return &dummy;
return CallbackOrAccessOneWord{};
}
CallbackOrAccessTwoWords CompileGetTwoWords(bool two, unsigned opc, CoprocReg CRm) override {