Commit Graph

1553 Commits

Author SHA1 Message Date
Rosalie Wanders f76e7472fd 3rdParty: revert to using GL_RGBA in mupen64plus-video-GLideN64
For some reason when using GL_RGB, it seems to corrupt memory and cause
a crash, valgrind says the following:

==29295== Invalid write of size 1
==29295==    at 0x20BC10E6: convert_ubyte (format_utils.c:996)
==29295==    by 0x20BDE59B: _mesa_format_convert (format_utils.c:452)
==29295==    by 0x20CA072D: read_rgba_pixels (readpix.c:609)
==29295==    by 0x20CA072D: _mesa_readpixels (readpix.c:923)
==29295==    by 0x20CA6DCA: st_ReadPixels (st_cb_readpixels.c:577)
==29295==    by 0x20CA120B: read_pixels (readpix.c:1218)
==29295==    by 0x20CA120B: _mesa_ReadnPixelsARB (readpix.c:1235)
==29295==    by 0x20CA1564: _mesa_ReadPixels (readpix.c:1250)
==29295==    by 0x5741BCF4: opengl::GlReadPixelsCommand::commandToExecute() (opengl_WrappedFunctions.h:682)
==29295==    by 0x5740EB75: opengl::OpenGlCommand::performCommandSingleThreaded() (opengl_Command.cpp:13)
==29295==    by 0x574117B1: opengl::FunctionWrapper::executeCommand(std::shared_ptr<opengl::OpenGlCommand>) (opengl_Wrapper.cpp:30)
==29295==    by 0x57412548: opengl::FunctionWrapper::wrReadPixels(int, int, int, int, unsigned int, unsigned int, void*) (opengl_Wrapper.cpp:316)
==29295==    by 0x57507C74: DisplayWindowMupen64plus::_readScreen2(void*, int*, int*, int) (mupen64plus_DisplayWindow.cpp:263)
==29295==    by 0x573B69D3: DisplayWindow::readScreen2(void*, int*, int*, int) (DisplayWindow.cpp:209)

valgrind leads me to believe this might be a mesa issue where it writes
out of bounds of the provided buffer, this issue does not occur when
using GL_RGBA, nor does it appear when using an older mesa version in
the AppImage.

Reverting https://github.com/gonetz/GLideN64/pull/2856 fixes the issue.
Fixes https://github.com/Rosalie241/RMG/issues/498
2026-06-14 19:48:39 +02:00
Rosalie Wanders fe67ba053e RMG-Audio: retrieve SDL error when SDL_Init() fails 2026-06-13 19:15:39 +02:00
Rosalie Wanders 02e2518be2 3rdParty: update LZMA SDK to v26.01 2026-06-13 18:55:42 +02:00
Rosalie Wanders 2da7750640 3rdParty: update mupen64plus-core 2026-06-13 18:53:48 +02:00
Rosalie Wanders 2867fc627b RMG-Core: remove Netplay_DispatcherUrl setting 2026-06-13 18:51:09 +02:00
Rosalie Wanders 47df34da6b RMG: remove support for the dispatcher server 2026-06-13 18:51:09 +02:00
Rosalie Wanders 7e4e402f27 RMG-Core: fix minizip include in Archive.cpp 2026-02-24 08:25:28 +01:00
Rosalie Wanders 8ee3410680 3rdParty: fix minizip includes for mupen64plus-core 2026-02-24 08:25:14 +01:00
Rosalie Wanders 0597a71a03 RMG: add plugin settings shortcuts to toolbar 2026-01-13 14:25:45 +01:00
Rosalie Wanders 85265575ea 3rdParty: update SDL_net 2026-01-13 14:08:11 +01:00
Rosalie Wanders 02eef161e7 3rdParty: update SDL_GameControllerDB 2026-01-13 13:40:24 +01:00
Rosalie Wanders 8552e07ed8 3rdParty: update mupen64plus-video-GLideN64 2026-01-13 13:24:13 +01:00
Rosalie Wanders bd3f8f081c RMG-Audio: update copyright year 2026-01-13 12:55:48 +01:00
Rosalie Wanders a9cb954f3a RMG-Input: update copyright year 2026-01-13 12:55:48 +01:00
Rosalie Wanders 5fb1fd22c5 RMG: update copyright year 2026-01-13 12:55:48 +01:00
Rosalie Wanders 95d4b3a85b RMG-Core: update copyright year 2026-01-13 12:55:48 +01:00
Rosalie Wanders 94a7aa76c6 RMG: only change font in LogDialog.cpp on Linux 2026-01-08 03:25:42 +01:00
Rosalie Wanders c49d6e8b6f 3rdParty: apply memory pak patch to mupen64plus-core 2026-01-08 02:54:37 +01:00
Rosalie Wanders cb5910142a Script: use new windeployqt name in BundleDependencies.sh 2026-01-07 02:44:58 +01:00
Rosalie Wanders 3c83f4991f RMG: ensure logDialog is closed in MainWindow::closeEvent() 2025-12-08 17:58:36 +01:00
Rosalie Wanders e57a956c90 3rdParty: fix warnings in mupen64plus-rsp-cxd4 2025-12-07 20:08:32 +01:00
Rosalie Wanders 87541dc239 3rdParty: fix warnings in mupen64plus-input-raphnetraw 2025-12-07 20:01:39 +01:00
Rosalie Wanders 6995cb6ffd 3rdParty: fix warnings in mupen64plus-core 2025-12-07 20:01:39 +01:00
Rosalie Wanders 842bf0f593 RMG: make isWin32Setup variable local to UpdateDialog.cpp 2025-12-07 02:35:05 +01:00
Rosalie Wanders 407fd84cb2 3rdParty: update SDL_net 2025-12-07 02:29:39 +01:00
Rosalie Wanders d23f381dfa RMG: allow different updater filename in UpdateDialog.cpp 2025-12-05 18:05:27 +01:00
Rosalie Wanders e80898ed2d cmake: remove USE_LTO option and disable USE_IPO for 3rdParty projects 2025-12-04 16:36:30 +01:00
Rosalie Wanders 03403653b2 3rdParty: add USE_IPO option to mupen64plus-rsp-parallel 2025-12-04 16:30:00 +01:00
Rosalie Wanders 19631da742 3rdParty: add USE_IPO option to mupen64plus-video-parallel 2025-12-04 16:30:00 +01:00
Rosalie Wanders bd8b51c95b 3rdParty: add USE_IPO option to mupen64plus-video-angrylion-plus 2025-12-04 16:30:00 +01:00
Rosalie Wanders ffd1fca431 3rdParty: add USE_IPO option to mupen64plus-video-GLideN64 2025-12-04 16:30:00 +01:00
Rosalie Wanders b4e6659927 3rdParty: apply shared data patch to mupen64plus-video-GLideN64 2025-12-04 03:21:57 +01:00
Rosalie Wanders ece2af6bfe 3rdParty: don't use GLideN64 translation files 2025-12-04 03:02:59 +01:00
Rosalie Wanders e88050af7b 3rdParty: apply translations UI patch to mupen64plus-video-GLideN64 2025-12-04 03:02:59 +01:00
Rosalie Wanders 5b51437c38 RMG-Core: remove obsolete fmt include 2025-12-04 03:00:13 +01:00
Rosalie Wanders 337e0f2160 RMG: use const reference in AddCheatDialog::setPlainTextEditLines() 2025-12-04 01:40:13 +01:00
Rosalie Wanders 3a2c14a7e7 RMG: improve refresh button state in NetplaySessionBrowserDialog 2025-11-16 17:42:02 +01:00
Rosalie Wanders 0ecf762d30 3rdParty: apply zero init variable patch to mupen64plus-video-GLideN64 2025-11-16 17:03:46 +01:00
Rosalie Wanders 13ab10c262 3rdParty: don't enable asserts when using RelWithDebInfo 2025-11-11 11:55:11 +01:00
Rosalie Wanders 87babd2c41 RMG-Input: allow middle widget in AlignCenterLayout to have 40% of width 2025-11-07 15:44:43 +01:00
Rosalie Wanders ce19f1cc2c RMG-Input: autoConfigButton -> autoConfigureButton 2025-11-07 15:41:01 +01:00
Rosalie Wanders 7985875d7c RMG-Input: track state of children in {disable,enable}AllChildren() 2025-11-07 15:33:57 +01:00
Rosalie Wanders a66fe3bdce RMG: add confirmation checkbox to drag & drop confirmation dialog 2025-11-07 15:21:53 +01:00
Rosalie Wanders 768c195f12 RMG: move 'Ask for confirmation on exit' setting to the emulation tab 2025-11-07 15:21:24 +01:00
Rosalie Wanders c45873464c RMG: improve emulation shutdown handling in MainWindow::closeEvent() 2025-11-07 14:55:53 +01:00
Rosalie Wanders 8b869c63c6 RMG: don't show exit confirmation dialog when launched with --nogui 2025-11-07 14:55:27 +01:00
Rosalie Wanders 3290e83966 RMG: add 'Game Type' to the RomInfoDialog
This also removes the Unknown fallback for 64DD disks,
there was never a PAL 64DD so the NTSC value was correct which I forgot
2025-11-06 21:09:10 +01:00
Rosalie Wanders da0a44d26a RMG: set region of 64DD disks to Unknown in RomInfoDialog 2025-11-06 21:00:11 +01:00
Rosalie Wanders b2716715ec RMG-Input: add custom layout for top row of UI elements and add tooltips 2025-11-06 20:32:33 +01:00
Rosalie Wanders 1547fb6617 RMG-Input: save and restore state of 'Auto-Configure' button 2025-11-06 15:53:59 +01:00