preserve-emulation/RMG
1
0
Fork 0
mirror of https://github.com/Rosalie241/RMG.git synced 2026-07-11 01:24:01 +02:00
Code Issues Packages Projects Releases Wiki Activity

RMG: fix error messages from MainWindow::Init() not showing

Browse Source
This commit is contained in:
Rosalie Wanders
2025-02-27 19:15:05 +01:00
parent e7906c93a7
commit b4a0642122
1 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/RMG/UserInterface/MainWindow.cpp
+11 -4
View File
@@ -72,6 +72,7 @@
#include <RMG-Core/Key.hpp>
using namespace UserInterface;
using namespace Utilities;
MainWindow::MainWindow() : QMainWindow(nullptr)
{
@@ -83,15 +84,21 @@ MainWindow::~MainWindow()
bool MainWindow::Init(QApplication* app, bool showUI, bool launchROM)
{
// we use QtMessageBox::Error() instead of this->showErrorMessage()
// in this function, because our custom function uses
// ->show() instead of ->exec(), causing the user
// to not see the error message because ->show() is non-blocking
// and we return early here for critical errors
if (!CoreInit())
{
this->showErrorMessage("CoreInit() Failed", QString::fromStdString(CoreGetError()));
QtMessageBox::Error(this, "CoreInit() Failed", QString::fromStdString(CoreGetError()));
return false;
}
if (!CoreApplyPluginSettings())
{
this->showErrorMessage("CoreApplyPluginSettings() Failed", QString::fromStdString(CoreGetError()));
QtMessageBox::Error(this, "CoreApplyPluginSettings() Failed", QString::fromStdString(CoreGetError()));
}
this->configureTheme(app);
@@ -119,7 +126,7 @@ bool MainWindow::Init(QApplication* app, bool showUI, bool launchROM)
if (!SetupVidExt(this->emulationThread, this, &this->ui_Widget_OpenGL, &this->ui_Widget_Vulkan))
{
this->showErrorMessage("SetupVidExt() Failed", QString::fromStdString(CoreGetError()));
QtMessageBox::Error(this, "SetupVidExt() Failed", QString::fromStdString(CoreGetError()));
return false;
}
@@ -132,7 +139,7 @@ bool MainWindow::Init(QApplication* app, bool showUI, bool launchROM)
if (!this->coreCallBacks->Init())
{
this->showErrorMessage("CoreCallbacks::Init() Failed", QString::fromStdString(CoreGetError()));
QtMessageBox::Error(this, "CoreCallbacks::Init() Failed", QString::fromStdString(CoreGetError()));
return false;
}