Thomas Huth
8720daad47
hw/arm/integratorcp: Don't do things that could be fatal in the instance_init
An instance_init function must not fail - and might be called multiple times,
e.g. during device introspection with the 'device-list-properties' QMP
command. Since the integratorcm device ignores this rule, QEMU currently
aborts in this case (though it really should not):
echo "{'execute':'qmp_capabilities'}"\
"{'execute':'device-list-properties',"\
"'arguments':{'typename':'integrator_core'}}" \
| arm-softmmu/qemu-system-arm -M integratorcp,accel=qtest -qmp stdio
{"QMP": {"version": {"qemu": {"micro": 91, "minor": 11, "major": 2},
"package": "build-all"}, "capabilities": []}}
{"return": {}}
RAMBlock "integrator.flash" already registered, abort!
Aborted (core dumped)
Move the problematic code to the realize() function instead to fix this
problem.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-id: 1522906473-11252-1-git-send-email-thuth@redhat.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
2018-04-10 13:02:24 +01:00
..
2018-03-02 11:03:45 +00:00
2018-02-15 18:29:36 +00:00
2017-11-20 13:47:49 +00:00
2018-02-13 16:15:08 +01:00
2018-03-23 18:26:45 +00:00
2018-04-10 13:02:24 +01:00
2017-09-19 09:09:32 -03:00
2017-09-07 13:54:54 +01:00
2017-09-07 13:54:54 +01:00
2017-11-13 13:55:27 +00:00
2018-02-13 16:15:08 +01:00
2018-02-13 16:15:09 +01:00
2018-03-09 17:09:43 +00:00
2017-11-07 13:03:51 +00:00
2017-11-07 13:03:51 +00:00
2018-02-06 18:26:42 +01:00
2018-03-12 16:12:46 +01:00
2017-09-07 13:54:54 +01:00
2018-04-10 13:02:24 +01:00
2018-03-02 11:03:45 +00:00
2017-09-07 13:54:54 +01:00
2018-02-06 18:26:42 +01:00
2018-03-09 17:09:44 +00:00
2018-03-09 17:09:43 +00:00
2018-03-02 11:03:45 +00:00
2017-09-19 09:09:32 -03:00
2018-03-12 16:12:46 +01:00
2017-09-21 16:36:56 +01:00
2018-02-06 18:26:42 +01:00
2017-09-19 09:09:32 -03:00
2018-01-22 09:46:18 +01:00
2018-02-06 18:26:42 +01:00
2018-02-06 18:26:42 +01:00
2018-02-06 18:26:42 +01:00
2018-01-22 09:46:18 +01:00
2018-01-22 09:46:18 +01:00
2018-01-22 09:46:18 +01:00
2018-02-06 18:26:42 +01:00
2018-03-23 18:26:45 +00:00
2018-03-12 16:12:46 +01:00
2017-09-07 13:54:54 +01:00
2018-02-02 08:19:25 +01:00
2017-09-19 09:09:32 -03:00
2017-09-19 09:09:32 -03:00
2017-09-27 11:35:59 +01:00
2018-03-12 16:12:46 +01:00
2017-09-19 09:09:32 -03:00
2018-03-01 11:13:36 +00:00
2018-03-13 23:09:50 +02:00
2018-03-23 18:26:46 +00:00
2018-02-13 16:15:08 +01:00
2017-12-13 17:59:22 +00:00
2018-03-09 17:09:43 +00:00
2018-02-06 18:26:42 +01:00