Paolo Bonzini 993ed89f35 aio-posix: ensure poll mode is left when aio_notify is called ...

With aio=thread, adaptive polling makes latency worse rather than
better, because it delays the execution of the ThreadPool's
completion bottom half.

event_notifier_poll() does run while polling, detecting that
a bottom half was scheduled by a worker thread, but because
ctx->notifier is explicitly ignored in run_poll_handlers_once(),
scheduling the BH does not count as making progress and
run_poll_handlers() keeps running.  Fix this by recomputing
the deadline after *timeout could have changed.

With this change, ThreadPool still cannot participate in polling
but at least it does not suffer from extra latency.

Reported-by: Sergio Lopez <slp@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 20190409122823.12416-1-pbonzini@redhat.com
Cc: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-block@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <1553692145-86728-1-git-send-email-pbonzini@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20190409122823.12416-1-pbonzini@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

2019-05-10 10:53:21 +01:00

..

aio-posix.c

aio-posix: ensure poll mode is left when aio_notify is called

2019-05-10 10:53:21 +01:00

aio-wait.c

block: Use a single global AioWait

2018-09-25 15:50:15 +02:00

aio-win32.c

aio-posix: Fix concurrent aio_poll/set_fd_handler.

2019-01-14 14:09:41 +00:00

aiocb.c

…

async.c

util/async: use qemu_aio_coroutine_enter in co_schedule_bh_cb

2018-09-25 15:50:15 +02:00

atomic64.c

util: add atomic64

2018-10-02 18:47:55 +02:00

base64.c

…

bitmap.c

bitmap: provide to_le/from_le helpers

2017-09-22 14:11:25 +02:00

bitops.c

avoid TABs in files that only contain a few

2019-01-11 15:46:56 +01:00

buffer.c

…

bufferiszero.c

util: Introduce include/qemu/cpuid.h

2017-07-24 12:42:55 +01:00

cacheinfo.c

util/cacheinfo: Use uint64_t on LLP64 model to satisfy Windows ARM64

2019-05-07 12:55:03 +01:00

compatfd.c

…

coroutine-sigaltstack.c

…

coroutine-ucontext.c

build: try improve handling of clang warnings

2018-03-12 08:59:03 +01:00

coroutine-win32.c

…

crc32c.c

…

cutils.c

cutils: Fix size_to_str() on 32-bit platforms

2019-04-30 15:29:00 +02:00

drm.c

util: promote qemu_egl_rendernode_open() to libqemuutil

2018-08-27 10:51:44 +02:00

envlist.c

…

error.c

util/error: do not free error on error_abort

2019-04-17 19:15:39 +02:00

event_notifier-posix.c

Revert "qemu: add a cleanup callback function to EventNotifier"

2018-01-24 19:20:19 +02:00

event_notifier-win32.c

Revert "qemu: add a cleanup callback function to EventNotifier"

2018-01-24 19:20:19 +02:00

fifo8.c

…

filemonitor-inotify.c

filemon: fix watch IDs to avoid potential wraparound issues

2019-04-02 13:52:02 +01:00

filemonitor-stub.c

filemon: fix watch IDs to avoid potential wraparound issues

2019-04-02 13:52:02 +01:00

getauxval.c

…

hbitmap.c

Revert "hbitmap: Add @advance param to hbitmap_iter_next()"

2019-01-15 18:26:50 -05:00

hexdump.c

…

host-utils.c

…

id.c

…

iohandler.c

…

iov.c

…

iova-tree.c

util: remove redundant include of glib.h and add osdep.h

2018-06-29 12:22:28 +01:00

keyval.c

qobject: Replace qobject_incref/QINCREF qobject_decref/QDECREF

2018-05-04 08:27:53 +02:00

lockcnt.c

…

log.c

tcg: Optionally log FPU state in TCG -d cpu logging

2018-05-15 14:58:44 +01:00

main-loop.c

slirp: move sources to src/ subdirectory

2019-03-07 12:46:31 +01:00

Makefile.objs

qemu-print: New qemu_printf(), qemu_vprintf() etc.

2019-04-18 22:18:59 +02:00

memfd.c

memfd: improve error messages

2019-03-11 17:17:01 -03:00

mmap-alloc.c

util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2019-04-25 14:17:36 -03:00

module.c

module: Use QEMU_MODULE_DIR as a search path

2018-08-23 18:46:25 +02:00

notify.c

…

osdep.c

slirp: prefer c99 types over BSD kind

2019-02-07 15:49:08 +02:00

oslib-posix.c

util/mmap-alloc: Add a 'is_pmem' parameter to qemu_ram_mmap

2019-04-25 14:17:36 -03:00

oslib-win32.c

hostmem-file: reject invalid pmem file sizes

2019-03-11 10:44:19 -03:00

pagesize.c

util: move qemu_real_host_page_size/mask to osdep.h

2017-10-10 09:45:00 -07:00

path.c

…

qdist.c

…

qemu-config.c

block: Add block-specific QDict header

2018-06-15 14:49:44 +02:00

qemu-coroutine-io.c

…

qemu-coroutine-lock.c

coroutine: avoid co_queue_wakeup recursion

2018-03-27 13:05:28 +01:00

qemu-coroutine-sleep.c

qemu-coroutine-sleep: drop CoSleepCB

2019-01-24 10:05:16 +00:00

qemu-coroutine.c

block: Add missing locking in bdrv_co_drain_bh_cb()

2018-09-25 15:50:15 +02:00

qemu-error.c

monitor error: Make printf()-like functions return a value

2019-04-18 22:18:59 +02:00

qemu-openpty.c

…

qemu-option.c

qemu/queue.h: simplify reverse access to QTAILQ

2019-01-11 15:46:55 +01:00

qemu-print.c

qemu-print: New qemu_fprintf(), qemu_vfprintf()

2019-04-18 22:18:59 +02:00

qemu-progress.c

…

qemu-sockets.c

sockets: avoid string truncation warnings when copying UNIX path

2019-05-03 13:03:04 +02:00

qemu-thread-common.h

Clean up includes

2018-12-20 10:29:08 +01:00

qemu-thread-posix.c

qemu-thread: Don't block SEGV, ILL and FPE

2019-01-08 12:34:46 +00:00

qemu-thread-win32.c

build-sys: build with Vista API by default

2019-01-11 13:57:25 +01:00

qemu-timer-common.c

…

qemu-timer.c

qemu-timer: avoid checkpoints for virtual clock timers in external subsystems

2018-10-19 13:44:03 +02:00

qht.c

qht: constify arguments to some internal functions

2018-09-26 08:55:54 -07:00

qsp.c

qsp: Simplify how qsp_report() prints

2019-04-18 22:18:59 +02:00

range.c

Don't talk about the LGPL if the file is licensed under the GPL

2019-01-30 10:51:20 +01:00

rcu.c

membarrier: introduce qemu/sys_membarrier.h

2018-03-12 16:12:47 +01:00

readline.c

util/readline: Add braces to fix checkpatch errors

2019-05-10 10:53:21 +01:00

stats64.c

util/stats64: Fix min/max comparisons

2017-11-15 09:34:51 +01:00

sys_membarrier.c

sys_membarrier: fix up include directives

2018-04-05 14:37:38 +02:00

systemd.c

…

thread-pool.c

…

throttle.c

throttle: Assert that bkt->max is valid in throttle_compute_wait()

2017-09-26 14:46:23 +02:00

timed-average.c

…

trace-events

filemon: fix watch IDs to avoid potential wraparound issues

2019-04-02 13:52:02 +01:00

unicode.c

json: Reject invalid UTF-8 sequences

2018-08-24 20:26:37 +02:00

uri.c

cutils: Provide strchrnul

2018-06-29 12:32:10 +02:00

uuid.c

uuid: Make qemu_uuid_bswap() take and return a QemuUUID

2019-02-01 13:46:45 +01:00

vfio-helpers.c

exec: Change RAMBlockIterFunc definition

2019-03-06 10:49:17 +00:00