Eric Blake and Markus Armbruster
08fba7ac9b
shutdown: Expose bool cause in SHUTDOWN and RESET events
...
Libvirt would like to be able to distinguish between a SHUTDOWN
event triggered solely by guest request and one triggered by a
SIGTERM or other action on the host. While qemu_kill_report() was
already able to give different output to stderr based on whether a
shutdown was triggered by a host signal (but NOT by a host UI event,
such as clicking the X on the window), that information was then
lost to management. The previous patches improved things to use an
enum throughout all callsites, so now we have something ready to
expose through QMP.
Note that for now, the decision was to expose ONLY a boolean,
rather than promoting ShutdownCause to a QAPI enum; this is because
libvirt has not expressed an interest in anything finer-grained.
We can still add additional details, in a backwards-compatible
manner, if a need later arises (if the addition happens before 2.10,
we can replace the bool with an enum; otherwise, the enum will have
to be in addition to the bool); this patch merely adds a helper
shutdown_caused_by_guest() to map the internal enum into the
external boolean.
Update expected iotest outputs to match the new data (complete
coverage of the affected tests is obtained by -raw, -qcow2, and -nbd).
Here is output from 'virsh qemu-monitor-event --loop' with the
patch installed:
event SHUTDOWN at 1492639680.731251 for domain fedora_13: {"guest":true}
event STOP at 1492639680.732116 for domain fedora_13: <null>
event SHUTDOWN at 1492639680.732830 for domain fedora_13: {"guest":false}
Note that libvirt runs qemu with -no-shutdown: the first SHUTDOWN event
was triggered by an action I took directly in the guest (shutdown -h),
at which point qemu stops the vcpus and waits for libvirt to do any
final cleanups; the second SHUTDOWN event is the result of libvirt
sending SIGTERM now that it has completed cleanup. Libvirt is already
smart enough to only feed the first qemu SHUTDOWN event to the end user
(remember, virsh qemu-monitor-event is a low-level debugging interface
that is explicitly unsupported by libvirt, so it sees things that normal
end users do not); changing qemu to emit SHUTDOWN only once is outside
the scope of this series.
See also https://bugzilla.redhat.com/1384007
Signed-off-by: Eric Blake <eblake@redhat.com >
Message-Id: <20170515214114.15442-6-eblake@redhat.com >
Reviewed-by: Markus Armbruster <armbru@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-05-23 13:28:17 +02:00
Markus Armbruster
1d8bda128d
qapi: The #optional tag is redundant, drop
...
We traditionally mark optional members #optional in the doc comment.
Before commit 3313b61 , this was entirely manual.
Commit 3313b61 added some automation because its qapi2texi.py relied
on #optional to determine whether a member is optional. This is no
longer the case since the previous commit: the only thing qapi2texi.py
still does with #optional is stripping it out. We still reject bogus
qapi-schema.json and six places for qga/qapi-schema.json.
Thus, you can't actually rely on #optional to see whether something is
optional. Yet we still make people add it manually. That's just
busy-work.
Drop the code to check, fix up and strip out #optional, along with all
instances of #optional. To keep it out, add code to reject it, to be
dropped again once the dust settles.
No change to generated documentation.
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Reviewed-by: Eric Blake <eblake@redhat.com >
Message-Id: <1489582656-31133-18-git-send-email-armbru@redhat.com >
2017-03-16 07:13:02 +01:00
Anton Nefedov and Paolo Bonzini
11953be792
qmp-events: fix GUEST_PANICKED description formatting
...
Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com >
Signed-off-by: Denis V. Lunev <den@openvz.org >
CC: Paolo Bonzini <pbonzini@redhat.com >
CC: Eric Blake <eblake@redhat.com >
Message-Id: <1487614915-18710-4-git-send-email-den@openvz.org >
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com >
2017-03-03 16:40:03 +01:00
Anton Nefedov and Paolo Bonzini
c86f106b85
report guest crash information in GUEST_PANICKED event
...
it's not very convenient to use the crash-information property interface,
so provide a CPU class callback to get the guest crash information, and pass
that information in the event
Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com >
Signed-off-by: Denis V. Lunev <den@openvz.org >
Message-Id: <1487053524-18674-3-git-send-email-den@openvz.org >
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com >
2017-02-16 15:30:49 +01:00
Stefan Weil and Markus Armbruster
5d0c7f4f9e
qapi: Remove unwanted commas after #optional keyword
...
We don't want that commas to be part of the generated documentation,
so remove them.
Signed-off-by: Stefan Weil <sw@weilnetz.de >
Message-Id: <20170122145407.27476-1-sw@weilnetz.de >
Reviewed-by: Markus Armbruster <armbru@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-27 08:23:06 +01:00
Marc-André Lureau and Markus Armbruster
231aaf3a82
qmp-events: move 'MIGRATION_PASS' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:50 +01:00
Marc-André Lureau and Markus Armbruster
a102a4acad
qmp-events: move 'DUMP_COMPLETED' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:50 +01:00
Marc-André Lureau and Markus Armbruster
e602f0b4e7
qmp-events: move 'MEM_UNPLUG_ERROR' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:50 +01:00
Marc-André Lureau and Markus Armbruster
14df1ea168
qmp-events: move 'VSERPORT_CHANGE' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:50 +01:00
Marc-André Lureau and Markus Armbruster
2ee7fea7ce
qmp-events: move 'QUORUM_REPORT_BAD' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:50 +01:00
Marc-André Lureau and Markus Armbruster
9dcbe9a7e8
qmp-events: move 'QUORUM_FAILURE' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:50 +01:00
Marc-André Lureau and Markus Armbruster
449dbec15a
qmp-events: move 'GUEST_PANICKED' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
Marc-André Lureau and Markus Armbruster
a030dc0029
qmp-events: move 'BALLOON_CHANGE' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
Marc-André Lureau and Markus Armbruster
622b3a6a51
qmp-events: move 'ACPI_DEVICE_OST' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
Marc-André Lureau and Markus Armbruster
bce911ce26
qmp-events: move 'MIGRATION' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
Marc-André Lureau and Markus Armbruster
e6bcb080f9
qmp-events: move 'SPICE_MIGRATE_COMPLETED' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
Marc-André Lureau and Markus Armbruster
93ab0fc3c3
qmp-events: move 'SPICE_DISCONNECTED' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
Marc-André Lureau and Markus Armbruster
da08e2a5a2
qmp-events: move 'SPICE_INITIALIZED' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
Marc-André Lureau and Markus Armbruster
5db6670347
qmp-events: move 'SPICE_CONNECTED' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
Marc-André Lureau and Markus Armbruster
659789ba36
qmp-events: move 'VNC_DISCONNECTED' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
Marc-André Lureau and Markus Armbruster
99ab2471a4
qmp-events: move 'VNC_INITIALIZED' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
Marc-André Lureau and Markus Armbruster
f46052fd13
qmp-events: move 'VNC_CONNECTED' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
Marc-André Lureau and Markus Armbruster
5dbdcf4324
qmp-events: move 'NIC_RX_FILTER_CHANGED' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
Marc-André Lureau and Markus Armbruster
cdc94a1b3e
qmp-events: move 'DEVICE_DELETED' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
Marc-André Lureau and Markus Armbruster
9ba5cec9dd
qmp-events: move 'WATCHDOG' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
Marc-André Lureau and Markus Armbruster
73c41bfd31
qmp-events: move 'RTC_CHANGE' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
Marc-André Lureau and Markus Armbruster
aa496f9812
qmp-events: move 'WAKEUP' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
Marc-André Lureau and Markus Armbruster
4de62c38a5
qmp-events: move 'SUSPEND_DISK' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
Marc-André Lureau and Markus Armbruster
6f3cc5406b
qmp-events: move 'SUSPEND' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:49 +01:00
Marc-André Lureau and Markus Armbruster
a2235a0499
qmp-events: move 'RESUME' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:48 +01:00
Marc-André Lureau and Markus Armbruster
138c454c0f
qmp-events: move 'STOP' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:48 +01:00
Marc-André Lureau and Markus Armbruster
7a2aae7a36
qmp-events: move 'RESET' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:48 +01:00
Marc-André Lureau and Markus Armbruster
189d43bed6
qmp-events: move 'POWERDOWN' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:48 +01:00
Marc-André Lureau and Markus Armbruster
12defe50f8
qmp-events: move 'SHUTDOWN' doc to schema
...
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:19:48 +01:00
Marc-André Lureau and Markus Armbruster
d3a48372a4
qapi: add some sections in docs
...
Add some more section titles to organize the documentation we're going
to generate.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Reviewed-by: Markus Armbruster <armbru@redhat.com >
Message-Id: <20170113144135.5150-10-marcandre.lureau@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:15:25 +01:00
Marc-André Lureau and Markus Armbruster
5807ff88b1
qapi: Reorder doc comments for future doc generator
...
The doc generator we're going to add expects a fairly rigid doc
comment structure. Reorder / rephrase some doc comments to please it.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Message-Id: <20170113144135.5150-8-marcandre.lureau@redhat.com >
Reviewed-by: Markus Armbruster <armbru@redhat.com >
[Commit message rewritten]
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2017-01-16 09:15:25 +01:00
Marc-André Lureau and Markus Armbruster
5072f7b38b
qapi: add missing colon-ending for section name
...
The documentation parser we are going to add expects a section name to
end with ':', otherwise the comment is treated as free-form text body.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Message-Id: <20161117155504.21843-9-marcandre.lureau@redhat.com >
Reviewed-by: Markus Armbruster <armbru@redhat.com >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
2016-12-05 17:41:38 +01:00
Changlong Xie and Kevin Wolf
0ae053b7e1
qmp event: Refactor QUORUM_REPORT_BAD
...
Introduce QuorumOpType, and make QUORUM_REPORT_BAD compatible
with it.
Cc: Dr. David Alan Gilbert <dgilbert@redhat.com >
Cc: Wen Congyang <wency@cn.fujitsu.com >
Signed-off-by: Wen Congyang <wency@cn.fujitsu.com >
Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com >
Reviewed-by: Alberto Garcia <berto@igalia.com >
Signed-off-by: Kevin Wolf <kwolf@redhat.com >
2016-03-14 16:46:43 +01:00
Peter Xu and Paolo Bonzini
d42a0d1484
dump-guest-memory: add qmp event DUMP_COMPLETED
...
One new QMP event DUMP_COMPLETED is added. When a dump finishes, one
DUMP_COMPLETED event will occur to notify the user.
Signed-off-by: Peter Xu <peterx@redhat.com >
Reviewed-by: Fam Zheng <famz@redhat.com >
Message-Id: <1455772616-8668-12-git-send-email-peterx@redhat.com >
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com >
2016-02-22 18:40:29 +01:00
Dr. David Alan Gilbert and Amit Shah
4addcd4fdc
Migration: Emit event at start of pass
...
Emit an event each time we sync the dirty bitmap on the source;
this helps libvirt use postcopy by giving it a kick when it
might be a good idea to start the postcopy.
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com >
Reviewed-by: Juan Quintela <quintela@redhat.com >
Reviewed-by: Eric Blake <eblake@redhat.com >
Reviewed-by: Amit Shah <amit.shah@redhat.com >
Message-Id: <1450266458-3178-5-git-send-email-dgilbert@redhat.com >
Signed-off-by: Amit Shah <amit.shah@redhat.com >
2016-01-13 16:02:13 +05:30
Juan Quintela
598cd2bda0
migration: create migration event
...
We have one argument that tells us what event has happened.
Signed-off-by: Juan Quintela <quintela@redhat.com >
Reviewed-by: Eric Blake <eblake@redhat.com >
2015-07-07 14:54:55 +02:00
Zhu Guihua and Michael S. Tsirkin
bc09e06113
qmp-event: add event notification for memory hot unplug error
...
When memory hot unplug fails, this patch adds support to send
QMP event to notify mgmt about this failure.
Reviewed-by: Igor Mammedov <imammedo@redhat.com >
Signed-off-by: Zhu Guihua <zhugh.fnst@cn.fujitsu.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2015-04-27 21:09:07 +02:00
Benoît Canet and Stefan Hajnoczi
4e855baabf
qapi: Change back sector-count to sectors-count in quorum QAPI events.
...
fe069d9d had aligned code and documentation while dropping the s from the
actual JSON output. Fix that.
This also fix test/qemu-iotest/081 since the missing s was causing a permutation.
Signed-off-by: Benoit Canet <benoit@irqsave.net >
Reviewed-by: Eric Blake <eblake@redhat.com >
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com >
2014-07-01 10:15:34 +02:00
Laszlo Ersek and Luiz Capitulino
e2ae6159de
virtio-serial: report frontend connection state via monitor
...
Libvirt wants to know about the guest-side connection state of some
virtio-serial ports (in particular the one(s) assigned to guest agent(s)).
Report such states with a new monitor event.
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1080376
Signed-off-by: Laszlo Ersek <lersek@redhat.com >
Reviewed-by: Eric Blake <eblake@redhat.com >
Reviewed-by: Amit Shah <amit.shah@redhat.com >
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com >
2014-06-27 09:33:27 -04:00
Wenchao Xia and Luiz Capitulino
2f44a08b3e
qapi event: clean up in callers
...
This patch improves docs and address small issues in event
callers.
Signed-off-by: Wenchao Xia <wenchaoqemu@gmail.com >
Reviewed-by: Eric Blake <eblake@redhat.com >
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com >
2014-06-27 09:27:56 -04:00
Wenchao Xia and Luiz Capitulino
82d72d9d23
qapi: move event defines
...
Signed-off-by: Wenchao Xia <wenchaoqemu@gmail.com >
Reviewed-by: Eric Blake <eblake@redhat.com >
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com >
2014-06-27 09:27:55 -04:00