Richard Henderson
d5f55fff34
util/log: Rename QemuLogFile to RCUCloseFILE
...
s/QemuLogFile/RCUCloseFILE/
s/qemu_logfile_free/rcu_close_file/
Emphasize that this is only a carrier for passing a pointer
to call_rcu for closing, and not the real logfile.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-38-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
92b24cb77f
util/log: Combine two logfile closes
...
Merge the close from the changed_name block with the close
from the !need_to_open_file block.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-37-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
beab3447db
util/log: Hoist the eval of is_daemonized in qemu_set_log_internal
...
Only call is_daemonized once.
We require the result on all paths after this point.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-36-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
702979f736
util/log: Rename qemu_logfile_mutex to global_mutex
...
Rename to emphasize this covers the file-scope global variables.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-35-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
8ae58d6009
util/log: Rename qemu_logfile to global_file
...
Rename to emphasize this is the file-scope global variable.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-34-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
4226646481
util/log: Rename logfilename to global_filename
...
Rename to emphasize this is the file-scope global variable.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-33-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
ec0d1849d9
util/log: Remove qemu_log_close
...
The only real use is in cpu_abort, where we have just
flushed the file via qemu_log_unlock, and are just about
to force-crash the application via abort. We do not
really need to close the FILE before the abort.
The two uses in test-logging.c can be handled with
qemu_set_log_filename_flags.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-32-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
b2528af10a
softmmu: Use qemu_set_log_filename_flags
...
Perform all logfile setup at startup in one step.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-31-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
b410253f9f
linux-user: Use qemu_set_log_filename_flags
...
Perform all logfile setup in one step.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-30-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
905c78fe60
bsd-user: Use qemu_set_log_filename_flags
...
Perform all logfile setup in one step.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-29-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
144539d360
util/log: Introduce qemu_set_log_filename_flags
...
Provide a function to set both filename and flags at
the same time. This is the common case at startup.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-28-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
6391c772d7
sysemu/os-win32: Test for and use _lock_file/_unlock_file
...
The bug referenced in os-win32.h was fixed in mingw-w64 v6.
According to repology, version 5 used by ubuntu 18, which is
not yet out of support, so provide a meson link test for it.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-27-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
7fc493f8bd
include/qemu/log: Move entire implementation out-of-line
...
Move QemuLogFile, qemu_logfile, and all inline functions into qemu/log.c.
No need to expose these implementation details in the api.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-26-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
bf619eae2e
include/exec/log: Do not reference QemuLogFile directly
...
Use qemu_log_trylock/unlock instead of the raw rcu_read.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Message-Id: <20220417183019.755276-25-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
09a65bec38
tests/unit: Do not reference QemuLogFile directly
...
Use qemu_log_lock/unlock instead of the raw rcu_read.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-24-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
93756fdcf6
linux-user: Expand log_page_dump inline
...
We have extra stuff to log at the same time.
Hoist the qemu_log_lock/unlock to the caller and use fprintf.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-23-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
43b761618d
bsd-user: Expand log_page_dump inline
...
We have extra stuff to log at the same time.
Hoist the qemu_log_trylock/unlock to the caller and use fprintf.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-22-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
fb6efecf54
util/log: Drop call to setvbuf
...
Now that the log buffer is flushed after every qemu_log_unlock,
which includes every call to qemu_log, we do not need to force
line buffering (or unbuffering for windows). Block buffer the
entire loggable unit.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-21-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
90f37362d7
util/log: Remove qemu_log_flush
...
All uses flush output immediately before or after qemu_log_unlock.
Instead of a separate call, move the flush into qemu_log_unlock.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-20-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
27ea81337f
util/log: Mark qemu_log_trylock as G_GNUC_WARN_UNUSED_RESULT
...
Now that all uses have been updated, consider a missing
test of the result of qemu_log_trylock a bug and Werror.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-19-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
3c06a41746
util/log: Drop return value from qemu_log
...
The only user of this feature, tcg_dump_ops, has been
converted to use fprintf directly.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-18-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
095e9855b7
util/log: Use qemu_log_trylock/unlock in qemu_log
...
Avoid using QemuLogFile and RCU directly.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-17-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
9aee8f2c29
target/nios2: Remove log_cpu_state from reset
...
This is redundant with the logging done in cpu_common_reset.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-16-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
c769fbd7de
accel/tcg: Use cpu_dump_state between qemu_log_trylock/unlock
...
Inside log_cpu_state, we perform qemu_log_trylock/unlock, which need
not be done if we have already performed the lock beforehand.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-15-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
7ac5c0b7ba
exec/log: Remove log_disas and log_target_disas
...
These functions are no longer used.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-14-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
8eb806a763
exec/translator: Pass the locked filepointer to disas_log hook
...
We have fetched and locked the logfile in translator_loop.
Pass the filepointer down to the disas_log hook so that it
need not be fetched and locked again.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-13-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
b7a83ff8df
tcg: Pass the locked filepointer to tcg_dump_ops
...
We have already looked up and locked the filepointer.
Use fprintf instead of qemu_log directly for output
in and around tcg_dump_ops.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-12-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
3fb659605f
util/log: Remove qemu_log_vprintf
...
This function is no longer used.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-11-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
78b548583e
*: Use fprintf between qemu_log_trylock/unlock
...
Inside qemu_log, we perform qemu_log_trylock/unlock, which need
not be done if we have already performed the lock beforehand.
Always check the result of qemu_log_trylock -- only checking
qemu_loglevel_mask races with the acquisition of the lock on
the logfile.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-10-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
6fef222971
hw/xen: Split out xen_pv_output_msg
...
Do not replicate the individual logging statements.
Use qemu_log_trylock/unlock instead of qemu_log directly.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-9-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
c60f599bcb
util/log: Rename qemu_log_lock to qemu_log_trylock
...
This function can fail, which makes it more like ftrylockfile
or pthread_mutex_trylock than flockfile or pthread_mutex_lock,
so rename it.
To closer match the other trylock functions, release rcu_read_lock
along the failure path, so that qemu_log_unlock need not be called
on failure.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-8-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
c59fe6e536
util/log: Move qemu_log_lock, qemu_log_unlock out of line
...
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-7-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
229ef2eb44
os-posix: Use qemu_log_enabled
...
Do not reference qemu_logfile directly;
use the predicate provided by qemu/log.h.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-6-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
c5955f4ff4
util/log: Pass Error pointer to qemu_set_log
...
Do not force exit within qemu_set_log; return bool and pass
an Error value back up the stack as per usual.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-5-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
e2c7c6a454
util/log: Return bool from qemu_set_log_filename
...
Per the recommendations in qapi/error.h, return false on failure.
Use the return value in the monitor, the only place we aren't
already passing error_fatal or error_abort.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-4-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
eecb0c4e11
target/hexagon: Remove qemu_set_log in hexagon_translate_init
...
This code appears to be trying to make sure there is a logfile.
But that's already true -- the logfile will either be set by -D,
or will be stderr. In either case, not appropriate here.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-3-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
54ee5b3da0
util/log: Drop manual log buffering
...
This buffering was introduced during the Paleozoic: 9fa3e85353 .
There has never been an explanation as to why we may not allow
glibc to allocate the file buffer itself. We certainly have
many other uses of mmap and malloc during user-only startup,
so presumably whatever the issue was, it has been fixed during
the preceeding 18 years.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org >
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220417183019.755276-2-richard.henderson@linaro.org >
2022-04-20 10:51:11 -07:00
Richard Henderson
40a4b96eb0
Merge tag 'pull-block-2022-04-20' of https://gitlab.com/hreitz/qemu into staging
...
Block patches:
- Some changes for qcow2's refcount repair algorithm to make it work for
qcow2 images stored on block devices
- Skip test cases that require zstd when support for it is missing
- Some refactoring in the iotests' meson.build
# -----BEGIN PGP SIGNATURE-----
#
# iQJGBAABCAAwFiEEy2LXoO44KeRfAE00ofpA0JgBnN8FAmJf/asSHGhyZWl0ekBy
# ZWRoYXQuY29tAAoJEKH6QNCYAZzfYXUQAKQv5qKQBjU4MTwlS8A4h6B6OJgC1Sik
# 9BB7LO/QFjuuF4vNKpcUlf6i0epxPP8B5pmCjaAolMh6u6wZwL7hHq+SOYXvejTo
# vINW+r097U0qYPkSV+cS6tbW92rYJDD7VxF+34udiWXGjozsBTw/k9DfJaa9Ht66
# 2dw3AxUa4lxN1/ejFzDLx3DNaff+HctLhgVpHeBb0eN2zr2Ug5+ZFgMoiWwU6r6J
# EzTORLAzATerlQVYUkhh4Y/UdVLLw1SzTWOQv5b/NqvaLfKmYsQobSfjC2ajO8XJ
# P2REigcOAij5uWVRf4EY7xoqmADP8pXxuOTzw0hyGNLOLNcXoFbfW45WSPoY+YgH
# EH1TtC4vMsg/MlO/A3PJr9v+SNqxz32cul3MVrY3PuG4Dzz0riy9GhtFUU37igbj
# mR6pP3nSa/f2X4+9B6/UrPjLzusRvc8bvzYqVEnSLABav11npphkYaR9QT1fQUVD
# Zw26igXtmLKUcfop/EqShbhblk0ZLYDTj/Lx7X+thC9OCrK1QgF6qAsIUqiS1iHz
# vwdktRTCofo4ZIT/OCz5QeriJqDz0B7VJ8/4i/uvm2eq8BUsn2mJuyAGD2XtaONV
# rmASrV9VbajdxX5VptjKOOHG6aHtqQlKbyBFog8I4nqVFdjdSMalb++gBMCrPu1A
# 1iZPsOOyz/8+
# =BF0c
# -----END PGP SIGNATURE-----
# gpg: Signature made Wed 20 Apr 2022 05:33:47 AM PDT
# gpg: using RSA key CB62D7A0EE3829E45F004D34A1FA40D098019CDF
# gpg: issuer "hreitz@redhat.com "
# gpg: Good signature from "Hanna Reitz <hreitz@redhat.com >" [undefined]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg: There is no indication that the signature belongs to the owner.
# Primary key fingerprint: CB62 D7A0 EE38 29E4 5F00 4D34 A1FA 40D0 9801 9CDF
* tag 'pull-block-2022-04-20' of https://gitlab.com/hreitz/qemu :
qcow2: Add errp to rebuild_refcount_structure()
iotests/108: Test new refcount rebuild algorithm
qcow2: Improve refcount structure rebuilding
iotests/303: Check for zstd support
iotests/065: Check for zstd support
iotests.py: Add supports_qcow2_zstd_compression()
tests/qemu-iotests: Move the bash and sanitizer checks to meson.build
tests/qemu-iotests/meson.build: Improve the indentation
Signed-off-by: Richard Henderson <richard.henderson@linaro.org >
2022-04-20 09:39:33 -07:00
Alex Bennée
caccf59918
tests/guest-debug: better handle gdb crashes
...
There are a number of GDB's on various distros which fail fairly hard
when attempting to talk to a cross-arch guest. The previous attempt to
catch this was incorrect as the shell will deliver signals as 128+n.
Fix the detection and while we are it improve the logging we dump into
the test output.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org >
Reported-by: Gautam Agrawal <gautamnagrawal@gmail.com >
Reviewed-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220419091020.3008144-26-alex.bennee@linaro.org >
2022-04-20 16:04:20 +01:00
Alex Bennée
e618e1f9b4
target/i386: fix byte swap issue with XMM register access
...
During the conversion to the gdb_get_reg128 helpers the high and low
parts of the XMM register where inadvertently swapped. This causes
reads of the register to report the incorrect value to gdb.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/971
Fixes: b7b8756a9c (target/i386: use gdb_get_reg helpers)
Signed-off-by: Alex Bennée <alex.bennee@linaro.org >
Reviewed-by: Richard Henderson <richard.henderson@linaro.org >
Cc: qemu-stable@nongnu.org
Message-Id: <20220419091020.3008144-25-alex.bennee@linaro.org >
2022-04-20 16:04:20 +01:00
Alex Bennée
f9caa8feea
tests/tcg: add missing reference files for float_convs
...
We might as well include a reference file for i386/x86_64. I was going
to include s390x as well but it's broken hence I raised:
https://gitlab.com/qemu-project/qemu/-/issues/979 .
Signed-off-by: Alex Bennée <alex.bennee@linaro.org >
Message-Id: <20220419091020.3008144-24-alex.bennee@linaro.org >
2022-04-20 16:04:20 +01:00
Alex Bennée
2931014c3d
tests/tcg: add float_convd test
...
This is a simple transliteration of the float_convs test but this time
working with doubles. I'm used it to test the handling of vector
registers in gdbstub but wasn't able to find a non-ugly way to
automate it.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org >
Reviewed-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220419091020.3008144-23-alex.bennee@linaro.org >
2022-04-20 16:04:20 +01:00
Alex Bennée
9730a27ef4
tests/tcg: remove duplicate sha512-sse case
...
We already generate the sha512-sse case in the i386 makefile which
works for both i386 and x86_64.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org >
Fixes: f8a4c6d728 ("tests/tcg: add vectorised sha512 versions")
Reviewed-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220419091020.3008144-22-alex.bennee@linaro.org >
2022-04-20 16:04:20 +01:00
Paolo Bonzini
a5ed13cd31
tests/tcg: fix non-static build
...
If linking with -static fails at configure time, -static should not be used
at build time either. Do not include BUILD_STATIC in $config_target_mak.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com >
Message-Id: <20220401141326.1244422-18-pbonzini@redhat.com >
Signed-off-by: Alex Bennée <alex.bennee@linaro.org >
Reviewed-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220419091020.3008144-21-alex.bennee@linaro.org >
2022-04-20 16:04:20 +01:00
Paolo Bonzini
77162849a6
tests/docker: remove SKIP_DOCKER_BUILD
...
It is now unused.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com >
Message-Id: <20220401141326.1244422-17-pbonzini@redhat.com >
Signed-off-by: Alex Bennée <alex.bennee@linaro.org >
Reviewed-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220419091020.3008144-20-alex.bennee@linaro.org >
2022-04-20 16:04:20 +01:00
Paolo Bonzini
544f4a2578
tests/tcg: isolate from QEMU's config-host.mak
...
Do not include variables for the QEMU's own compiler, as they
are not necessarily related to the cross compiler used for tests/tcg.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com >
Message-Id: <20220401141326.1244422-16-pbonzini@redhat.com >
Signed-off-by: Alex Bennée <alex.bennee@linaro.org >
Reviewed-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220419091020.3008144-19-alex.bennee@linaro.org >
2022-04-20 16:04:20 +01:00
Paolo Bonzini
eebf199c09
tests/tcg: invoke Makefile.target directly from QEMU's makefile
...
Build the "docker.py cc" invocation directly in tests/tcg/configure.sh, and
remove the Makefile.qemu wrapper around Makefile.target. The config-*.mak
files now include the actual variables used when building the tests, rather
than the CROSS_* variables that Makefile.qemu used to "translate".
This is a first step towards generalizing the cross-compilation infrastructure
so that it can be used for firmware as well.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com >
Message-Id: <20220401141326.1244422-15-pbonzini@redhat.com >
Signed-off-by: Alex Bennée <alex.bennee@linaro.org >
Reviewed-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220419091020.3008144-18-alex.bennee@linaro.org >
2022-04-20 16:04:20 +01:00
Paolo Bonzini
5377a10001
tests/tcg: list test targets in Makefile.prereqs
...
Omit the rules altogether for targets that do not have a compiler.
Makefile.qemu now is only invoked if the tests are actually built/run.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com >
Message-Id: <20220401141326.1244422-14-pbonzini@redhat.com >
Signed-off-by: Alex Bennée <alex.bennee@linaro.org >
Reviewed-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220419091020.3008144-17-alex.bennee@linaro.org >
2022-04-20 16:04:20 +01:00
Paolo Bonzini
f2d5935145
tests/tcg: prepare Makefile.prereqs at configure time
...
List the dependencies of the build-tcg-tests-* and run-tcg-tests-*
targets in a Makefile fragment, without going through Makefile.prereqs's
"parsing" of config-*.mak.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com >
Message-Id: <20220401141326.1244422-13-pbonzini@redhat.com >
Signed-off-by: Alex Bennée <alex.bennee@linaro.org >
Reviewed-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220419091020.3008144-16-alex.bennee@linaro.org >
2022-04-20 16:04:20 +01:00
Paolo Bonzini
8e61ecca4a
tests/tcg: remove CONFIG_USER_ONLY from config-target.mak
...
Just check the target name instead.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com >
Message-Id: <20220401141326.1244422-12-pbonzini@redhat.com >
Signed-off-by: Alex Bennée <alex.bennee@linaro.org >
Reviewed-by: Richard Henderson <richard.henderson@linaro.org >
Message-Id: <20220419091020.3008144-15-alex.bennee@linaro.org >
2022-04-20 16:04:20 +01:00