mirror of
https://github.com/hrydgard/ppsspp.git
synced 2026-11-17 19:34:39 +01:00
The disassembly view's assembler has been commented out since the ImGui debugger was written, because it asked for the opcode with InputBox_GetString, which is Win32-only. Replaced with a small popup built from ImGui, so it works everywhere the ImGui debugger does. Splitting it in two is what the popup costs: assembleOpcode() only records the address and seed text and raises a flag, since ImGui popups have to be opened and drawn inside the frame that owns them, and applyAssembly() does the work when the input is submitted. The flag is consumed in PopupMenu(), next to the existing rename-function popup, which had already established the pattern. The new state lives in ImDisasmView. Behaviour follows the Win32 version, including "register=expression" assigning a register rather than assembling, and falling through to the assembler when the left side isn't a register name. Two differences, both deliberate: - Errors appear inside the popup instead of a modal message box, and the popup stays open with the text still in it, so a typo can be corrected instead of retyped. - No Core_RunOnCPUThread() around the register write or the assemble. The Win32 debugger needs it because its dialogs are pumped by the WinMain message loop, a genuinely different thread; UI/ImDebugger always runs on the same thread as Core_RunLoopUntil(), so it can touch this state directly (see AGENTS.md). Also updated for the current APIs while it was dead: MipsAssembleOpcode() takes an out-parameter for the error now rather than MIPSAsm::GetAssembleError(), and expression evaluation goes through initExpression()/parseExpression(). The core has to be stepping, checked both when the popup is requested and again on submit - the popup is modeless, so the core can be resumed while it's open. The keyboard shortcut (A) is re-enabled along with the context menu item. onChar(), which seeds the popup with the character typed over an instruction, already called this and needed no change - it still has no caller of its own, which is a separate pre-existing gap. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GZq8ZtJmFY7bkX5FVkr3P9