Files
ppsspp/Core/Debugger/Breakpoints.h
T
Henrik RydgårdandClaude Sonnet 5 3edea91c8e Debugger: track hit counts on address breakpoints, expose via cpu.breakpoint.list
BreakPoint (cpu.breakpoint.*) had no hit-count tracking at all, unlike
MemCheck (memory.breakpoint.*), which already tracks numHits. This made it
genuinely hard to tell "this breakpoint is never being reached" apart from
"it's being reached but I'm not seeing the log/pause where I'm looking" -
directly informed by repeatedly hitting exactly that ambiguity while
debugging the VSH boot path this session (see docs/VSHBootInvestigation.md).

Added BreakPoint::numHits, incremented in BreakpointManager::ExecBreakPoint()
whenever a breakpoint's address is hit and any condition passes (matching
MemCheck::Apply()'s existing semantics - counts real triggers, not just
"execution passed through here"). Exposed as a new "hits" field in
cpu.breakpoint.list's response.

Verified live via PPSSPPHeadless + wsdbg: hits reads 0 before the CPU
resumes, 1 after the breakpoint fires once. UnitTest.exe all: 49/49 passed.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GZq8ZtJmFY7bkX5FVkr3P9
2026-08-14 11:04:32 +02:00

292 lines
9.0 KiB
C++

// Copyright (c) 2012- PPSSPP Project.
// This program is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, version 2.0 or later versions.
// This program is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License 2.0 for more details.
// A copy of the GPL 2.0 should have been included with the program.
// If not, see http://www.gnu.org/licenses/
// Official git repository and contact information can be found at
// https://github.com/hrydgard/ppsspp and http://www.ppsspp.org/.
#pragma once
#include <vector>
#include <atomic>
#include "Core/MIPS/MIPSDebugInterface.h"
#include "Common/Math/expression_parser.h"
enum BreakAction : u32 {
BREAK_ACTION_IGNORE = 0x00,
BREAK_ACTION_LOG = 0x01,
BREAK_ACTION_PAUSE = 0x02,
};
static inline BreakAction &operator |= (BreakAction &lhs, const BreakAction &rhs) {
lhs = BreakAction(lhs | rhs);
return lhs;
}
static inline BreakAction operator | (const BreakAction &lhs, const BreakAction &rhs) {
return BreakAction((u32)lhs | (u32)rhs);
}
struct BreakPointCond {
DebugInterface *debug = nullptr;
PostfixExpression expression;
std::string expressionString;
u32 Evaluate() {
u32 result;
if (parseExpression(debug, expression, result) == false)
return 0;
return result;
}
};
struct BreakPoint {
u32 addr;
bool temporary;
BreakAction result = BREAK_ACTION_IGNORE;
std::string logFormat;
bool hasCond = false;
BreakPointCond cond;
// Matches MemCheck's numHits below - added after repeatedly needing to tell "is this
// breakpoint even being reached at all" from "it's reached but the log isn't showing up
// where I'm looking" during the VSH boot investigation (see docs/VSHBootInvestigation.md).
u32 numHits = 0;
bool IsEnabled() const {
return (result & BREAK_ACTION_PAUSE) != 0;
}
bool operator == (const BreakPoint &other) const {
return addr == other.addr;
}
bool operator < (const BreakPoint &other) const {
return addr < other.addr;
}
};
enum MemCheckCondition {
MEMCHECK_READ = 0x01,
MEMCHECK_WRITE = 0x02,
MEMCHECK_WRITE_ONCHANGE = 0x04,
MEMCHECK_READWRITE = 0x03,
};
struct MemCheck {
u32 start;
u32 end;
MemCheckCondition cond = MEMCHECK_READ;
BreakAction result = BREAK_ACTION_IGNORE;
std::string logFormat;
bool hasCondition = false;
BreakPointCond condition;
u32 numHits = 0;
u32 lastPC = 0;
u32 lastAddr = 0;
int lastSize = 0;
// Called on the stored memcheck (affects numHits, etc.)
BreakAction Apply(u32 addr, bool write, int size, u32 pc);
// Called on a copy.
BreakAction Action(u32 addr, bool write, int size, u32 pc, const char *reason);
void Log(u32 addr, bool write, int size, u32 pc, const char *reason) const;
bool IsEnabled() const {
return (result & BREAK_ACTION_PAUSE) != 0;
}
bool operator == (const MemCheck &other) const {
return start == other.start && end == other.end;
}
};
// A breakpoint that trips whenever a register is written to by an instruction, regardless of
// address - identified by register index (0-31), not addr/range. Currently only GPRs are
// supported (reg is a GPR index), but the naming is kept general since this is expected to grow
// to cover other register files too (e.g. FPU registers like $f10).
// Interpreter-only for now (see RunUntilDowncountZeroWithChecks in MIPSTables.cpp) - the JITs
// don't check this at all, so it has no effect unless running with the plain interpreter core.
struct RegBreakpoint {
int reg = 0; // 0-31, general-purpose register index (matches OUT_RT/OUT_RD/OUT_RA fields).
BreakAction result = BREAK_ACTION_IGNORE;
std::string logFormat;
bool hasCond = false;
BreakPointCond cond;
u32 numHits = 0;
bool IsEnabled() const {
return (result & BREAK_ACTION_PAUSE) != 0;
}
bool operator == (const RegBreakpoint &other) const {
return reg == other.reg;
}
};
// BreakPoints cannot overlap, only one is allowed per address.
// MemChecks can overlap, as long as their ends are different.
// WARNING: MemChecks are not always tracked in HLE currently.
class BreakpointManager {
public:
static const size_t INVALID_BREAKPOINT = -1;
static const size_t INVALID_MEMCHECK = -1;
static const size_t INVALID_REG_BREAKPOINT = -1;
bool IsAddressBreakPoint(u32 addr);
bool IsAddressBreakPoint(u32 addr, bool* enabled);
bool IsTempBreakPoint(u32 addr);
bool RangeContainsBreakPoint(u32 addr, u32 size);
int AddBreakPoint(u32 addr, bool temp = false); // Returns the breakpoint index.
void RemoveBreakPoint(u32 addr);
void ChangeBreakPoint(u32 addr, bool enable);
void ChangeBreakPoint(u32 addr, BreakAction result);
void ClearAllBreakPoints();
void ClearTemporaryBreakPoints();
// Makes a copy of the condition.
void ChangeBreakPointAddCond(u32 addr, const BreakPointCond &cond);
void ChangeBreakPointRemoveCond(u32 addr);
BreakPointCond *GetBreakPointCondition(u32 addr);
void ChangeBreakPointLogFormat(u32 addr, const std::string &fmt);
BreakAction ExecBreakPoint(u32 addr);
int AddMemCheck(u32 start, u32 end, MemCheckCondition cond, BreakAction result);
void RemoveMemCheck(u32 start, u32 end);
void ChangeMemCheck(u32 start, u32 end, MemCheckCondition cond, BreakAction result);
void ClearAllMemChecks();
void ChangeMemCheckAddCond(u32 start, u32 end, const BreakPointCond &cond);
void ChangeMemCheckRemoveCond(u32 start, u32 end);
BreakPointCond *GetMemCheckCondition(u32 start, u32 end);
void ChangeMemCheckLogFormat(u32 start, u32 end, const std::string &fmt);
bool GetMemCheck(u32 start, u32 end, MemCheck *check);
bool GetMemCheckInRange(u32 address, int size, MemCheck *check);
BreakAction ExecMemCheck(u32 address, bool write, int size, u32 pc, const char *reason);
BreakAction ExecOpMemCheck(u32 address, u32 pc);
// Register write breakpoints - see RegBreakpoint above. reg is a 0-31 GPR index.
int AddRegBreakpoint(int reg); // Returns the breakpoint index.
void RemoveRegBreakpoint(int reg);
void ChangeRegBreakpoint(int reg, bool enable);
void ChangeRegBreakpoint(int reg, BreakAction result);
void ClearAllRegBreakpoints();
void ChangeRegBreakpointAddCond(int reg, const BreakPointCond &cond);
void ChangeRegBreakpointRemoveCond(int reg);
BreakPointCond *GetRegBreakpointCondition(int reg);
void ChangeRegBreakpointLogFormat(int reg, const std::string &fmt);
bool IsRegBreakpoint(int reg);
bool GetRegBreakpoint(int reg, RegBreakpoint *bp);
std::vector<RegBreakpoint> GetRegBreakpoints();
// Called from the interpreter (RunUntilDowncountZeroWithChecks) right before executing an
// instruction that would write to reg - does not itself execute the instruction.
BreakAction ExecRegBreakpoint(int reg, u32 pc);
void SetSkipFirst(u32 pc);
u32 CheckSkipFirst();
// Includes uncached addresses.
std::vector<MemCheck> GetMemCheckRanges(bool write);
std::vector<MemCheck> GetMemChecks();
std::vector<BreakPoint> GetBreakpoints();
// For editing through the imdebugger.
// Since it's on the main thread, we don't need to fear threading clashes.
std::vector<BreakPoint> &GetBreakpointRefs() {
return breakPoints_;
}
std::vector<MemCheck> &GetMemCheckRefs() {
return memChecks_;
}
bool HasBreakPoints() const {
return anyBreakPoints_;
}
bool HasMemChecks() const {
return anyMemChecks_;
}
bool HasRegBreakpoints() const {
return regBreakpointMask_ != 0;
}
// Bit i set means register i has an active (non-ignored) register breakpoint - a cheap way
// for the interpreter's hot per-instruction loop to test "would this write trip anything"
// with a single shift+and, without touching regBreakpoints_ at all in the common no-match case.
u32 GetRegBreakpointMask() const {
return regBreakpointMask_;
}
void Frame();
bool ValidateLogFormat(MIPSDebugInterface *cpu, const std::string &fmt);
bool EvaluateLogFormat(MIPSDebugInterface *cpu, const std::string &fmt, std::string &result);
private:
// 0 means to clear the whole jit cache, to apply some change that has been made.
void Update(u32 addr) {
needsUpdate_ = true;
updateAddr_ = addr;
}
size_t FindBreakpoint(u32 addr, bool matchTemp = false, bool temp = false);
// Finds exactly, not using a range check.
size_t FindMemCheck(u32 start, u32 end);
// Finds a memcheck covering (part of) a range, unlike FindMemCheck() above.
MemCheck *FindMemCheckInRange(u32 address, int size);
void UpdateCachedMemCheckRanges();
size_t FindRegBreakpoint(int reg);
void RecomputeRegBreakpointMask();
std::atomic<bool> anyBreakPoints_;
std::atomic<bool> anyMemChecks_;
std::atomic<u32> regBreakpointMask_;
std::vector<BreakPoint> breakPoints_;
u32 breakSkipFirstAt_ = 0;
u64 breakSkipFirstTicks_ = 0;
std::vector<MemCheck> memChecks_;
std::vector<MemCheck> memCheckRangesRead_;
std::vector<MemCheck> memCheckRangesWrite_;
std::vector<RegBreakpoint> regBreakpoints_;
bool needsUpdate_ = true;
u32 updateAddr_ = 0;
enum {
INVALID_ADDRESS = -1
};
};
extern BreakpointManager g_breakpoints;