Commit Graph

45 Commits

Author SHA1 Message Date
Unknown W. Brackets 085bcde865 Debugger: Ignore invalid branches.
These happen on bytes that are not actually code.
2018-06-08 06:59:18 -07:00
Unknown W. Brackets b828497fe2 Debugger: Avoid some lock ordering issues.
Ideally get rid of the memory lock...
2018-06-08 06:59:18 -07:00
Unknown W. Brackets 5670fc03ae Debugger: Add debug interfaces for threads.
This way we can switch context.
2018-06-08 06:59:18 -07:00
Unknown W. Brackets 8598fc9912 Debugger: Add some missing memory locks.
We can restart memory when loading save states, so we need this even while
we've got startup/shutdown locked.
2018-06-08 06:59:18 -07:00
Unknown W. Brackets b2cc4a0965 Debugger: Add memory breakpoint management. 2018-06-08 06:59:18 -07:00
Unknown W. Brackets 5b132c904a Debugger: Fix resume not skipping breakpoints. 2018-06-08 06:59:18 -07:00
Unknown W. Brackets 0f84c2e995 Debugger: Consistently handle invalid addresses. 2018-06-06 05:58:49 -07:00
Unknown W. Brackets 0b8359fd77 Debugger: Add mutexing to disassembly manager.
It was crashing when accessing from another thread.

If in the future we go down to only the remote debugger, we could
potentially remove this.
2018-06-06 05:58:49 -07:00
Unknown W. Brackets 7613fd97aa Windows: Fix minor leak in disassembly UI. 2017-04-27 20:02:49 -07:00
Henrik Rydgard b998131581 Move the symbol map to the heap, deallocate it when no game is running. 2015-10-31 23:01:19 +01:00
Unknown W. Brackets 6382d794a7 Fix a debugger leak in an error case. 2015-01-17 18:54:01 -08:00
Unknown W. Brackets 2b16b5b79b Use XXH64 on 64-bit systems.
I'm not able to reproduce any real performance difference, but I know
there are some games which do more hashing and it may help there.
2014-10-26 17:49:24 -07:00
Henrik Rydgård 3b1476c8ec MIPSTables: Annotate fp and hi/lo in/out more accurately than just "other"
Some typo fixes
2014-10-12 19:46:50 +02:00
Henrik Rydgard f84ebf6bff sprintf->snprintf, fix some too short buffers 2014-09-14 00:14:11 +02:00
Unknown W. Brackets 55403e42c2 Introduce a memory shutdown lock.
This allows the debugger to access memory in a safe way that should never
crash.
2014-07-19 23:30:19 -07:00
Sacha cd20288d99 Fix some compiler warnings. 2014-07-17 00:49:58 +10:00
Unknown W. Brackets 38dde1f6b5 Fix a debugger crash on shutdown. 2014-06-08 16:35:39 -07:00
Henrik Rydgard c80510fb3b MemMap should not be included in MIPS.h. 2014-03-15 10:45:39 +01:00
Unknown W. Brackets 76afb2a8d5 Avoid returning points from the symbol map.
Now that it uses a lookup, this is even more dangerous.  But, the maps
could be reordered while it's trying to print the pointer and cause that
data to become invalid.

This should be safe from race conditions.
2014-01-25 21:40:23 -08:00
Henrik Rydgård be74da8f3c More include cleanup, hopefully buildfix Symbian 2013-12-30 00:23:04 +01:00
Unknown W. Brackets 12713a44a1 Attempt to prevent shutdown crash in debugger. 2013-12-14 14:56:04 -08:00
pal1000 cfcfb20622 Warning fix in DisassemblyManager.cpp (Visual Studio 2013) 2013-12-02 12:39:01 +02:00
Unknown W. Brackets dd2e996838 Fix some type comparison warnings. 2013-12-01 11:21:16 -08:00
Henrik Rydgård 1296aad6c7 Merge pull request #4675 from Kingcom/Debugger
Small debugger fixes and enhancements
2013-11-29 08:30:08 -08:00
Kingcom 85abd37ed1 Small debugger fixes and enhancements 2013-11-29 17:21:48 +01:00
Unknown W. Brackets 79322103f2 Optimize DisassemblyFunction::getLineNum() a bit.
Improves scrolling performance in some cases in the debugger.
2013-11-28 23:48:12 -08:00
Kingcom cca750aab5 Fix invalid memory access on start, remove combo box code from symbol map 2013-11-28 10:49:02 +01:00
Kingcom 577a46be09 Remove useless comment 2013-11-28 00:48:05 +01:00
Kingcom 561379f5c2 Create data directives in disassembler 2013-11-28 00:33:21 +01:00
Kingcom 5844d0107b Rewrite SymbolTable 2013-11-27 13:33:30 +01:00
Kingcom 33da416a82 Reduce disassembler memory usage 2013-11-26 22:20:12 +01:00
Kingcom 274632f304 Minor disassembly tweaks 2013-11-26 11:38:01 +01:00
Kingcom 3d4bb3f20b Remove obsolete functions 2013-11-26 00:51:04 +01:00
Kingcom 7c585485bb Save labels separately from symbols 2013-11-26 00:23:17 +01:00
Kingcom b71bfe5a62 -Get branch lines for opcodes outside of a function
-fix labels causing analyzing issues
2013-11-25 21:53:01 +01:00
Kingcom 8146e7bfb0 Fix stepping 2013-11-25 19:51:16 +01:00
Kingcom ea38eb4318 Correctly rescan visible data 2013-11-25 17:31:39 +01:00
Kingcom 945dc48ea7 Don't recompute number of lines of a function every time 2013-11-25 16:52:42 +01:00
Kingcom 9a29e8b0bf More efficient "loose" opcode detection, clear entries when symbols were loaded 2013-11-25 16:18:29 +01:00
Kingcom 60987d9217 Minor optimization 2013-11-25 14:19:45 +01:00
Kingcom 42c5fe0164 Massive speed optimizations 2013-11-25 13:56:43 +01:00
Kingcom aab6f588f1 Fix branch lines 2013-11-24 14:46:53 +01:00
Kingcom 0672458a33 Fix follow branch, display symbols 2013-11-24 13:53:50 +01:00
Kingcom 63e2f34beb Correctly identify the start of a line when changing the address 2013-11-24 13:53:50 +01:00
Kingcom a928c62ad1 Basic implementation and integration of DisassemblyManager 2013-11-24 13:53:50 +01:00