Commit Graph
57 Commits
Author SHA1 Message Date
Henrik Rydgård 1f60247749 Fix hang when changing UMD with retroachievements enabled
Fixes #17976
2023-09-12 14:17:50 +02:00
Henrik Rydgård 95badd03b4 RetroAchievement - only register the file reader once 2023-09-12 14:02:12 +02:00
Henrik Rydgård ce82179321 Avoid checking for achievements for homebrew. Fix edge case. 2023-09-06 11:19:13 +02:00
Henrik Rydgård b61fa7053f RetroAchievements: Add parameter to SetGame for IdentifiedFileType, also add bool return to SaveSecret 2023-09-06 10:56:51 +02:00
Henrik Rydgård cd79d120d8 Don't log warnings on missing RA login secret. Also don't even check unless a username has been set. 2023-09-06 10:34:32 +02:00
Henrik RydgårdandGitHub 9291a4e52a Merge pull request #17998 from hrydgard/minor-fixes
Minor: Correct RA login retry behavior if disabled, improved logging in CLUTLoad case
2023-08-28 16:09:34 +02:00
Henrik Rydgård 9e708fc82d Don't show RetroAchievements login failures (and don't retry) if the user has disabled them. 2023-08-28 14:38:32 +02:00
Henrik Rydgård b637a9c42e Upgrade rcheevos to latest
The timer issue has been fixed upstream. Hopefully nothing will regress on
32-bit Android this time.

See #17631
2023-08-28 14:09:46 +02:00
Henrik Rydgård 26af6eb569 RetroAchievements: More connection notifications
Trying to make it harder for a user to accidentally run without achievements enabled.
2023-08-28 12:15:24 +02:00
Henrik Rydgård def25100df RetroAchievements: Warn the user if has token and not logged in. 2023-08-26 13:27:10 +02:00
Henrik Rydgård a70b36671a Show the RetroAchievements icon in a bunch of notifications 2023-08-25 16:36:29 +02:00
Henrik Rydgård 6d28ccbd8e Add HTTP log channel, and make ACHIEVEMENTS a proper one. 2023-08-25 13:53:46 +02:00
Henrik Rydgård 44d602ca7d Move InitSysDirectories to where it belongs and rename it. Plus warning fixes. 2023-08-18 13:03:32 +02:00
Henrik Rydgård 50ea506b6a Revert "Regression experiment: Temporarily revert to returning 0 from bad achievement memory accesses."
This reverts commit a044d8ccc2.
2023-08-09 16:16:39 +02:00
Henrik Rydgård ac269aaa4b rcheevos: revert to before #17806
PR #17806 upgraded rcheevos, after which a regression is reported in
issue #17631.

Experimentally revert to confirm.
2023-08-08 15:38:22 +02:00
Henrik Rydgård a044d8ccc2 Regression experiment: Temporarily revert to returning 0 from bad achievement memory accesses. 2023-08-08 15:33:46 +02:00
Henrik Rydgård 1071e1f248 Move towards separate types for leaderboard events 2023-08-01 11:57:28 +02:00
Henrik Rydgård 1c05f71b50 Update to the latest version of rcheevos. 2023-07-30 11:58:55 +02:00
Henrik Rydgård 3ae520c35d RetroAchievements: Fix another race condition, improve logging.
Seems to help the frontend problem.
2023-07-24 12:00:16 +02:00
Henrik Rydgård 2625570d21 Fix issue where achievements wouldn't always activate when starting from frontends
My previous workaround was flawed - it didn't work at all since we run
http callbacks on the main thread, so no progress was made in the
background.

Now we really delay starting the game until the achievement system is
ready, if it's in the process of logging in.
2023-07-23 23:40:53 +02:00
Henrik Rydgård 0ab4c58343 Improve handling of server/token errors 2023-07-22 12:36:26 +02:00
Henrik Rydgård 93bb113009 Common: Rename Download to Request, and the old Request to ServerRequest. 2023-07-21 22:12:00 +02:00
Henrik Rydgård 61db21b12d Cleanup, fix so we can run RetroAchievements with https, and start doing that 2023-07-21 10:49:01 +02:00
Henrik Rydgård 370bb4c315 More progressbar improvements 2023-07-18 15:52:14 +02:00
Henrik Rydgård ecea3844b0 Improved progress bar popups for downloads
Now shows the filename, and also there's a delay mode where they'll only
be visible if the download takes more than a second, plus they can be
named.
2023-07-18 15:13:44 +02:00
Henrik RydgårdandGitHub eaa131db48 Merge pull request #17727 from hrydgard/switch-back-to-rcheevos-upstream
Switch back to rcheevos upstream
2023-07-16 17:52:07 +02:00
Henrik Rydgård a259ed1835 Switch back to rcheevos' upstream version 2023-07-16 17:05:08 +02:00
Henrik Rydgård 4a7ac59389 Translation fixes 2023-07-16 16:33:35 +02:00
Henrik Rydgård 8a59ed0062 Add function ApplySafeSubstitution for translation strings with parameters 2023-07-16 16:26:49 +02:00
Henrik Rydgård 0316868b62 RetroAchievements: Simplify read_memory_callback 2023-07-16 09:08:31 +02:00
Henrik Rydgård 437a984d7f Quick message fix for games with no achievements but still recognized by RA 2023-07-14 15:28:02 +02:00
Henrik Rydgård 619fadb3ca Try to eliminate any possible race condition on load. Should fix achievements from frontends.
Was not able to reproduce the problem consistently, so doing two
different fixes here.
2023-07-13 12:12:15 +02:00
Henrik Rydgård aa4264a192 RetroAchievements: Better handling of not being online when trying to log in 2023-07-13 11:26:43 +02:00
Henrik Rydgård 943bfb7329 Show a warning message on login failure 2023-07-12 19:55:53 +02:00
Henrik Rydgård af92430b18 Achievement Unlocked and Leaderboard Submitted sound effects 2023-07-12 19:55:53 +02:00
Henrik Rydgård 830679503d Update rcheevos with a crashfix (don't try different hashes if it fails)
We deallocate the block device after the first attempt, so..
2023-07-12 15:38:41 +02:00
Henrik RydgårdandGitHub 431a0551b2 RetroAchievements CSO support, delay until identified (#17699)
* Support CSO (and any future block based formats) for RetroAchievements identification

* Avoid auto-loading savestates in challenge mode
2023-07-12 01:11:09 +02:00
Henrik Rydgård 98cb26b8d0 RetroAchievements UI updates: Merge Account and Settings tabs
Move rare settings to a Developer Tools tab instead.

Minor translation updates.
2023-07-11 10:36:32 +02:00
Henrik Rydgård bf3acd9208 Fix some minor login issues, center login dialog on Windows. 2023-07-11 10:16:58 +02:00
Henrik Rydgård 41594d319a Fix updating the UI on logout 2023-07-11 10:05:55 +02:00
Henrik Rydgård 636fcb9714 Fix challenge mode check, fixing savestates not showing up if logged out 2023-07-11 10:05:06 +02:00
Henrik Rydgård 4ae3c519e2 Add assorted null checks for safety
More probably needed. Should at least hopefully fix the leaderboard crash reported in #17631

Will try to do something more systematic later.
2023-07-10 19:27:07 +02:00
Henrik Rydgård f6e84ea462 RetroAchievements: Revert to the old behavior for bad accesses (return 0).
The new smarter achievement-disabling feature has a lot of overhead and
doesn't quite seem to do what I expected. More work seems to be needed,
so let's fall back to the old behavior that most sets have been
developed against, anyway.

Should fix the Valkyrie Profile issue reported in #17631
2023-07-10 16:12:01 +02:00
Henrik Rydgård cd45125085 RetroAchievements: Show active challenge achievements on pause screen. 2023-07-10 10:39:44 +02:00
Henrik Rydgård c83abbf585 Show unlocked achievement icons in progress/challenge indicators, design tweaks 2023-07-08 21:55:37 +02:00
Henrik Rydgård c17b84b3d4 Implement RetroAchievements challenge mode restrictions, and fix related bugs 2023-07-08 21:55:32 +02:00
Henrik Rydgård 9e4387c529 Implement more OSD types (challenge, progress indicators). Not really tested. 2023-07-08 21:48:23 +02:00
Henrik Rydgård 0889e7cf3e Add setting to enable unofficial achievements 2023-07-08 21:47:19 +02:00
Henrik Rydgård 18e6da2e3d rc_client: Hook up UMD change (untested) 2023-07-08 21:47:19 +02:00
Henrik Rydgård bebc3feee1 Safety: Make sure we're not executing game code while waiting for RetroAchievements identification. 2023-07-08 21:47:19 +02:00