preserve-emulation/ppsspp
1
0 Fork 0
mirror of https://github.com/hrydgard/ppsspp.git synced 2026-10-15 15:30:29 +02:00
Code Issues Packages Projects Releases Wiki Activity
48,357 Commits 98 Branches 131 Tags
964b5dc00a7cfc9099b470a9b5d2eee2faeb4e02
Commit Graph
65 Commits
Author SHA1 Message Date
Henrik RydgårdandClaude Opus 5 6c7fc8df37 JitBlockCache: fix the invalidation margin, and unlink destroyed blocks 
InvalidateICache widened its search by MAX_BLOCK_INSTRUCTIONS, but
block_map_ is keyed by byte addresses - a block can span four times that
many bytes. A block longer than 0x4000 bytes starting just below the end
of the invalidated range could therefore be missed and left behind after
the code under it changed. Multiply by 4.

DestroyBlock's "invalid original address" safety check returned after
setting b->invalid but before UnlinkBlock() and the checkedEntry
poisoning, so other blocks kept jumping directly into a block the cache
had already written off. The check is there to guard the memory access
that restores the original opcode, so only guard that.

Also: codeSize is a byte count assigned from a full pointer difference,
so a block over 64KB truncated it (affecting GetAddressFromBlockPtr and
the disassembly view); widen it to u32. The RAMTOP range check missed a
block sitting exactly on the user-memory midpoint, since the RAMBOTTOM
check next to it is strict. And GetBlockDebugInfo disassembled one
instruction past the end of the block.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
 2026-09-21 11:32:24 -06:00
Henrik Rydgård 1e57d8110f Minor blockcache improvement 2026-02-25 00:52:25 +01:00
Henrik Rydgård 8897b5914a Improve integrity checks in JIT (trying to catch an elusive crash) 2026-02-17 22:42:04 +01:00
Henrik Rydgård f0ba391a4e Remove the whole concept of proxy blocks from the block cache, and experimental uses of it. 2026-02-17 09:40:27 +01:00
Henrik Rydgård 44a2585753 Rename some function, remove an unused return value 2026-02-12 01:23:45 +01:00
Henrik Rydgård 8631e77db2 Delete some outdated profiler integrations 2026-01-01 13:55:30 +01:00
Henrik Rydgård a72fc6f79c Support showing (and sorting by) IR profiler info in the JIT viewer 
This will help future work on #19143 .
 2025-10-09 17:02:52 -06:00
Henrik Rydgård cf678a1aa6 JIT: Allow more blocks to be stored in the cache. Also, add margin to the IsFull check. 2024-10-28 17:02:03 +01:00
Henrik Rydgård 0ea9120ca5 Add a stats view 2024-06-06 19:21:50 +02:00
Henrik Rydgård 294593f741 Fix IR profiling 2024-06-05 19:12:08 +02:00
Henrik Rydgård 3bb74ea9ad Rework the JitCompare window to hold a list of blocks, and allow some filtering and browsing 2024-06-05 18:16:33 +02:00
Henrik Rydgård ba1ced77c3 IRJit block profiling basics 2024-06-05 13:02:40 +02:00
Henrik Rydgård f2837e3b55 JIT compare screen with IR blocks - fix some crashing issues 2024-05-26 14:10:50 +02:00
Herman Semenov 17ecee1715 Fixed return copies from functions and const ref params 2024-04-02 18:37:00 +03:00
Henrik Rydgård dd2b1ace88 BlockCache on ARM/ARM64: Allow two more exits 2023-09-26 19:44:05 +02:00
Henrik Rydgård 9db9fec898 VFPU: Some micro-optimizations. Don't fall back to interpreter path for vexp/vlog/vrexp. 2023-06-04 11:28:33 +02:00
Henrik Rydgård 1a2d599942 JIT: Consider the block cache full a few block before it is, to allow space for proxy blocks. 
Should fix the following crash:

Core/MIPS/JitCommon/JitBlockCache.cpp:190

JitBlock &b = blocks_[num_blocks_];
 2023-05-02 21:53:01 +02:00
Unknown W. Brackets b9fe48f42d Crash: Lookup block numbers more efficiently. 
We only care about the first one in these places anyway.  Also make sure
we don't try to match an invalid block number.
 2022-12-20 21:02:52 -08:00
Unknown W. Brackets b9de1a44df jit: Reduce some include pollution. 
Usually no need for all of MIPSAnalyst.
 2022-10-27 23:26:44 -07:00
Unknown W. Brackets 00f9707399 jit: Use a hash for invalidate/clear all. 
This should make sceKernelICacheClearAll() more useful.
 2021-12-19 10:40:33 -08:00
Unknown W. Brackets cae0815095 jit: Avoid using mips identifier directly. 
Apparently this gets defined on mips systems.
 2021-02-26 07:24:58 -08:00
Unknown W. Brackets 6b8f7294b3 Global: Remove ARM64 define. 
Was barely used anymore, and some users are specifying it when it's not
the case, so better to detect consistently.
 2020-08-29 08:45:50 -07:00
Unknown W. Brackets 7910b4029a arm64jit: Track writable and non-writable pointers. 
Switch uses different memory regions.  We can handle this, might as well
cleanup some const abuse.
 2020-05-17 00:15:12 -07:00
Henrik Rydgård 468b830bec Show IR disassembly in JIT Compare screen 2018-01-04 12:23:23 +01:00
Unknown W. Brackets 8c3b0aa89c jit: Skip unlinking blocks on clear. 
Speeds up clear especially when on a WX exclusive platform.
 2017-12-28 11:12:06 -08:00
Henrik Rydgård 6e49341b91 Workaround a shutdown crash by adding a sanity check .. which actually catches stuff. A bit worrying. 2017-01-26 08:43:26 +01:00
Henrik Rydgard ccce19e14a Fix accidentally truncated comment. 2016-05-01 18:47:32 +02:00
Henrik Rydgard ffe4c266ef Add CodeBlockCommon base class to remove further arch-specificity in JitBlockCache 
Remove unused ArmThunk.
 2016-05-01 11:40:00 +02:00
Henrik Rydgard 8b450c8034 Merge NativeJit.cpp/h with JitCommon.cpp/h 2016-05-01 11:39:59 +02:00
Henrik Rydgard 5aadce59a2 Move architecture-specific code out of JitBlockCache 2016-05-01 11:39:58 +02:00
Unknown W. Brackets cd842ac21f Validate blocklinking in icache invalidate all. 
Normally blocks are invalidated on entry.  But when blocklinking is on,
we don't validate on all entries.

This fixes Tales of Rebirth crashes (#7868.)
 2015-07-19 13:08:32 -07:00
Henrik Rydgård 59d0baca93 Add way to print some block bloat stats. 2015-04-11 00:12:56 -07:00
Henrik Rydgard b309c83973 Initial work on ARM64, based on the ARM jit. 2015-04-06 18:13:01 +02:00
Henrik Rydgård 53ab7ab4b2 Fix FakeJit, start preparing a little for ARM64 2014-12-23 09:36:28 +01:00
Henrik Rydgård a9be90229a Merge pull request #7140 from AbandonedCart/master 
use libc++ for iOS to avoid additional directives
 2014-12-18 22:38:14 +01:00
Henrik Rydgard a54e0cf244 Goodbye PowerPC, you can always be resurrected when the time comes 2014-12-16 21:58:38 +01:00
Henrik Rydgard 4ec30d98e1 Port the x86 and ARM emitters over to use the generic CodeBlock class 2014-12-15 22:32:55 +01:00
TwistedUmbrella 3f4d58b0b2 use libc++ for iOS to avoid additional directives 2014-12-05 19:47:02 -05:00
Henrik Rydgard 8f016d3e48 Merge some matrix utils and stuff from the NEON branch 2014-11-29 11:37:45 +01:00
xSacha 88b1c00a67 MIPS: Complete MIPSX rename for buildfix. 2014-11-19 07:55:44 +10:00
xSacha 3172fa22e2 Integrate new MIPS emitter. 2014-11-18 08:40:57 -08:00
Sacha a0086f6412 Introduce a Fake JIT for generic builds. 2014-11-13 00:09:51 +10:00
Unknown W. Brackets 9d86d3ca9b Use std::unordered_multimaps in a few places. 2014-11-03 08:31:52 -08:00
Unknown W. Brackets 5bb9d32eaa jit: Fix partial invalidation of larger blocks. 
Fixes #7031.
 2014-10-27 19:04:19 -07:00
Unknown W. Brackets 4853a1b7a0 jit: Optimize proxy block lookup from address. 
It was really slow before with enough proxy blocks.
 2014-10-12 17:35:23 -07:00
Unknown W. Brackets 01f9521dc5 jit: Invalidate blocks even if they end unevenly. 
This allows blocks to start and end where ever they need, which should be
good for replacements and for continuing.
 2014-10-12 17:13:04 -07:00
Unknown W. Brackets 90821b761d x86jit: Pad linked exits with breakpoints. 
So that we don't get garbage, and so we see if we end up there.
 2014-10-12 16:00:58 -07:00
Unknown W. Brackets 09b9d2ad81 Keep track of ranges that have emuhack ops. 
So that we can invalidate them smarter.
 2014-07-05 16:25:16 -07:00
Unknown W. Brackets dc39e75fc1 Oops, forgot about proxy blocks for replace jal. 
Also fix a crash when they are used.
 2014-04-17 01:03:46 -07:00
Henrik Rydgard 58237d976f Fix performance issue in BlockCache due to an instance of std::vector in every block: 
Avoid creating the vector when not necessary.

This was especially noticeable in debug mode.
 2014-03-29 22:26:51 +01:00