Commit Graph
352 Commits
Author SHA1 Message Date
Henrik Rydgård 82097b4a3b Implement NopInstruction feature in debugger
See #16975
2023-03-02 14:30:53 +01:00
Henrik Rydgård f55782558c Debugger: Copy Address will now copy addresses for the whole selection 2023-03-02 13:59:07 +01:00
Henrik RydgårdandGitHub 8b431b39ba Wrap the display globals in a struct (#16998)
* Wrap the display globals in a struct

Makes it easier to search/replace these, for future refactorings.

* Some renaming

* Qt buildfix, also fix the Qt build on Mac (got broken with battery changes)

* Attempt at buildfixing ios

* UWP buildfix
2023-02-25 13:09:44 +01:00
Unknown W. Brackets cbc1ed4bfe Debugger: Lock memory during stack walk.
In case of shutdown during it.
2023-02-22 21:14:33 -08:00
Henrik Rydgård b4a91dbce5 Disable dark mode in disasm window, and the scrollbar hack 2023-01-12 01:05:06 +01:00
Henrik Rydgård 62e5a5dfc3 Rudimentary support for Windows Dark Mode. Still undocumented for Win32 apps, so ugly. 2023-01-12 00:41:25 +01:00
Unknown W. Brackets 88489bf4cc Debugger: Fix out of bounds read for unsized copy. 2023-01-04 21:42:46 -08:00
Unknown W. Brackets 7c099dc764 Debugger: Allow copy of byte range from memview. 2023-01-01 23:02:12 -08:00
Unknown W. Brackets bba748d627 Debugger: Handle memview select right click better.
Shouldn't reset if you click inside.  Also should basically ignore
modifiers, that's how it normally behaves.
2023-01-01 22:49:04 -08:00
Unknown W. Brackets a7101b128f Debugger: Allow memview select with keyboard. 2023-01-01 22:37:53 -08:00
Unknown W. Brackets f66818ba80 Debugger: Allow selecting a range in memory view. 2023-01-01 22:28:29 -08:00
Unknown W. Brackets f8064c6763 Debugger: Cleanup memview members.
Was fairly inconsistent.  This code has not changed a lot in a long time,
so let's just do a single cleanup pass before some changes.
2023-01-01 21:47:39 -08:00
Henrik RydgårdandGitHub 40386bca08 Merge pull request #16688 from unknownbrackets/debugger
Debugger: Correct check of pending list item
2022-12-31 19:39:28 +01:00
Unknown W. Brackets bfc659ab5f Debugger: Correct check of pending list item.
Since updating is async now, setting the check state should be too.
2022-12-31 09:58:24 -08:00
Unknown W. Brackets 94a7a32234 Debugger: Correct errors in breakpoint create. 2022-12-30 15:07:02 -08:00
Unknown W. Brackets 9cfcbc46e6 Global: Cleanup initialization/pointer checks.
Cleaning up a lot of cases of uninitialized data, unchecked return values
for failures, and similar.
2022-12-10 21:13:36 -08:00
Unknown W. Brackets a7b7bf7826 Global: Set many read-only params as const.
This makes what they do and which args to use clearer, if nothing else.
2022-12-10 21:13:36 -08:00
Unknown W. Brackets f44852bb18 Global: Cleanup virtual/override specifiers.
Also missing virtual destructors, hidden non-overrides, etc.
2022-12-10 21:13:36 -08:00
Herman SemenovandGitHub 29b87e0c0b Merge branch 'master' into master 2022-10-03 07:49:13 +00:00
Unknown W. Brackets ac335ad61a armips: Update to UTF-8/c++17 armips. 2022-09-30 19:48:14 -07:00
lainon 3cdf72b68b Better readability and optimization insertion into container by replacing 'insert' -> 'emplace', 'push_back' -> 'emplace_back' 2022-09-30 12:35:28 +03:00
lainon b304551747 Code readability, vec reserve() and remove excess c_str() 2022-09-30 12:31:32 +03:00
lainon fec708489a Correct cleaning string and remove unused vars 2022-09-30 12:26:30 +03:00
Unknown W. Brackets 1233d1d376 Reporting: Disable when debugger methods used.
This won't catch all means of hacking memory, but will catch some.
Trying to reduce noise in reporting from debugging.
2022-07-30 18:21:32 -07:00
Henrik Rydgård d3d601dced Windows fixes 2022-07-24 13:58:20 +02:00
Henrik RydgårdandGitHub 858539c5b0 Merge pull request #15402 from unknownbrackets/debugger-highlight
GE Debugger: Highlight changed state values
2022-02-13 21:42:43 +01:00
Unknown W. Brackets b654ee9d44 Debugger: Allow custom draw and generic lists. 2022-02-13 10:22:38 -08:00
Unknown W. Brackets ea6c42aafb Debugger: Avoid scroll on breakpoint add. 2022-02-13 07:57:54 -08:00
Unknown W. Brackets 9435938ad9 Debugger: Cleanup some header pollution.
Also simplify just a bit.
2022-02-13 07:55:34 -08:00
Unknown W. Brackets d1c642982b Debugger: Improve memory search result draw speed. 2022-02-10 20:40:02 -08:00
Unknown W. Brackets d583720f2b Debugger: Search scratchpad/ram/vram consistently. 2022-02-10 20:39:29 -08:00
Unknown W. Brackets a397bf811b UI: Fix some sign/size comparison warnings.
Mostly size_t vs int.
2022-01-06 20:40:29 -08:00
Unknown W. Brackets 85b7b221be Debugger: Correct delayed symbol listbox updates.
With the dialogs no longer created on start, this message wasn't coming
through.
2021-12-31 09:10:40 -08:00
Unknown W. Brackets 7fe9c4e519 Debugger: Debounce updates to disasm text.
This is a bit slow, so deferring it improves update speed.
2021-12-12 11:57:24 -08:00
Unknown W. Brackets 045fc0f2b4 Debugger: Never wait inactive on window update.
This blocks the UI, and we always get a message when stepping is actually
active anyway.  More importantly, we PostMessage() debugger state, so we
might've already resumed.
2021-12-12 11:36:06 -08:00
Unknown W. Brackets db2eddcf27 Debugger: Remove double debug window updates.
Core_EnableStepping() is already marking the debug windows for update,
there's no need to call SetDebugMode() again.
2021-12-12 11:24:03 -08:00
Unknown W. Brackets e7e5d031b2 Debugger: Fix crash on ill-timed breakpoint update. 2021-12-12 10:49:38 -08:00
Unknown W. Brackets de1a6a93d8 Debugger: Debounce redraws using timers. 2021-12-12 10:22:21 -08:00
Unknown W. Brackets b8ab7f39df jit: Lock around changes to the jit pointer. 2021-11-28 10:04:22 -08:00
Unknown W. Brackets 96c1ae0f12 Debugger: Fix crash on stepping/break. 2021-11-14 09:31:43 -08:00
Henrik Rydgård fc26beca4b Also delay-load the VFPU dialog, just because 2021-11-13 22:24:30 +01:00
Henrik Rydgård c004e9ca9d Windows debugger: Load the dialogs on demand.
I think this is especially good for the Ge dialog since we now can avoid
initializing that extra GL context unless you open the dialog.
2021-11-13 22:10:37 +01:00
Unknown W. Brackets 2bd13c5d9d Debugger: Track reason for entering stepping. 2021-10-23 16:56:15 -07:00
Unknown W. Brackets 09f4e82aa7 Debugger: Keep pop up menus to ContextMenu only. 2021-10-07 19:53:40 -07:00
Unknown W. Brackets 39d3b4d933 Debugger: Centralize context menu handling.
This deduplicates a bit, but more importantly keeps all the IDs together.
2021-10-07 19:48:13 -07:00
Unknown W. Brackets 58238abef5 Debugger: Fix submenu offsets from removing unused.
The wrong menus were showing in several places, especially the GE
debugger.
2021-10-07 07:04:33 -07:00
Unknown W. Brackets d8198ae3c2 Debugger: Implement goto in disasm for memory view.
This had been in the menu for a while, but not working.
2021-10-03 06:53:58 -07:00
Unknown W. Brackets 882c22aa79 Windows: Remove some unused constants. 2021-10-03 06:53:58 -07:00
Unknown W. Brackets ee8dd8b747 Windows: Remove some old and outdated files.
These aren't being used.
2021-10-03 06:17:33 -07:00
Unknown W. Brackets 75eeb55617 UI: Use a UIState for exceptions.
This makes it so we can enable Stop/Reset/etc. during them in the menus.
2021-08-08 23:40:41 -07:00