Commit Graph
27 Commits
Author SHA1 Message Date
Henrik RydgårdandClaude Fable 5.1 2f6bb8d55e Android: Don't leak the activity on recreate, and hand it over safely
registerCallbacks took a new global ref to the activity on every onCreate
without releasing the previous one, and unregisterCallbacks only runs on a
real shutdown. Since rotation and resizing recreate the activity, each of
those leaked the old one, view hierarchy and all.

Releasing it means other threads can no longer use the raw global ref,
which had been copied into AndroidStorage and TextDrawerAndroid and was
read from the emu thread and IO threads. They now take a local ref under a
mutex (Android_GetActivity, and the equivalent inside AndroidStorage for
the shortcut activity's sake), so a call in flight keeps its activity
alive while the UI thread swaps in the new one.

The "no activity" bail is a null check on that local ref rather than a
separate HasActivity() test beforehand. Between such a test and the call
the UI thread can swap the activity out, and we'd hand null to a Java
method that wants a Context. The one remaining HasActivity() caller never
passes the activity on, so it has nothing to race with.

The ContentUri class ref and method IDs are now only looked up once,
instead of leaking a class ref per activity.

Headless and the unit test executable link Common but not app-android.cpp, so
they get a stub for this the same way they already do for getEnv and findClass.
Without it the Android CI build fails at link time, where a normal gradle build
is perfectly happy.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01152igCdjTNhT29qvphPyPC
2026-10-08 18:54:46 +02:00
Henrik RydgårdandClaude Fable 5.1 35c586b27b Android: Stop leaking JNI local references on native threads
Local refs are only freed automatically when a native method returns to
Java. The content URI functions mostly run on threads we attached
ourselves, where nothing ever freed the strings they created - two per
file open, one per exists check and so on. From Android 8 that's a slow
leak; before it the table has 512 slots and overflowing it aborts.

Add JNILocalFrame (PushLocalFrame/PopLocalFrame) and use it in all of
AndroidStorage.cpp, in the camera device list, and free the name string
in findClass.

Also: Android_GetFileInfo never released its GetStringUTFChars buffer, a
native leak on every call, and Android_ListContentUri called
GetArrayLength on a null array if the Java side returned none.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-10-08 18:54:46 +02:00
Henrik Rydgård 5b7b1f76eb Add an in-app crash history viewer to Developer Tool on Android (v30+) 2025-12-15 17:16:47 +01:00
Henrik Rydgård 115c87d11c Android buildfix 2025-09-23 12:10:15 -06:00
Henrik Rydgård 96cab3f267 Rework the log manager to be more robust 2024-12-16 12:33:58 +01:00
Henrik Rydgård 5939270d2c Log: Split out StdioListener from ConsoleListener, making the second Win32-only. 2024-07-21 13:55:40 +02:00
Henrik Rydgård ab6fafb6eb Invert dependency to avoid compile issues 2023-01-05 08:38:53 +01:00
Henrik Rydgård b56eef487c Strict mode checking - no way to forget detaching now.
And if we forget to attach, boom. Hopefully I caught all of them.
2023-01-05 08:38:52 +01:00
Henrik Rydgård 916404f0e4 Try to get a bit better at detaching threads that have used JNI from the VM. 2023-01-05 08:38:49 +01:00
Unknown W. Brackets 2479d52202 Global: Reduce includes of common headers.
In many places, string, map, or Common.h were included but not needed.
2022-01-30 16:35:33 -08:00
Henrik Rydgård e6857388c7 Add input device debug info to touchscreen test screen
(yeah maybe there's a better place but it's fine).

Also make a slight tweak to the detection order which I don't think
matters much.
2021-10-10 11:50:20 +02:00
Henrik Rydgård 9b32ea2f55 Split out AndroidStorage.cpp from android/jni/app-android.cpp, move to Common 2021-06-07 00:26:24 +02:00
Henrik Rydgård f8b595521d Simple attempt at libretro buildfix, comment fix 2021-06-07 00:24:52 +02:00
Henrik Rydgård 825478bbf7 Remove CreateDirIn, not useful enough to keep. 2021-06-07 00:24:51 +02:00
Henrik Rydgård b397e5c455 Assorted plumbing.
wip

Buildfix
2021-06-07 00:24:51 +02:00
Henrik Rydgård beb0b4e9f3 More work on AndroidStorageFileSystem.cpp. Fix current directory getting reset. 2021-06-07 00:24:51 +02:00
Henrik Rydgård ef607a5fe2 Implement a "FileSystem" that wraps Android content storage. So far unused. 2021-06-07 00:24:51 +02:00
Henrik Rydgård e3cf04bb34 Implement file filters for Android in PathBrowser
asdf

Move Android file listing parsing logic into app-android.cpp.

Add utility for parsing/writing Android Content Storage URIs.

Fix some bugs. Allow upwards navigation in file browser from directories downstream from tree URIs.
2021-06-07 00:24:51 +02:00
Henrik Rydgård 87a25fd230 Start experimenting with DocumentsContract (the thing DocumentFile wraps)
wip

Some progress towards making the file browser work with DOCUMENT_TREE

More directory browsing progress

More Scoped Storage hackery. Can now browse to a folder and use PPSSPP's game browser to load ISOs from it.

Remove the defunct fdopendir approach. Buildfixes.
2021-06-07 00:24:51 +02:00
Henrik Rydgård 54c9e28444 Android: Implement opening ISOs through a file picker and Storage Access Framework
Has issues with the recent list - fails to open during shutdown due to
no activity, there's a little race to fix.
2021-02-27 13:49:20 +01:00
Henrik Rydgård 26eab06886 Add a Storage tab to System Information.
Add a system property that we can later query to see if we should use
scoped storage adaptations or not.
2021-02-27 11:49:38 +01:00
Henrik Rydgård f0d2f24658 Finally delete base/logging.cpp/h. Carefully preserve behaviour on Android.
There's more cleanup to do ...
2020-08-15 19:09:09 +02:00
Henrik Rydgård bd3a681fd3 Enough JNI/threading hackery to get it to run on Android! Broken readbacks make it crash alot though. 2018-01-28 17:30:33 +01:00
Henrik Rydgård 0d3d642371 It works! 2017-06-05 23:09:12 +02:00
Henrik Rydgård d9c43642c2 Fix assorted JNI issues, the calls work now. 2017-06-05 23:09:10 +02:00
Henrik Rydgård 871260fcc4 Start sketching native text rendering for Android 2017-06-05 23:09:04 +02:00
Henrik Rydgard c757931779 Android: Combine the two Java Eclipse projects into one.
Should make it easier to get ndk-gdb going, which I've always had crazy issues with with library projects.
2015-09-10 18:51:48 +02:00