Commit Graph

21 Commits

Author SHA1 Message Date
Henrik Rydgård f537356bd2 Fix bug when setting reverb volume to 0 2025-06-12 11:39:46 +02:00
Henrik Rydgård 62e01d37a5 Upgrade reverb volume to the new format 2025-02-12 10:09:52 -06:00
Unknown W. Brackets ff9b9f7321 Sas: Add option to control reverb volume.
This also allows you to turn it off.
2021-08-09 20:47:24 -07:00
Henrik Rydgård 3162f30158 Merge base/basictypes.h into Common/Common.h (mostly). 2020-09-29 15:51:51 +02:00
Henrik Rydgård d81cbd6969 Linux buildfix 2017-08-31 17:58:31 +02:00
Henrik Rydgård 6a1fa728d8 Remove Globals.h 2017-08-31 17:15:22 +02:00
Unknown W. Brackets 2e1986d0c8 Fix a few reorder warnings. 2016-05-01 09:50:03 -07:00
Unknown W. Brackets 723a2c98af Minor warning fix. 2015-11-18 22:03:35 -08:00
Unknown W. Brackets 09f77509d9 Sas: Reduce ECHO effect repeat level.
Previously, it sounded horrible in Sol Trigger - can be observed in
tutorial boxes when going into battle, for example, and also several other
effects.  Halving this value sounds a lot more correct.

It's not clear what value exactly is correct.
2015-11-08 12:25:30 -08:00
Unknown W. Brackets 11ec29212e Sas: Correct reverb volume going negative.
0x1000 (max vol) << 3 is negative, of course when signed...
2015-11-01 21:30:01 -08:00
Unknown W. Brackets 1aac569e73 Sas: Add in zeroes like the PSP seems to. 2015-11-01 20:56:34 -08:00
Unknown W. Brackets 9c378c4eda Sas: Properly support the OFF reverb type. 2015-11-01 20:33:42 -08:00
Unknown W. Brackets 4a390ea18e Sas: Default to the right preset in reverb.
This needs to match waveformEffect.type, which is the default on the PSP.

Otherwise, setting to OFF initially does nothing, and it remains ROOM.
2015-11-01 20:25:21 -08:00
Henrik Rydgard a941c6e64c Reverb minor optimization, comment changes 2015-10-28 21:43:38 +01:00
Henrik Rydgard 40246e894c Fix buzzsaw noises in reverb by preventing integer wraparound in a couple of places 2015-10-28 21:36:00 +01:00
Henrik Rydgard 541a5e2c51 Halve the reverb input volume as a quick hack. Remove an unnecessary computation. 2015-10-27 16:34:30 +01:00
Henrik Rydgard 07f311fee1 Those multiplications with 4 from the doc ("scaled by 8" but 16-bit data) didn't seem to make lots of sense... Sounds better removing them 2015-10-27 16:12:05 +01:00
Henrik Rydgard 06fec54dba Forgot to scale a multiplication. Slightly better but quickly devolves into harsh noise. 2015-10-27 15:56:11 +01:00
Henrik Rydgard 9bb8aff715 Forgot that the address registers are scaled. still doens't fix it. 2015-10-27 15:52:19 +01:00
Henrik Rydgard 85c8f7d3c2 Hook up SasReverb. It sounds more like a buzzsaw than a reverb at the moment, needs debugging.
Added a bit of code that only enables it when a reverbed sound is active. This will need to be turned off later but useful right now for hearing when it's used..
2015-10-27 12:36:30 +01:00
Henrik Rydgard 0283d00066 Implement a PSX reverb from a specification. Not hooked up. 2015-10-27 11:46:04 +01:00