From e4752a887f0f77abea9f4af9c991656dee721ae2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Henrik=20Rydg=C3=A5rd?= Date: Wed, 10 Jan 2018 16:37:02 +0100 Subject: [PATCH] Fix use-after-free in shader error reporting --- ext/native/thin3d/GLQueueRunner.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/native/thin3d/GLQueueRunner.cpp b/ext/native/thin3d/GLQueueRunner.cpp index 8f63e76f38..4c3260e26e 100644 --- a/ext/native/thin3d/GLQueueRunner.cpp +++ b/ext/native/thin3d/GLQueueRunner.cpp @@ -143,7 +143,6 @@ void GLQueueRunner::RunInitSteps(const std::vector &steps) { step.create_shader.shader->shader = shader; const char *code = step.create_shader.code; glShaderSource(shader, 1, &code, nullptr); - delete[] step.create_shader.code; glCompileShader(shader); GLint success = 0; glGetShaderiv(shader, GL_COMPILE_STATUS, &success); @@ -166,6 +165,7 @@ void GLQueueRunner::RunInitSteps(const std::vector &steps) { #endif step.create_shader.shader->valid = false; } + delete[] step.create_shader.code; delete[] step.create_shader.desc; step.create_shader.shader->valid = true; break;