preserve-emulation/ppsspp
1
0
Fork 0
mirror of https://github.com/hrydgard/ppsspp.git synced 2026-09-05 12:15:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Adjust the level of Claude-based paranoia here and there

Browse Source
This commit is contained in:
Henrik Rydgård
2026-08-11 20:08:01 +02:00
parent a3e0f915af
commit cd052ea640
6 changed files with 24 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Core/Util/AtracTrack.cpp
+2 -11
View File
@@ -201,20 +201,11 @@ int AnalyzeAtracTrack(const u8 *buffer, u32 size, Track *track, std::string *err
*error = StringFromFormat("smpl chunk too small for loop (%d, %d)", checkNumLoops, chunkSize);
return SCE_ERROR_ATRAC_UNKNOWN_FORMAT;
}
if (checkNumLoops < 0) {
u32 maxLoops = chunkSize >= 36 ? (chunkSize - 36) / 24 : 0;
if (checkNumLoops < 0 || checkNumLoops > maxLoops) {
*error = StringFromFormat("bad checkNumLoops (%d)", checkNumLoops);
return SCE_ERROR_ATRAC_UNKNOWN_FORMAT;
}
// checkNumLoops is otherwise just an unvalidated field from the file - left
// unclamped, it could both drive an unbounded (up to ~2 billion entry)
// allocation here, and (since the loop below compares the loop counter `i`
// against chunkSize, rather than the byte offset actually being advanced by
// 24 per iteration) let reads run well past the end of this chunk. Clamp it
// to how many 24-byte loop entries could actually fit.
u32 maxLoops = chunkSize >= 36 ? (chunkSize - 36) / 24 : 0;
if ((u32)checkNumLoops > maxLoops) {
checkNumLoops = (int)maxLoops;
}
track->loopinfo.resize(checkNumLoops);
u32 loopinfoOffset = offset + 36;