From acf7effaeb4ca356cbb95ea931784b229f573ade Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Henrik=20Rydg=C3=A5rd?= Date: Thu, 20 Aug 2026 00:40:20 +0200 Subject: [PATCH] Improve some comments --- Core/MemMap.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Core/MemMap.h b/Core/MemMap.h index 558b0f8fa9..3ca8453104 100644 --- a/Core/MemMap.h +++ b/Core/MemMap.h @@ -359,7 +359,7 @@ inline bool IsValidNAlignedAddress(const u32 address) { if ((address & (0x3E000000 | (A - 1))) == 0x08000000) { return true; } else if ((address & (0xBF800000 | (A - 1))) == 0x04000000) { - return true; // Let's disallow kernel-flagged VRAM. We don't have it mapped and I am not sure if it's accessible. + return true; // 0xBxx above: Let's disallow kernel-flagged VRAM. We don't have it mapped and I am not sure if it's accessible. } else if ((address & (0x3FFFC000 | (A - 1))) == 0x00010000) { return true; } else if ((address & 0x3F000000) >= 0x08000000 && (address & 0x3F000000) < 0x08000000 + g_MemorySize) { @@ -373,7 +373,7 @@ inline u32 MaxSizeAtAddress(const u32 address) { if ((address & 0x3E000000) == 0x08000000) { return 0x08000000 + g_MemorySize - (address & 0x3FFFFFFF); } else if ((address & 0xBF800000) == 0x04000000) { - return 0x04800000 - (address & 0x3FFFFFFF); + return 0x04800000 - (address & 0x3FFFFFFF); // VRAM. Same 0xBxx trick as above, modified for this use case. } else if ((address & 0x3FFFC000) == 0x00010000) { return 0x00014000 - (address & 0x3FFFFFFF); } else if ((address & 0x3F000000) >= 0x08000000 && (address & 0x3F000000) < 0x08000000 + g_MemorySize) { @@ -391,8 +391,8 @@ inline const char *GetCharPointerUnchecked(const u32 address) { inline bool IsValidTextureAddress(const u32 address) { if ((address & 0x3E00000F) == 0x08000000) { return true; // Can texture from RAM (not sure if kernel RAM too, but let's allow it). - } else if ((address & 0xBF80000F) == 0x04000000) { // 0xB makes sure we don't allow kernel-flagged VRAM. - return true; + } else if ((address & 0xBF80000F) == 0x04000000) { + return true; // 0xBxx above: Let's disallow kernel-flagged VRAM. We don't have it mapped and I am not sure if it's accessible. } else if ((address & 0x3E00000F) == 0x08000000 && (address & 0x3F000000) >= 0x08000000 && ((address & 0x3F000000) < 0x08000000 + g_MemorySize)) { return true; // Extended RAM. } else if (IsPPGEAtlasFakeAddress(address, nullptr)) {