From aa3cf34fc13aeffb46dcb73848ea90d1e137f27c Mon Sep 17 00:00:00 2001 From: Henrik Rydgard Date: Wed, 16 Oct 2013 22:30:22 +0200 Subject: [PATCH] Jit: Fix valgrind warnings. The first time PrefixStart was entered with startDefaultPrefix = true, it would call EatPrefix, which checks the so far entirely uninitialized prefixXFlags. --- Core/MIPS/ARM/ArmJit.h | 6 ++++++ Core/MIPS/PPC/PpcJit.h | 5 +++++ Core/MIPS/x86/Jit.h | 5 +++++ 3 files changed, 16 insertions(+) diff --git a/Core/MIPS/ARM/ArmJit.h b/Core/MIPS/ARM/ArmJit.h index 8da416e9d6..0ea20685fd 100644 --- a/Core/MIPS/ARM/ArmJit.h +++ b/Core/MIPS/ARM/ArmJit.h @@ -70,6 +70,12 @@ struct ArmJitState PrefixState prefixSFlag; PrefixState prefixTFlag; PrefixState prefixDFlag; + + ArmJitState() + : prefixSFlag(PREFIX_UNKNOWN), + prefixTFlag(PREFIX_UNKNOWN), + prefixDFlag(PREFIX_UNKNOWN) {} + void PrefixStart() { if (startDefaultPrefix) { EatPrefix(); diff --git a/Core/MIPS/PPC/PpcJit.h b/Core/MIPS/PPC/PpcJit.h index 731d8661e7..d2b163bb1c 100644 --- a/Core/MIPS/PPC/PpcJit.h +++ b/Core/MIPS/PPC/PpcJit.h @@ -51,6 +51,11 @@ namespace MIPSComp PREFIX_KNOWN_DIRTY = 0x11, }; + PpcJitState() + : prefixSFlag(PREFIX_UNKNOWN), + prefixTFlag(PREFIX_UNKNOWN), + prefixDFlag(PREFIX_UNKNOWN) {} + u32 compilerPC; u32 blockStart; bool cancel; diff --git a/Core/MIPS/x86/Jit.h b/Core/MIPS/x86/Jit.h index b8b49ee482..a2f5e52ef1 100644 --- a/Core/MIPS/x86/Jit.h +++ b/Core/MIPS/x86/Jit.h @@ -71,6 +71,11 @@ struct JitState AFTER_REWIND_PC_BAD_STATE = 0x02, }; + JitState() + : prefixSFlag(PREFIX_UNKNOWN), + prefixTFlag(PREFIX_UNKNOWN), + prefixDFlag(PREFIX_UNKNOWN) {} + u32 compilerPC; u32 blockStart; int nextExit;