From 8aa1987d77981cf3fcf44ef2692cc1f4ea3cd4ee Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Henrik=20Rydg=C3=A5rd?= Date: Thu, 16 Oct 2025 15:15:03 +0200 Subject: [PATCH] Disallow configs and cheats for GE dumps, don't try to get icons for dumps loaded from HTTP --- UI/GameInfoCache.cpp | 2 +- UI/PauseScreen.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/UI/GameInfoCache.cpp b/UI/GameInfoCache.cpp index 0a1216a529..6b0a5a8388 100644 --- a/UI/GameInfoCache.cpp +++ b/UI/GameInfoCache.cpp @@ -711,7 +711,7 @@ handleELF: if (flags_ & GameInfoFlags::ICON) { Path screenshotPath = gamePath_.WithReplacedExtension(".ppdmp", ".png"); // Let's use the comparison screenshot as an icon, if it exists. - if (ReadLocalFileToString(screenshotPath, &info_->icon.data, &info_->lock)) { + if (screenshotPath.IsLocalType() && ReadLocalFileToString(screenshotPath, &info_->icon.data, &info_->lock)) { info_->icon.dataLoaded = true; } } diff --git a/UI/PauseScreen.cpp b/UI/PauseScreen.cpp index c6f2eef026..0088dfbebe 100644 --- a/UI/PauseScreen.cpp +++ b/UI/PauseScreen.cpp @@ -539,7 +539,7 @@ void GamePauseScreen::CreateViews() { Choice *delGameConfig = rightColumnItems->Add(new Choice(pa->T("Delete Game Config"))); delGameConfig->OnClick.Handle(this, &GamePauseScreen::OnDeleteConfig); delGameConfig->SetEnabled(!bootPending_); - } else { + } else if (PSP_CoreParameter().fileType != IdentifiedFileType::PPSSPP_GE_DUMP) { rightColumnItems->Add(new Choice(pa->T("Settings")))->OnClick.Handle(this, &GamePauseScreen::OnGameSettings); Choice *createGameConfig = rightColumnItems->Add(new Choice(pa->T("Create Game Config"))); createGameConfig->OnClick.Handle(this, &GamePauseScreen::OnCreateConfig); @@ -549,7 +549,7 @@ void GamePauseScreen::CreateViews() { rightColumnItems->Add(new Choice(gr->T("Display layout & effects")))->OnClick.Add([&](UI::EventParams &) -> void { screenManager()->push(new DisplayLayoutScreen(gamePath_)); }); - if (g_Config.bEnableCheats) { + if (g_Config.bEnableCheats && PSP_CoreParameter().fileType != IdentifiedFileType::PPSSPP_GE_DUMP) { rightColumnItems->Add(new Choice(pa->T("Cheats")))->OnClick.Add([&](UI::EventParams &e) { screenManager()->push(new CwCheatScreen(gamePath_)); });