preserve-emulation/ppsspp
1
0
Fork 0
mirror of https://github.com/hrydgard/ppsspp.git synced 2026-09-04 03:35:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Improve semantics

Browse Source
This commit is contained in:
Henrik Rydgård
2026-08-10 10:11:24 +02:00
parent 2c4e3e241c
commit 66c8bfbcb2
9 changed files with 66 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Core/Debugger/DisassemblyManager.cpp
+10 -5
View File
@@ -790,7 +790,12 @@ void DisassemblyData::createLines()
lineAddresses.clear();
u32 pos = address;
const u32 end = address+size;
const u32 end = address + size;
if (!Memory::IsValidRange(address, size)) {
ERROR_LOG(Log::CPU, "DisassemblyData can't create lines for invalid range 0x%08X-0x%08X", address, end);
}
const u32 maxChars = g_disassemblyManager.getMaxParamChars();
std::string currentLine;
@@ -802,7 +807,7 @@ void DisassemblyData::createLines()
bool inString = false;
while (pos < end)
{
u8 b = Memory::Read_U8(pos++);
u8 b = Memory::ReadUnchecked_U8(pos++);
if (b >= 0x20 && b <= 0x7F)
{
if (currentLine.size()+1 >= maxChars)
@@ -879,18 +884,18 @@ void DisassemblyData::createLines()
switch (type)
{
case DATATYPE_BYTE:
value = Memory::Read_U8(pos);
value = Memory::ReadUnchecked_U8(pos);
snprintf(buffer, sizeof(buffer), "0x%02X", value);
pos++;
break;
case DATATYPE_HALFWORD:
value = Memory::Read_U16(pos);
value = Memory::ReadUnchecked_U16(pos);
snprintf(buffer, sizeof(buffer), "0x%04X", value);
pos += 2;
break;
case DATATYPE_WORD:
{
value = Memory::Read_U32(pos);
value = Memory::ReadUnchecked_U32(pos);
const std::string label = g_symbolMap->GetLabelString(value);
if (!label.empty())
snprintf(buffer, sizeof(buffer), "%s", label.c_str());