preserve-emulation/ppsspp
1
0
Fork 0
mirror of https://github.com/hrydgard/ppsspp.git synced 2026-09-07 13:13:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

Remove 'started' bool from worker threads, as fixes for spurious wakeups made it obsolete

Browse Source
This commit is contained in:
Silent
2019-08-11 14:03:53 +02:00
parent 0639ffcfb5
commit 400a6f3057
2 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ext/native/thread/threadpool.cpp
-4
View File
@@ -6,7 +6,6 @@
WorkerThread::WorkerThread() {
thread.reset(new std::thread(std::bind(&WorkerThread::WorkFunc, this)));
while(!started) { };
}
WorkerThread::~WorkerThread() {
@@ -35,7 +34,6 @@ void WorkerThread::WaitForCompletion() {
void WorkerThread::WorkFunc() {
setCurrentThreadName("Worker");
std::unique_lock<std::mutex> guard(mutex);
started = true;
while (active) {
// 'active == false' is one of the conditions for signaling,
// do not "optimize" it
@@ -54,7 +52,6 @@ void WorkerThread::WorkFunc() {
LoopWorkerThread::LoopWorkerThread() : WorkerThread(true) {
thread.reset(new std::thread(std::bind(&LoopWorkerThread::WorkFunc, this)));
while (!started) { };
}
void LoopWorkerThread::Process(std::function<void(int, int)> work, int start, int end) {
@@ -69,7 +66,6 @@ void LoopWorkerThread::Process(std::function<void(int, int)> work, int start, in
void LoopWorkerThread::WorkFunc() {
setCurrentThreadName("LoopWorker");
std::unique_lock<std::mutex> guard(mutex);
started = true;
while (active) {
// 'active == false' is one of the conditions for signaling,
// do not "optimize" it