From 3fe0b5a4f940b87b67eabf19da30ce3f7aefb545 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Henrik=20Rydg=C3=A5rd?= <hrydgard@gmail.com>
Date: Sun, 16 Jul 2023 08:57:08 +0200
Subject: [PATCH] Best-practice-clear the password string.

---
 UI/RetroAchievementScreens.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/UI/RetroAchievementScreens.cpp b/UI/RetroAchievementScreens.cpp
index 89cc97c373..a0c7329d2f 100644
--- a/UI/RetroAchievementScreens.cpp
+++ b/UI/RetroAchievementScreens.cpp
@@ -246,6 +246,7 @@ void RetroAchievementsSettingsScreen::CreateAccountTab(UI::ViewGroup *viewGroup)
 			loginButton->OnClick.Add([=](UI::EventParams &) -> UI::EventReturn {
 				if (!username_.empty() && !password_.empty()) {
 					Achievements::LoginAsync(username_.c_str(), password_.c_str());
+					memset(&password_[0], 0, password_.size());
 					password_.clear();
 				}
 				return UI::EVENT_DONE;