From 3352ba44bb2b29b408aaa10dbea87c9aad0f6bac Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Henrik=20Rydg=C3=A5rd?= Date: Thu, 5 Mar 2026 01:50:41 +0100 Subject: [PATCH] Remove misguided hack to signal that we handled key repeats. Fixes #21336 --- Common/UI/View.h | 2 +- Core/ControlMapper.cpp | 5 ----- android/src/org/ppsspp/ppsspp/PpssppActivity.java | 2 +- 3 files changed, 2 insertions(+), 7 deletions(-) diff --git a/Common/UI/View.h b/Common/UI/View.h index 94077ee92c..8d41e81462 100644 --- a/Common/UI/View.h +++ b/Common/UI/View.h @@ -577,7 +577,7 @@ private: Style style_; std::string text_; ImageID imageID_; - std::function imageFunc_; + std::function imageFunc_{}; int paddingW_ = 16; int paddingH_ = 8; float scale_ = 1.0f; diff --git a/Core/ControlMapper.cpp b/Core/ControlMapper.cpp index 9cdb42d3ce..8f1096fdd6 100644 --- a/Core/ControlMapper.cpp +++ b/Core/ControlMapper.cpp @@ -531,11 +531,6 @@ bool ControlMapper::UpdatePSPState(const InputMapping &changedMapping, double no } bool ControlMapper::Key(const KeyInput &key, bool *pauseTrigger) { - if (key.flags & KeyInputFlags::IS_REPEAT) { - // Claim that we handled this. Prevents volume key repeats from popping up the volume control on Android. - return true; - } - double now = time_now_d(); InputMapping mapping(key.deviceId, key.keyCode); diff --git a/android/src/org/ppsspp/ppsspp/PpssppActivity.java b/android/src/org/ppsspp/ppsspp/PpssppActivity.java index 0f51934df8..fb79a283cd 100644 --- a/android/src/org/ppsspp/ppsspp/PpssppActivity.java +++ b/android/src/org/ppsspp/ppsspp/PpssppActivity.java @@ -1284,7 +1284,7 @@ public class PpssppActivity extends AppCompatActivity implements SensorEventList @RequiresApi(Build.VERSION_CODES.N) void sendMouseDelta(float dx, float dy) { // Ignore zero deltas. - if (Math.abs(dx) > 0.001 || Math.abs(dx) > 0.001) { + if (Math.abs(dx) > 0.001 || Math.abs(dy) > 0.001) { NativeApp.mouseDelta(dx, dy); } }